[GitHub] [incubator-nuttx] Ouss4 commented on a change in pull request #4701: tools/esp32: Refactor generation of QEMU-compatible image

[GitBox <gi...@apache.org>]

Ouss4 commented on a change in pull request #4701:
URL: https://github.com/apache/incubator-nuttx/pull/4701#discussion_r732103627



##########
File path: Documentation/platforms/xtensa/esp32/index.rst
##########
@@ -329,15 +329,19 @@ Using QEMU
 ==========
 
 First follow the instructions `here <https://github.com/espressif/qemu/wiki>`_ to build QEMU.
-Enable the ESP32_QEMU_IMAGE config found in "Board Selection -> ESP32 binary image for QEMU".
+
+Enable the ``ESP32_QEMU_IMAGE`` config found in :menuselection:`Board Selection --> ESP32 binary image for QEMU`.
+
 Download the bootloader and the partition table from https://github.com/espressif/esp-nuttx-bootloader/releases
-and place them in a directory, say ../esp-bins.
-Build and generate the QEMU image: `make ESPTOOL_BINDIR=../esp-bins`
-A new image "esp32_qemu_image.bin" will be created.  It can be run as::
+and place them in a directory, say ``../esp-bins``.
+
+Build and generate the QEMU image::
+
+ $ make ESPTOOL_BINDIR=../esp-bins
+
+A new image ``nuttx.merged.bin`` will be created. It can be run as::

Review comment:
       Can we use a different wording here.  The "new" adjective here seems to indicate that we were not creating this binary before, it was the case, but now it's the same binary (at least the same name :) )




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org