You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "sajalsuhane (via GitHub)" <gi...@apache.org> on 2024/03/22 23:54:32 UTC
[PR] Cast "time" as TimestampType [spark]
sajalsuhane opened a new pull request, #45675:
URL: https://github.com/apache/spark/pull/45675
### What changes were proposed in this pull request?
We are proposing a new string "time" to be casted as TimestampType
### Why are the changes needed?
Gives flexibility to users to use CatalystSqlParser
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Required tests were added
### Was this patch authored or co-authored using generative AI tooling?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [WIP] Cast "time" as TimestampType [spark]
Posted by "sajalsuhane (via GitHub)" <gi...@apache.org>.
sajalsuhane commented on PR #45675:
URL: https://github.com/apache/spark/pull/45675#issuecomment-2017055265
> Isn't Time type different from Timestamp type? It doesn't contain date part, no?
Yeah, but I don’t think we have a time type. So just for simplicity why not just make it a timestamp?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [WIP] Cast "time" as TimestampType [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #45675:
URL: https://github.com/apache/spark/pull/45675#issuecomment-2016993950
Isn't Time type different from Timestamp type? It doesn't contain date part, no?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [WIP] Cast "time" as TimestampType [spark]
Posted by "sajalsuhane (via GitHub)" <gi...@apache.org>.
sajalsuhane closed pull request #45675: [WIP] Cast "time" as TimestampType
URL: https://github.com/apache/spark/pull/45675
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [WIP] Cast "time" as TimestampType [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #45675:
URL: https://github.com/apache/spark/pull/45675#issuecomment-2017102358
Why do we map the incorrect type ? What if we support in the future? We can't simply map int to long for example
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [WIP] Cast "time" as TimestampType [spark]
Posted by "sajalsuhane (via GitHub)" <gi...@apache.org>.
sajalsuhane commented on PR #45675:
URL: https://github.com/apache/spark/pull/45675#issuecomment-2016922334
@hvanhovell seems like you updated this method. Am I missing something here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [WIP] Cast "time" as TimestampType [spark]
Posted by "sajalsuhane (via GitHub)" <gi...@apache.org>.
sajalsuhane commented on PR #45675:
URL: https://github.com/apache/spark/pull/45675#issuecomment-2017107820
> Why do we map the incorrect type ? What if we support in the future? We can't simply map int to long for example
Makes sense! I was thinking to have it till we have support for TimeType. But anyways, closing this for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org