You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2021/01/21 08:30:36 UTC
[GitHub] [druid] zhangyue19921010 opened a new pull request #10785: K8s IT Test enhance
zhangyue19921010 opened a new pull request #10785:
URL: https://github.com/apache/druid/pull/10785
<!-- Thanks for trying to help us make Apache Druid be the best it can be! Please fill out as much of the following information as is possible (where relevant, and remove it when irrelevant) to help make the intention and scope of this PR clear in order to ease review. -->
Fixes https://github.com/apache/druid/issues/10750.
<!-- Replace XXXX with the id of the issue fixed in this PR. Remove this section if there is no corresponding issue. Don't reference the issue in the title of this pull-request. -->
<!-- If you are a committer, follow the PR action item checklist for committers:
https://github.com/apache/druid/blob/master/dev/committer-instructions.md#pr-and-issue-action-item-checklist-for-committers. -->
### Description
<!-- Describe the goal of this PR, what problem are you fixing. If there is a corresponding issue (referenced above), it's not necessary to repeat the description here, however, you may choose to keep one summary sentence. -->
<!-- Describe your patch: what did you change in code? How did you fix the problem? -->
<!-- If there are several relatively logically separate changes in this PR, create a mini-section for each of them. For example: -->
do the creation and cleanup of the cluster in integration tests instead of relying on the Travis script
<!--
In each section, please describe design decisions made, including:
- Choice of algorithms
- Behavioral aspects. What configuration values are acceptable? How are corner cases and error conditions handled, such as when there are insufficient resources?
- Class organization and design (how the logic is split between classes, inheritance, composition, design patterns)
- Method organization and design (how the logic is split between methods, parameters and return types)
- Naming (class, method, API, configuration, HTTP endpoint, names of emitted metrics)
-->
<!-- It's good to describe an alternative design (or mention an alternative name) for every design (or naming) decision point and compare the alternatives with the designs that you've implemented (or the names you've chosen) to highlight the advantages of the chosen designs and names. -->
<!-- If there was a discussion of the design of the feature implemented in this PR elsewhere (e. g. a "Proposal" issue, any other issue, or a thread in the development mailing list), link to that discussion from this PR description and explain what have changed in your final design compared to your original proposal or the consensus version in the end of the discussion. If something hasn't changed since the original discussion, you can omit a detailed discussion of those aspects of the design here, perhaps apart from brief mentioning for the sake of readability of this PR description. -->
<!-- Some of the aspects mentioned above may be omitted for simple and small changes. -->
<hr>
This PR has:
- [ ] been self-reviewed.
- [ ] using the [concurrency checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md) (Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/licenses.yaml)
- [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
<!-- Check the items by putting "x" in the brackets for the done things. Not all of these items apply to every PR. Remove the items which are not done or not relevant to the PR. None of the items from the checklist above are strictly necessary, but it would be very helpful if you at least self-review the PR. -->
<hr>
##### Key changed/added classes in this PR
* `MyFoo`
* `OurBar`
* `TheirBaz`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] zhangyue19921010 edited a comment on pull request #10785: K8s IT Test enhance
Posted by GitBox <gi...@apache.org>.
zhangyue19921010 edited a comment on pull request #10785:
URL: https://github.com/apache/druid/pull/10785#issuecomment-767490121
Hi @himanshug All modifications have been completed. Thanks a lot for your review!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] zhangyue19921010 closed pull request #10785: [WIP]K8s IT Test enhance
Posted by GitBox <gi...@apache.org>.
zhangyue19921010 closed pull request #10785:
URL: https://github.com/apache/druid/pull/10785
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] himanshug commented on a change in pull request #10785: K8s IT Test enhance
Posted by GitBox <gi...@apache.org>.
himanshug commented on a change in pull request #10785:
URL: https://github.com/apache/druid/pull/10785#discussion_r562867462
##########
File path: .travis.yml
##########
@@ -565,13 +565,10 @@ jobs:
jdk: openjdk8
services: &integration_test_services_k8s
- docker
- env: CONFIG_FILE='k8s_run_config_file.json' IT_TEST='-Dit.test=ITNestedQueryPushDownTest' POD_NAME=int-test POD_NAMESPACE=default
- before_script:
- - integration-tests/script/setup_k8s_cluster.sh
- - integration-tests/script/setup_druid_operator_on_k8s.sh
- - integration-tests/script/setup_druid_on_k8s.sh
+ before_script: export DRUID_HOME=`pwd`
Review comment:
can we move this into `build_run_k8s_cluster.sh` so that maven based test run automatically gets it.
##########
File path: .travis.yml
##########
@@ -565,13 +565,10 @@ jobs:
jdk: openjdk8
services: &integration_test_services_k8s
- docker
- env: CONFIG_FILE='k8s_run_config_file.json' IT_TEST='-Dit.test=ITNestedQueryPushDownTest' POD_NAME=int-test POD_NAMESPACE=default
- before_script:
- - integration-tests/script/setup_k8s_cluster.sh
- - integration-tests/script/setup_druid_operator_on_k8s.sh
- - integration-tests/script/setup_druid_on_k8s.sh
+ before_script: export DRUID_HOME=`pwd`
+ env: CONFIG_FILE='k8s_run_config_file.json' IT_TEST='-Dit.test=ITNestedQueryPushDownTest' POD_NAME=int-test POD_NAMESPACE=default BUILD_DRUID_CLSUTER=true
script: &run_integration_test_k8s
- - ${MVN} verify -pl integration-tests -P int-tests-config-file ${IT_TEST} ${MAVEN_SKIP}
+ - ${MVN} verify -pl integration-tests -P int-tests-config-file ${IT_TEST} ${MAVEN_SKIP} -Dpod.name=${POD_NAME} -Dpod.namespace=${POD_NAMESPACE} -Dbuild.druid.cluster=${BUILD_DRUID_CLSUTER}
after_script: integration-tests/script/stop_k8s_cluster.sh
Review comment:
why do we still need this `after_script` ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] himanshug merged pull request #10785: K8s IT Test enhance
Posted by GitBox <gi...@apache.org>.
himanshug merged pull request #10785:
URL: https://github.com/apache/druid/pull/10785
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] zhangyue19921010 commented on pull request #10785: K8s IT Test enhance
Posted by GitBox <gi...@apache.org>.
zhangyue19921010 commented on pull request #10785:
URL: https://github.com/apache/druid/pull/10785#issuecomment-771243202
hi @himanshug thanks a lot for your review and merge!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] himanshug commented on a change in pull request #10785: K8s IT Test enhance
Posted by GitBox <gi...@apache.org>.
himanshug commented on a change in pull request #10785:
URL: https://github.com/apache/druid/pull/10785#discussion_r562867462
##########
File path: .travis.yml
##########
@@ -565,13 +565,10 @@ jobs:
jdk: openjdk8
services: &integration_test_services_k8s
- docker
- env: CONFIG_FILE='k8s_run_config_file.json' IT_TEST='-Dit.test=ITNestedQueryPushDownTest' POD_NAME=int-test POD_NAMESPACE=default
- before_script:
- - integration-tests/script/setup_k8s_cluster.sh
- - integration-tests/script/setup_druid_operator_on_k8s.sh
- - integration-tests/script/setup_druid_on_k8s.sh
+ before_script: export DRUID_HOME=`pwd`
Review comment:
can we move this into `build_run_k8s_cluster.sh` so that maven based test run automatically gets it.
##########
File path: .travis.yml
##########
@@ -565,13 +565,10 @@ jobs:
jdk: openjdk8
services: &integration_test_services_k8s
- docker
- env: CONFIG_FILE='k8s_run_config_file.json' IT_TEST='-Dit.test=ITNestedQueryPushDownTest' POD_NAME=int-test POD_NAMESPACE=default
- before_script:
- - integration-tests/script/setup_k8s_cluster.sh
- - integration-tests/script/setup_druid_operator_on_k8s.sh
- - integration-tests/script/setup_druid_on_k8s.sh
+ before_script: export DRUID_HOME=`pwd`
+ env: CONFIG_FILE='k8s_run_config_file.json' IT_TEST='-Dit.test=ITNestedQueryPushDownTest' POD_NAME=int-test POD_NAMESPACE=default BUILD_DRUID_CLSUTER=true
script: &run_integration_test_k8s
- - ${MVN} verify -pl integration-tests -P int-tests-config-file ${IT_TEST} ${MAVEN_SKIP}
+ - ${MVN} verify -pl integration-tests -P int-tests-config-file ${IT_TEST} ${MAVEN_SKIP} -Dpod.name=${POD_NAME} -Dpod.namespace=${POD_NAMESPACE} -Dbuild.druid.cluster=${BUILD_DRUID_CLSUTER}
after_script: integration-tests/script/stop_k8s_cluster.sh
Review comment:
why do we still need this `after_script` ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] himanshug merged pull request #10785: K8s IT Test enhance
Posted by GitBox <gi...@apache.org>.
himanshug merged pull request #10785:
URL: https://github.com/apache/druid/pull/10785
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] zhangyue19921010 edited a comment on pull request #10785: K8s IT Test enhance
Posted by GitBox <gi...@apache.org>.
zhangyue19921010 edited a comment on pull request #10785:
URL: https://github.com/apache/druid/pull/10785#issuecomment-765170649
Since Job 73 in CI is successful. I think this PR is ready for review.
Although job 66 is failed. Retry will be successful I think as it is not this pr related.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] zhangyue19921010 edited a comment on pull request #10785: K8s IT Test enhance
Posted by GitBox <gi...@apache.org>.
zhangyue19921010 edited a comment on pull request #10785:
URL: https://github.com/apache/druid/pull/10785#issuecomment-765170649
Since Job 73 in CI is successful. I think this PR is ready for review.
Although job 40 is failed. Retry will be successful I think as it is not this pr related.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] zhangyue19921010 commented on pull request #10785: K8s IT Test enhance
Posted by GitBox <gi...@apache.org>.
zhangyue19921010 commented on pull request #10785:
URL: https://github.com/apache/druid/pull/10785#issuecomment-767490121
Hi @himanshug All modifications have been completed. Thanks for your review!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] zhangyue19921010 commented on pull request #10785: K8s IT Test enhance
Posted by GitBox <gi...@apache.org>.
zhangyue19921010 commented on pull request #10785:
URL: https://github.com/apache/druid/pull/10785#issuecomment-765170649
Since Job 73 in CI is successful. I think this PR is ready for review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] zhangyue19921010 commented on a change in pull request #10785: K8s IT Test enhance
Posted by GitBox <gi...@apache.org>.
zhangyue19921010 commented on a change in pull request #10785:
URL: https://github.com/apache/druid/pull/10785#discussion_r564231166
##########
File path: .travis.yml
##########
@@ -565,13 +565,10 @@ jobs:
jdk: openjdk8
services: &integration_test_services_k8s
- docker
- env: CONFIG_FILE='k8s_run_config_file.json' IT_TEST='-Dit.test=ITNestedQueryPushDownTest' POD_NAME=int-test POD_NAMESPACE=default
- before_script:
- - integration-tests/script/setup_k8s_cluster.sh
- - integration-tests/script/setup_druid_operator_on_k8s.sh
- - integration-tests/script/setup_druid_on_k8s.sh
+ before_script: export DRUID_HOME=`pwd`
+ env: CONFIG_FILE='k8s_run_config_file.json' IT_TEST='-Dit.test=ITNestedQueryPushDownTest' POD_NAME=int-test POD_NAMESPACE=default BUILD_DRUID_CLSUTER=true
script: &run_integration_test_k8s
- - ${MVN} verify -pl integration-tests -P int-tests-config-file ${IT_TEST} ${MAVEN_SKIP}
+ - ${MVN} verify -pl integration-tests -P int-tests-config-file ${IT_TEST} ${MAVEN_SKIP} -Dpod.name=${POD_NAME} -Dpod.namespace=${POD_NAMESPACE} -Dbuild.druid.cluster=${BUILD_DRUID_CLSUTER}
after_script: integration-tests/script/stop_k8s_cluster.sh
Review comment:
No need actually. Just removed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] zhangyue19921010 commented on pull request #10785: K8s IT Test enhance
Posted by GitBox <gi...@apache.org>.
zhangyue19921010 commented on pull request #10785:
URL: https://github.com/apache/druid/pull/10785#issuecomment-771243202
hi @himanshug thanks a lot for your review and merge!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] zhangyue19921010 closed pull request #10785: [WIP]K8s IT Test enhance
Posted by GitBox <gi...@apache.org>.
zhangyue19921010 closed pull request #10785:
URL: https://github.com/apache/druid/pull/10785
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] zhangyue19921010 commented on pull request #10785: [WIP]K8s IT Test enhance
Posted by GitBox <gi...@apache.org>.
zhangyue19921010 commented on pull request #10785:
URL: https://github.com/apache/druid/pull/10785#issuecomment-764593267
Still need to deal with DIR properly
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] zhangyue19921010 commented on pull request #10785: [WIP]K8s IT Test enhance
Posted by GitBox <gi...@apache.org>.
zhangyue19921010 commented on pull request #10785:
URL: https://github.com/apache/druid/pull/10785#issuecomment-764593267
Still need to deal with DIR properly
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] zhangyue19921010 commented on a change in pull request #10785: K8s IT Test enhance
Posted by GitBox <gi...@apache.org>.
zhangyue19921010 commented on a change in pull request #10785:
URL: https://github.com/apache/druid/pull/10785#discussion_r564231558
##########
File path: .travis.yml
##########
@@ -565,13 +565,10 @@ jobs:
jdk: openjdk8
services: &integration_test_services_k8s
- docker
- env: CONFIG_FILE='k8s_run_config_file.json' IT_TEST='-Dit.test=ITNestedQueryPushDownTest' POD_NAME=int-test POD_NAMESPACE=default
- before_script:
- - integration-tests/script/setup_k8s_cluster.sh
- - integration-tests/script/setup_druid_operator_on_k8s.sh
- - integration-tests/script/setup_druid_on_k8s.sh
+ before_script: export DRUID_HOME=`pwd`
Review comment:
Sure, done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org