[jira] [Commented] (HBASE-4884) Allow environment overrides for various HBase processes

["Hadoop QA (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-4884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13158910#comment-13158910 ] 

Hadoop QA commented on HBASE-4884:
----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12505391/hbase-4884.txt
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    -1 javadoc.  The javadoc tool appears to have generated -162 warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    -1 findbugs.  The patch appears to introduce 67 new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

     -1 core tests.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.client.TestAdmin
                  org.apache.hadoop.hbase.client.TestInstantSchemaChange
                  org.apache.hadoop.hbase.master.TestDistributedLogSplitting

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/396//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/396//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/396//console

This message is automatically generated.
                
> Allow environment overrides for various HBase processes
> -------------------------------------------------------
>
>                 Key: HBASE-4884
>                 URL: https://issues.apache.org/jira/browse/HBASE-4884
>             Project: HBase
>          Issue Type: Improvement
>          Components: shell
>            Reporter: Ryan Thiessen
>            Priority: Minor
>         Attachments: hbase-4884.txt
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> The current shell scripts have no mechanism for granting different environments to various HBase subcomponents.  Sometimes we want to customize these, for example to run the thrift command with a lower HBASE_HEAPSIZE than what we grant the regionservers.
> Checking for the presence of an override file and then sourcing it if present allows me to override this heapsize or any other variable.
> Test process:
> * tested with file missing. no problem, used default conf/hbase-env.sh settings.
> * tested with conf/hbase-env-thrift.sh file with heap size of 1234. ps axww showed -Xmx1234m
> * started regionserver using bin/hadoop-daemon.sh
> * started hbase shell
> * ran some jruby scripts via bin/hbase org.jruby.Main
> * running in production for approx 2 weeks.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira