You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mesos.apache.org by bm...@apache.org on 2018/03/24 06:29:30 UTC
mesos git commit: Added a temporary CHECK to diagnose MESOS-8687.
Repository: mesos
Updated Branches:
refs/heads/master 2ad96bfe3 -> 2132b66c3
Added a temporary CHECK to diagnose MESOS-8687.
>From the stack trace in MESOS-8687, it appears the `httpSequence`
within `ProcessBase` was null during `ProcessBase::_consume`. In
order to diagnose how this can occur, this adds a CHECK that will
print the pid and endpoint name.
Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/2132b66c
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/2132b66c
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/2132b66c
Branch: refs/heads/master
Commit: 2132b66c37bfd5ba7ae1cde74aa8ddb8d6c23bce
Parents: 2ad96bf
Author: Benjamin Mahler <bm...@apache.org>
Authored: Fri Mar 23 23:27:26 2018 -0700
Committer: Benjamin Mahler <bm...@apache.org>
Committed: Fri Mar 23 23:27:26 2018 -0700
----------------------------------------------------------------------
3rdparty/libprocess/src/process.cpp | 4 ++++
1 file changed, 4 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/mesos/blob/2132b66c/3rdparty/libprocess/src/process.cpp
----------------------------------------------------------------------
diff --git a/3rdparty/libprocess/src/process.cpp b/3rdparty/libprocess/src/process.cpp
index a3a96a3..9eb3746 100644
--- a/3rdparty/libprocess/src/process.cpp
+++ b/3rdparty/libprocess/src/process.cpp
@@ -3687,6 +3687,10 @@ Future<Response> ProcessBase::_consume(
*request, endpoint.realm.get());
}
+ // TODO(bmahler): This is an interim check to diagnose MESOS-8687.
+ CHECK(handlers.httpSequence.get() != nullptr)
+ << "PID '" << pid << "' with endpoint name '" << name << "'";
+
// Sequence the authentication future to ensure the handlers
// are invoked in the same order that requests arrive.
authentication = handlers.httpSequence->add<Option<AuthenticationResult>>(