You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by jl...@apache.org on 2025/11/01 02:25:45 UTC

(superset) branch feat-remove-cypress-auth-tests created (now c3a5ba560a)

This is an automated email from the ASF dual-hosted git repository.

jli pushed a change to branch feat-remove-cypress-auth-tests
in repository https://gitbox.apache.org/repos/asf/superset.git


      at c3a5ba560a feat(playwright): make auth tests required and remove Cypress auth tests

This branch includes the following new commits:

     new c3a5ba560a feat(playwright): make auth tests required and remove Cypress auth tests

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.



(superset) 01/01: feat(playwright): make auth tests required and remove Cypress auth tests

Posted by jl...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

jli pushed a commit to branch feat-remove-cypress-auth-tests
in repository https://gitbox.apache.org/repos/asf/superset.git

commit c3a5ba560a3ace1c18dadef96f8e5d5942d8b030
Author: Joe Li <jo...@preset.io>
AuthorDate: Fri Oct 31 19:23:33 2025 -0700

    feat(playwright): make auth tests required and remove Cypress auth tests
    
    Removes the deprecated Cypress authentication tests and makes Playwright
    authentication tests required for CI by removing shadow mode.
    
    Changes:
    - Remove `continue-on-error: true` from Playwright workflow
    - Delete `superset-frontend/cypress-base/cypress/e2e/auth/login.test.ts`
    - Playwright auth tests now block CI on failure
    
    The Playwright tests have been running in parallel with Cypress tests
    long enough to validate reliability with no false positives/negatives.
    Playwright provides full test coverage with enhanced error detection
    through Page Object Model pattern and multiple selector strategies.
    
    Both app_root configurations ("" and "/app/prefix") are tested and
    validated by the Playwright workflow.
    
    🤖 Generated with [Claude Code](https://claude.com/claude-code)
    
    Co-Authored-By: Claude <no...@anthropic.com>
---
 .github/workflows/superset-playwright.yml          |  2 -
 .../cypress-base/cypress/e2e/auth/login.test.ts    | 49 ----------------------
 2 files changed, 51 deletions(-)

diff --git a/.github/workflows/superset-playwright.yml b/.github/workflows/superset-playwright.yml
index 0a94ef89d0..0e82f25308 100644
--- a/.github/workflows/superset-playwright.yml
+++ b/.github/workflows/superset-playwright.yml
@@ -25,8 +25,6 @@ concurrency:
 jobs:
   playwright-tests:
     runs-on: ubuntu-22.04
-    # Allow workflow to succeed even if tests fail during shadow mode
-    continue-on-error: true
     permissions:
       contents: read
       pull-requests: read
diff --git a/superset-frontend/cypress-base/cypress/e2e/auth/login.test.ts b/superset-frontend/cypress-base/cypress/e2e/auth/login.test.ts
deleted file mode 100644
index 064167d82d..0000000000
--- a/superset-frontend/cypress-base/cypress/e2e/auth/login.test.ts
+++ /dev/null
@@ -1,49 +0,0 @@
-/**
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements.  See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership.  The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License.  You may obtain a copy of the License at
- *
- *   http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied.  See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
-import { LOGIN } from 'cypress/utils/urls';
-
-function interceptLogin() {
-  cy.intercept('POST', '**/login/').as('login');
-}
-
-describe('Login view', () => {
-  beforeEach(() => {
-    cy.visit(LOGIN);
-  });
-
-  it('should redirect to login with incorrect username and password', () => {
-    interceptLogin();
-    cy.getBySel('login-form').should('be.visible');
-    cy.getBySel('username-input').type('admin');
-    cy.getBySel('password-input').type('wrongpassword');
-    cy.getBySel('login-button').click();
-    cy.wait('@login');
-    cy.url().should('include', LOGIN);
-  });
-
-  it('should login with correct username and password', () => {
-    interceptLogin();
-    cy.getBySel('login-form').should('be.visible');
-    cy.getBySel('username-input').type('admin');
-    cy.getBySel('password-input').type('general');
-    cy.getBySel('login-button').click();
-    cy.wait('@login');
-    cy.getCookies().should('have.length', 1);
-  });
-});