[GitHub] [helix] pkuwm commented on a change in pull request #548: Add max capacity usage metric for instance monitor.

[GitBox <gi...@apache.org>]

pkuwm commented on a change in pull request #548: Add max capacity usage metric for instance monitor.
URL: https://github.com/apache/helix/pull/548#discussion_r341319420
 
 

 ##########
 File path: helix-core/src/main/java/org/apache/helix/monitoring/mbeans/InstanceMonitor.java
 ##########
 @@ -61,24 +112,20 @@ public String getSensorName() {
         serializedTags(), _participantName);
   }
 
-  @Override
   public long getOnline() {
-    return _isUp ? 1 : 0;
+    return _onlineStatusGauge.getValue();
   }
 
-  @Override
   public long getEnabled() {
-    return _isEnabled ? 1 : 0;
+    return _enabledStatusGauge.getValue();
   }
 
-  @Override
   public long getTotalMessageReceived() {
-    return _totalMessageReceived;
+    return _totalMessagedReceivedCounter.getValue();
   }
 
-  @Override
   public long getDisabledPartitions() {
-    return _disabledPartitions;
+    return _disabledPartitionsGauge.getValue();
 
 Review comment:
   I was considering this. Why I do this is want to make it consistent with getOnline() and getEnabled(). 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org