You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by avidigmi <gi...@git.apache.org> on 2015/06/18 13:38:36 UTC

[GitHub] lucene-solr pull request: Loading the AuthenticationPlugin using t...

GitHub user avidigmi opened a pull request:

    https://github.com/apache/lucene-solr/pull/154

    Loading the AuthenticationPlugin using the ResourceLoader.

    Tried to use an <b>AuthenticationPlugin</b> but it seems that loading it using <b>Class.forName</b> introduces an issue to find Solr's <b>AuthenticationPlugin</b>.
    
    Furthermore, I think the way of loading the <b>AuthenticationPlugin</b> should be the same as loading the <b>AuthorizationPlugin</b>.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/avidigmi/lucene-solr lucene_solr_5_2

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/lucene-solr/pull/154.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #154
    
----
commit 6aa46b927c4b4e18df71168c13445661a289c66b
Author: Avi Digmi <di...@gmail.com>
Date:   2015-06-18T11:13:41Z

    Loading the AuthenticationPlugin using the ResourceLoader.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[GitHub] lucene-solr pull request: Loading the AuthenticationPlugin using t...

Posted by avidigmi <gi...@git.apache.org>.
Github user avidigmi closed the pull request at:

    https://github.com/apache/lucene-solr/pull/154


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Re: [GitHub] lucene-solr pull request: Loading the AuthenticationPlugin using t...

Posted by Anshum Gupta <an...@anshumgupta.net>.
I committed this but forgot to add the correct commit message. Kindly close
the request manually.

On Thu, Jun 18, 2015 at 4:38 AM, avidigmi <gi...@git.apache.org> wrote:

> GitHub user avidigmi opened a pull request:
>
>     https://github.com/apache/lucene-solr/pull/154
>
>     Loading the AuthenticationPlugin using the ResourceLoader.
>
>     Tried to use an <b>AuthenticationPlugin</b> but it seems that loading
> it using <b>Class.forName</b> introduces an issue to find Solr's
> <b>AuthenticationPlugin</b>.
>
>     Furthermore, I think the way of loading the
> <b>AuthenticationPlugin</b> should be the same as loading the
> <b>AuthorizationPlugin</b>.
>
> You can merge this pull request into a Git repository by running:
>
>     $ git pull https://github.com/avidigmi/lucene-solr lucene_solr_5_2
>
> Alternatively you can review and apply these changes as the patch at:
>
>     https://github.com/apache/lucene-solr/pull/154.patch
>
> To close this pull request, make a commit to your master/trunk branch
> with (at least) the following in the commit message:
>
>     This closes #154
>
> ----
> commit 6aa46b927c4b4e18df71168c13445661a289c66b
> Author: Avi Digmi <di...@gmail.com>
> Date:   2015-06-18T11:13:41Z
>
>     Loading the AuthenticationPlugin using the ResourceLoader.
>
> ----
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: dev-help@lucene.apache.org
>
>


-- 
Anshum Gupta

[GitHub] lucene-solr pull request: Loading the AuthenticationPlugin using t...

Posted by avidigmi <gi...@git.apache.org>.
Github user avidigmi commented on the pull request:

    https://github.com/apache/lucene-solr/pull/154#issuecomment-120842237
  
    https://issues.apache.org/jira/browse/SOLR-7703
    
    Commit 1690553 from Anshum Gupta in branch 'dev/trunk' [ https://svn.apache.org/r1690553 ]
    Commit 1690554 from Anshum Gupta in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1690554 ]
    
    This closes #154.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org