You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/03/05 03:36:14 UTC
[GitHub] [incubator-kyuubi] yaooqinn commented on pull request #2040: [TEST] Add Zookeeper 3.4 integration test
yaooqinn commented on pull request #2040:
URL: https://github.com/apache/incubator-kyuubi/pull/2040#issuecomment-1059674939
thanks for driving this. it will be great if the compatibility is not an issue for us to upgrade zk.
Using sql pipeline to verify this looks not that good to me, I recommand we do not go this way.
the sql tests are not built and suite for this
- not that complete, we can not ensure the zk apis are all called, e.g. lock hehavior, error handling, zk acls, and those between ctl module and embedded zk. etc.
- too heavy, it take much time for test for our own ci building, and too much resources from the entire ASF github account. Althougth the resources are free for us, we'd better make reasonable use of it.
- if we add more tests to the trait, might make it even worse.
If we can build it individually to test all the apis between the kyuubi-ha(client) module and kyuubi-zookeeper(server), it will be much specific, complete and.resouece-friendly, WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org