[GitHub] [flink] 1u0 commented on a change in pull request #8602: [FLINK-12313] Add workaround to avoid race condition in SynchronousCheckpointITCase test

[GitBox <gi...@apache.org>]

1u0 commented on a change in pull request #8602: [FLINK-12313] Add workaround to avoid race condition in SynchronousCheckpointITCase test
URL: https://github.com/apache/flink/pull/8602#discussion_r293005405
 
 

 ##########
 File path: flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/SynchronousCheckpointITCase.java
 ##########
 @@ -108,6 +110,9 @@ public void initializeLatchesAndError() {
 		error.set(null);
 	}
 
+	@Rule
+	public final Timeout timeoutPerTest = Timeout.seconds(7);
 
 Review comment:
   Doesn't it depend on a test? I see a lot of tests in Flink using 10, 5, 2 seconds as timeout values, it's hard to tell that 30, 60 or 120 is a "usual" value.
   
   On my dev machine, the test runs takes about less than 2.5 second. 7 seconds is about x3 of the estimated run time. On some machines 5 seconds may be too little, but more than 10 seconds is too much for this test, imo.
   
   Do you have some other value in mind?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services