You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Joe McDonnell (Code Review)" <ge...@cloudera.org> on 2021/10/12 01:46:57 UTC
[Impala-ASF-CR] PROTOTYPE: IMPALA-10811 w async CTAS
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17916
Change subject: PROTOTYPE: IMPALA-10811 w async CTAS
......................................................................
PROTOTYPE: IMPALA-10811 w async CTAS
Change-Id: I39e0d79a250bd183d479c44a0a136955a662d500
---
M be/src/service/client-request-state.cc
M be/src/service/client-request-state.h
2 files changed, 45 insertions(+), 12 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/16/17916/1
--
To view, visit http://gerrit.cloudera.org:8080/17916
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I39e0d79a250bd183d479c44a0a136955a662d500
Gerrit-Change-Number: 17916
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
[Impala-ASF-CR] PROTOTYPE: IMPALA-10811 w async CTAS
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has abandoned this change. ( http://gerrit.cloudera.org:8080/17916 )
Change subject: PROTOTYPE: IMPALA-10811 w async CTAS
......................................................................
Abandoned
Addressed in the main review
--
To view, visit http://gerrit.cloudera.org:8080/17916
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I39e0d79a250bd183d479c44a0a136955a662d500
Gerrit-Change-Number: 17916
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] PROTOTYPE: IMPALA-10811 w async CTAS
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17916 )
Change subject: PROTOTYPE: IMPALA-10811 w async CTAS
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/17916/1/be/src/service/client-request-state.cc
File be/src/service/client-request-state.cc:
http://gerrit.cloudera.org:8080/#/c/17916/1/be/src/service/client-request-state.cc@242
PS1, Line 242: RETURN_IF_ERROR(ExecQueryOrDmlRequest(exec_request_->query_exec_request, true /* async */));
line too long (98 > 90)
--
To view, visit http://gerrit.cloudera.org:8080/17916
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I39e0d79a250bd183d479c44a0a136955a662d500
Gerrit-Change-Number: 17916
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 12 Oct 2021 01:47:50 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] PROTOTYPE: IMPALA-10811 w async CTAS
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17916 )
Change subject: PROTOTYPE: IMPALA-10811 w async CTAS
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/9590/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/17916
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I39e0d79a250bd183d479c44a0a136955a662d500
Gerrit-Change-Number: 17916
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 12 Oct 2021 02:08:38 +0000
Gerrit-HasComments: No