You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2022/03/04 19:36:53 UTC
[GitHub] [incubator-mxnet] josephevans opened a new pull request #20933: [v1.x] Update test_np_delete() to work with newer numpy versions
josephevans opened a new pull request #20933:
URL: https://github.com/apache/incubator-mxnet/pull/20933
Change test_np_delete() to stop testing negative and out-of-bounds indexes since the functionality was changed starting in numpy 1.19.0.
This fixes #20880. This was also brought up in #18600, where the unit test is disabled in master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] josephevans commented on pull request #20933: [v1.x] Update test_np_delete() to work with newer numpy versions
Posted by GitBox <gi...@apache.org>.
josephevans commented on pull request #20933:
URL: https://github.com/apache/incubator-mxnet/pull/20933#issuecomment-1059461742
@szha @barry-jin This PR only changes the test to work with newer numpy versions by not testing out-of-bounds indexes (that were previously ignored,) and not testing negative indexes. Should there be any changes on the mxnet side to also now support negative indexes instead of ignoring them?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] DickJC123 commented on pull request #20933: [v1.x] Update test_np_delete() to work with newer numpy versions
Posted by GitBox <gi...@apache.org>.
DickJC123 commented on pull request #20933:
URL: https://github.com/apache/incubator-mxnet/pull/20933#issuecomment-1059706628
Ironically, I was just starting to look into this problem! Thanks for pursuing this. Is your recent interest based on the following vulnerabilities that might prompt someone to advance to numpy >= 1.19.1?
https://nvd.nist.gov/vuln/detail/CVE-2021-41495
https://nvd.nist.gov/vuln/detail/CVE-2021-41496
If someone is going to update mxnet.numpy.delete() to be compatible with the latest numpy.delete(), another thing that changed with delete() in 1.19 is that it no longer accepts floating point indices.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] barry-jin commented on pull request #20933: [v1.x] Update test_np_delete() to work with newer numpy versions
Posted by GitBox <gi...@apache.org>.
barry-jin commented on pull request #20933:
URL: https://github.com/apache/incubator-mxnet/pull/20933#issuecomment-1059522890
> @szha @barry-jin This PR only changes the test to work with newer numpy versions by not testing out-of-bounds indexes (that were previously ignored,) and not testing negative indexes. Should there be any changes on the mxnet side to also now support negative indexes instead of ignoring them?
I think so. For out-of-bounds indexes, we may need to add a warning or directly raise an error in MXNet side. For negative indexes, I think `mxnet.np.delete` supports negative indexes, but may not compatible with numpy>=1.19.0, if that's the case, we need to upgrade `delete` operator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20933: [v1.x] Update test_np_delete() to work with newer numpy versions
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20933:
URL: https://github.com/apache/incubator-mxnet/pull/20933#issuecomment-1059458337
Hey @josephevans , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [unix-gpu, website, clang, centos-gpu, windows-gpu, edge, windows-cpu, miscellaneous, sanity, centos-cpu, unix-cpu]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] josephevans commented on pull request #20933: [v1.x] Update test_np_delete() to work with newer numpy versions
Posted by GitBox <gi...@apache.org>.
josephevans commented on pull request #20933:
URL: https://github.com/apache/incubator-mxnet/pull/20933#issuecomment-1061365172
Closing this PR as discussed, @DickJC123 is going to tackle this in another PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] josephevans closed pull request #20933: [v1.x] Update test_np_delete() to work with newer numpy versions
Posted by GitBox <gi...@apache.org>.
josephevans closed pull request #20933:
URL: https://github.com/apache/incubator-mxnet/pull/20933
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org