You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openjpa.apache.org by Donald Woods <dw...@apache.org> on 2010/06/04 19:22:52 UTC

Re: svn commit: r951496 - Switched to apache-rat-plugin

I've updated the trunk build to use the Apache version of RAT instead of
the Codehaus developed version (basically same function but this one is
maintained at Apache.)

Also, the plugin is enabled for all builds, as we've been checking in a
lot of files lately that are missing the required ASL 2.0 headers, so
this help us maintain our release readiness and hopefully find issues
before the nightly build hits them.


-Donald


On 6/4/10 1:15 PM, dwoods@apache.org wrote:
> Author: dwoods
> Date: Fri Jun  4 17:15:05 2010
> New Revision: 951496
> 
> URL: http://svn.apache.org/viewvc?rev=951496&view=rev
> Log:
> run apache-rat:check during every build
> 
> Modified:
>     openjpa/trunk/pom.xml
> 
> Modified: openjpa/trunk/pom.xml
> URL: http://svn.apache.org/viewvc/openjpa/trunk/pom.xml?rev=951496&r1=951495&r2=951496&view=diff
> ==============================================================================
> --- openjpa/trunk/pom.xml (original)
> +++ openjpa/trunk/pom.xml Fri Jun  4 17:15:05 2010
> @@ -256,62 +256,6 @@
>                              <autoVersionSubmodules>true</autoVersionSubmodules>
>                          </configuration>
>                      </plugin>
> -                        <plugin>
> -                            <groupId>org.codehaus.mojo</groupId>
> -                            <artifactId>rat-maven-plugin</artifactId>
> -                            <executions>
> -                                <execution>
> -                                    <phase>verify</phase>
> -                                    <goals>
> -                                        <goal>check</goal>
> -                                    </goals>
> -                                </execution>
> -                            </executions>
> -                            <configuration>
> -                                <excludes>
> -                                    <!--
> -                                        comments are usupported by
> -                                        javax.persistence.Persistence
> -                                    -->
> -                                    <exclude>**/javax.persistence.spi.PersistenceProvider</exclude>
> -                                    <exclude>**/javax.annotation.processing.Processor</exclude>
> -
> -                                    <!--
> -                                        comments are usupported by our rsrc parser
> -                                    -->
> -                                    <exclude>**/*.rsrc</exclude>
> -
> -                                    <!-- General informational files -->
> -                                    <exclude>openjpa-project/*.txt</exclude>
> -                                    <exclude>README.txt</exclude>
> -                                    <exclude>BUILDRELEASE</exclude>
> -                                    <exclude>scripts/*.list</exclude>
> -                                    <exclude>scripts/*.options</exclude>
> -                                    <exclude>scripts/*.dict</exclude>
> -
> -                                    <!-- generated content -->
> -                                    <exclude>**/*.log</exclude>
> -                                    <exclude>**/rat.txt</exclude>
> -                                    <exclude>**/*.txt</exclude>
> -                                    <exclude>**/org.apache.openjpa.revision.properties</exclude>
> -                                    <exclude>**/target/**/*</exclude>
> -                                    <exclude>release.properties</exclude>
> -                                    <exclude>**/NOTICE.vm</exclude>
> -                                    <exclude>**/LICENSE.vm</exclude>
> -                                    <exclude>**/dependency-reduced-pom.xml</exclude>
> -
> -                                    <!-- Exclude Eclipse generated files -->
> -                                    <exclude>**/.*/**</exclude>
> -
> -                                    <!--
> -                                        Exclude internal repository. These files
> -                                        are generated by Maven or only used for
> -                                        build purposes.
> -                                     -->
> -                                    <exclude>**/internal-repository/**</exclude>
> -                                </excludes>
> -                            </configuration>
> -                    </plugin>
>                  </plugins>
>              </build>
>          </profile>
> @@ -414,77 +358,6 @@
>              </activation>
>          </profile>
>  
> -        <profile>
> -            <!--                        
> -                Apache License check plugin. Run manually with:
> -                    mvn rat:check
> -                Or add it to the verify phase with:
> -                    mvn verify -Plicense-verify-profile
> -            -->  
> -            <id>license-verify-profile</id>
> -            <build>
> -                <plugins>
> -                    <plugin>
> -                        <groupId>org.codehaus.mojo</groupId>
> -                        <artifactId>rat-maven-plugin</artifactId>
> -                        <executions>
> -                            <execution>
> -                                <phase>verify</phase>
> -                                <goals>
> -                                    <goal>check</goal>
> -                                </goals>
> -                            </execution>
> -                        </executions>
> -                        <configuration>
> -                            <excludes>
> -                                <!--
> -                                    comments are usupported by
> -                                    javax.persistence.Persistence
> -                                -->
> -                                <exclude>**/javax.persistence.spi.PersistenceProvider</exclude>
> -                                <exclude>**/javax.annotation.processing.Processor</exclude>
> -
> -                                <!--
> -                                    comments are usupported by our rsrc parser
> -                                -->
> -                                <exclude>**/*.rsrc</exclude>
> -
> -                                <!-- General informational files -->
> -                                <exclude>openjpa-project/*.txt</exclude>
> -                                <exclude>README.txt</exclude>
> -                                <exclude>BUILDRELEASE</exclude>
> -                                <exclude>scripts/*.list</exclude>
> -                                <exclude>scripts/*.options</exclude>
> -                                <exclude>scripts/*.dict</exclude>
> -
> -
> -                                <!-- generated content -->
> -                                <exclude>**/*.log</exclude>
> -                                <exclude>**/rat.txt</exclude>
> -                                <exclude>**/*.txt</exclude>
> -                                <exclude>**/org.apache.openjpa.revision.properties</exclude>
> -                                <exclude>**/target/**/*</exclude>
> -                                <exclude>release.properties</exclude>
> -                                <exclude>**/NOTICE.vm</exclude>
> -                                <exclude>**/LICENSE.vm</exclude>
> -                                <exclude>**/dependency-reduced-pom.xml</exclude>
> -
> -                                <!-- Exclude Eclipse generated files -->
> -                                <exclude>**/.*/**</exclude>
> -
> -                                <!--
> -                                    Exclude internal repository. These files
> -                                    are generated by Maven or only used for
> -                                    build purposes.
> -                                 -->
> -                                <exclude>**/internal-repository/**</exclude>
> -                            </excludes>
> -                        </configuration>
> -                    </plugin>
> -                </plugins>
> -            </build>
> -        </profile>
> -
>          <!-- =============== -->
>          <!--  Test Profiles  -->
>          <!-- =============== -->
> @@ -844,52 +717,39 @@
>                      </configuration>
>                  </plugin>
>                  <plugin>
> -                    <groupId>org.codehaus.mojo</groupId>
> -                    <artifactId>rat-maven-plugin</artifactId>
> -                    <version>1.0-alpha-3</version>
> +                    <groupId>org.apache.rat</groupId>
> +                    <artifactId>apache-rat-plugin</artifactId>
> +                    <version>0.6</version>
> +                    <executions>
> +                        <execution>
> +                            <phase>verify</phase>
> +                            <goals>
> +                                <goal>check</goal>
> +                            </goals>
> +                        </execution>
> +                    </executions>
>                      <configuration>
>                          <excludeSubProjects>false</excludeSubProjects>
>                          <numUnapprovedLicenses>0</numUnapprovedLicenses>
>                          <excludes>
> -                            <!--
> -                                comments are usupported by
> -                                javax.persistence.Persistence
> -                            -->
> +                            <!-- comments are usupported in services files -->
>                              <exclude>**/javax.persistence.spi.PersistenceProvider</exclude>
>                              <exclude>**/javax.annotation.processing.Processor</exclude>
> -  
> -                            <!--
> -                                comments are usupported by our rsrc parser
> -                            -->
> +                            <!-- comments are usupported by our rsrc parser -->
>                              <exclude>**/*.rsrc</exclude>
> -
> -                            <!-- General informational files -->
> -                            <exclude>openjpa-project/*.txt</exclude>
> -                            <exclude>README.txt</exclude>
> -                            <exclude>BUILDRELEASE</exclude>
> +                            <!-- comments are usupported in these files -->
> +                            <exclude>**/org.apache.openjpa.revision.properties</exclude>
>                              <exclude>scripts/*.list</exclude>
>                              <exclude>scripts/*.options</exclude>
>                              <exclude>scripts/*.dict</exclude>
> -
>                              <!-- generated content -->
> -                            <exclude>**/*.log</exclude>
> -                            <exclude>**/rat.txt</exclude>
> -                            <exclude>**/*.txt</exclude>
> -                            <exclude>**/org.apache.openjpa.revision.properties</exclude>
> +                            <exclude>**/.*/**</exclude>
>                              <exclude>**/target/**/*</exclude>
> -                            <exclude>release.properties</exclude>
> -                            <exclude>**/NOTICE.vm</exclude>
> -                            <exclude>**/LICENSE.vm</exclude>
>                              <exclude>**/dependency-reduced-pom.xml</exclude>
> -
> -                            <!-- Exclude Eclipse generated files -->
> -                            <exclude>**/.*/**</exclude>
> -
> -                            <!--
> -                                Exclude internal repository. These files
> -                                are generated by Maven or only used for
> -                                build purposes.
> -                             -->
> +                            <exclude>**/*.log</exclude>
> +                            <exclude>**/maven-eclipse.xml</exclude>
> +                            <exclude>**/rat.txt</exclude>
> +                            <!-- Exclude internal build-only repository -->
>                              <exclude>**/internal-repository/**</exclude>
>                          </excludes>
>                      </configuration>
> @@ -1087,6 +947,10 @@
>                      </execution>
>                  </executions>
>              </plugin>
> +            <plugin>
> +                <groupId>org.apache.rat</groupId>
> +                <artifactId>apache-rat-plugin</artifactId>
> +            </plugin>
>              <!-- this has to be done in each module so we don't generate
>                   tests.jar artifacts that fail the IANAL check
>              <plugin>
> 
> 
>