You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2018/12/27 01:17:43 UTC
[GitHub] kaxil commented on a change in pull request #4353: [AIRFLOW-3480]
Add Database Deploy/Update/Delete operators
kaxil commented on a change in pull request #4353: [AIRFLOW-3480] Add Database Deploy/Update/Delete operators
URL: https://github.com/apache/incubator-airflow/pull/4353#discussion_r244067381
##########
File path: airflow/contrib/hooks/gcp_spanner_hook.py
##########
@@ -41,11 +42,12 @@ def __init__(self,
def get_client(self, project_id):
# type: (str) -> Client
"""
- Provides a client for interacting with Cloud Spanner API.
+ Provides a client for interacting with the Cloud Spanner API.
- :param project_id: The ID of the project which owns the instances, tables and data.
+ :param project_id: TThe ID of the GCP project that owns the Cloud Spanner
Review comment:
looks like a typo.
```suggestion
:param project_id: The ID of the GCP project that owns the Cloud Spanner
```
I haven't reviewed entire PR yet!!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services