You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/04/28 19:56:20 UTC
[GitHub] [pulsar-helm-chart] frankjkelly opened a new pull request, #262: Add support for Horizontal Pod Autoscaling for Broker and Proxy.
frankjkelly opened a new pull request, #262:
URL: https://github.com/apache/pulsar-helm-chart/pull/262
Fixes #261
### Motivation
We would like to reduce the cost of our pulsar usage by being able to autoscale the Pulsar Broker and the Pulsar Proxy
with the Pulsar Load Balancer enabled
### Modifications
Add support for Horizontal Pod Autoscaler on Broker and Proxy (turned off by default for backwards compatibility)
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-helm-chart] frankjkelly commented on pull request #262: Add support for Horizontal Pod Autoscaling for Broker and Proxy.
Posted by GitBox <gi...@apache.org>.
frankjkelly commented on PR #262:
URL: https://github.com/apache/pulsar-helm-chart/pull/262#issuecomment-1113211704
> > NOTE: As of K8S API 1.25 the HPA v2beta1 is no longer supported
> > https://kubernetes.io/docs/reference/using-api/deprecation-guide/#horizontalpodautoscaler-v125
> > It was deprecated in 1.19
> > As best as I can tell v2beta2 was introduced in K8S 1.12 https://kops.sigs.k8s.io/horizontal_pod_autoscaling/
>
> @frankjkelly, thanks for this extra context. I believe our minimum k8s version is 1.18, but I'm not sure that we have a maximum version defined. We can adjust it now, or when it becomes an issue, we can update the chart to use Helm to determine the correct `apiVersion`. There is a helpful discussion on this topic here: [#183 (comment)](https://github.com/apache/pulsar-helm-chart/pull/183#discussion_r777725211).
Thanks @michaeljmarshall - yeah keeping up with all these minimum and maximum API versions is challenging - I can't seem to find a chart that has the equivalent of the following
| API Name | API Version | Min K8S Version | Deprecated K8S Version | Removed K8S version |
| --- | --- | --- | --- | --- |
| autoscale | v1beta1 | 1.12 | 1.19 | 1.25 |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-helm-chart] addisonj merged pull request #262: Add support for Horizontal Pod Autoscaling for Broker and Proxy.
Posted by GitBox <gi...@apache.org>.
addisonj merged PR #262:
URL: https://github.com/apache/pulsar-helm-chart/pull/262
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-helm-chart] frankjkelly commented on pull request #262: Add support for Horizontal Pod Autoscaling for Broker and Proxy.
Posted by GitBox <gi...@apache.org>.
frankjkelly commented on PR #262:
URL: https://github.com/apache/pulsar-helm-chart/pull/262#issuecomment-1117150201
Hello @sijie @lhotari @eolivelli please take a look at your convenience. If no issues would love to get this merged as I am excited to test it under load :-) Thanks much in advance!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-helm-chart] michaeljmarshall commented on pull request #262: Add support for Horizontal Pod Autoscaling for Broker and Proxy.
Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on PR #262:
URL: https://github.com/apache/pulsar-helm-chart/pull/262#issuecomment-1112875906
> NOTE: As of K8S API 1.25 the HPA v2beta1 is no longer supported
> https://kubernetes.io/docs/reference/using-api/deprecation-guide/#horizontalpodautoscaler-v125
> It was deprecated in 1.19
> As best as I can tell v2beta2 was introduced in K8S 1.12 https://kops.sigs.k8s.io/horizontal_pod_autoscaling/
@frankjkelly, thanks for this extra context. I believe our minimum k8s version is 1.18, but I'm not sure that we have a maximum version defined. We can adjust it now, or when it becomes an issue, we can update the chart to use Helm to determine the correct `apiVersion`. There is a helpful discussion on this topic here: https://github.com/apache/pulsar-helm-chart/pull/183#discussion_r777725211.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org