[GitHub] [hadoop] steveloughran commented on a change in pull request #1668: HADOOP-16645. S3A Delegation Token extension point to use StoreContext.

[GitBox <gi...@apache.org>]

steveloughran commented on a change in pull request #1668: HADOOP-16645. S3A Delegation Token extension point to use StoreContext.
URL: https://github.com/apache/hadoop/pull/1668#discussion_r339754470
 
 

 ##########
 File path: hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AFileSystem.java
 ##########
 @@ -555,6 +558,26 @@ private void bindAWSClient(URI name, boolean dtEnabled) throws IOException {
         .createS3Client(getUri(), bucket, credentials, uaSuffix);
   }
 
+  /**
+   * Implementation of all operations used by delegation tokens.
+   */
+  private class DelegationOperationsImpl implements DelegationOperations {
 
 Review comment:
   
   This is the interface of all operations which the delegation token implementation needs to make of the FS. It's gone in precisely because I've just locked off all access to "the FS". Yes, we do you now have a set of inner classes to the file system, with OperationCallbacksImpl the big one. That is along with WriteOperationHelper, which was only pulled out of S3A FS itself in HADOOP-13786. But what we are moving away from is saying "here is the FS, call any method you want". As we re-fact that the code further, the implementation classes are things we should be able to move further down into my envisaged S3AStore class. (more specifically, into S3AStoreImpl). For now though: inner classes of the file system itself.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org