You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2020/05/20 07:47:44 UTC
[GitHub] [incubator-hudi] hddong opened a new pull request #1645: [HUDI-707]Add unit test for StatsCommand
hddong opened a new pull request #1645:
URL: https://github.com/apache/incubator-hudi/pull/1645
## *Tips*
- *Thank you very much for contributing to Apache Hudi.*
- *Please review https://hudi.apache.org/contributing.html before opening a pull request.*
## What is the purpose of the pull request
*Add unit test for StatsCommand*
## Brief change log
- *Add unit test for StatsCommand*
## Verify this pull request
This pull request is a trivial rework / code cleanup without any test coverage.
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hudi] codecov-commenter edited a comment on pull request #1645: [HUDI-707]Add unit test for StatsCommand
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1645:
URL: https://github.com/apache/incubator-hudi/pull/1645#issuecomment-631841340
# [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1645?src=pr&el=h1) Report
> Merging [#1645](https://codecov.io/gh/apache/incubator-hudi/pull/1645?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-hudi/commit/6a0aa9a645d11ed7b50e18aa0563dafcd9d145f7&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-hudi/pull/1645?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1645 +/- ##
=========================================
Coverage 18.33% 18.33%
Complexity 855 855
=========================================
Files 344 344
Lines 15167 15167
Branches 1512 1512
=========================================
Hits 2781 2781
Misses 12033 12033
Partials 353 353
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1645?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1645?src=pr&el=footer). Last update [6a0aa9a...a7d26cb](https://codecov.io/gh/apache/incubator-hudi/pull/1645?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hudi] yanghua commented on a change in pull request #1645: [HUDI-707]Add unit test for StatsCommand
Posted by GitBox <gi...@apache.org>.
yanghua commented on a change in pull request #1645:
URL: https://github.com/apache/incubator-hudi/pull/1645#discussion_r428490566
##########
File path: hudi-cli/src/test/java/org/apache/hudi/cli/commands/TestStatsCommand.java
##########
@@ -0,0 +1,176 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hudi.cli.commands;
+
+import com.codahale.metrics.Histogram;
+import com.codahale.metrics.Snapshot;
+import com.codahale.metrics.UniformReservoir;
+import org.apache.hudi.cli.AbstractShellIntegrationTest;
+import org.apache.hudi.cli.HoodieCLI;
+import org.apache.hudi.cli.HoodiePrintHelper;
+import org.apache.hudi.cli.HoodieTableHeaderFields;
+import org.apache.hudi.cli.TableHeader;
+import org.apache.hudi.cli.common.HoodieTestCommitMetadataGenerator;
+import org.apache.hudi.common.HoodieTestDataGenerator;
+import org.apache.hudi.common.model.HoodieTableType;
+import org.apache.hudi.common.model.HoodieTestUtils;
+import org.apache.hudi.common.table.timeline.versioning.TimelineLayoutVersion;
+import org.apache.hudi.common.util.Option;
+
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
+import org.springframework.shell.core.CommandResult;
+
+import java.io.File;
+import java.io.IOException;
+import java.text.DecimalFormat;
+import java.util.ArrayList;
+import java.util.HashMap;
+import java.util.LinkedHashMap;
+import java.util.List;
+import java.util.Map;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertTrue;
+
+/**
+ * Test class of {@link org.apache.hudi.cli.commands.StatsCommand}.
+ */
+public class TestStatsCommand extends AbstractShellIntegrationTest {
+
+ private String tablePath;
+
+ @BeforeEach
+ public void init() throws IOException {
+ String tableName = "test_table";
+ tablePath = basePath + File.separator + tableName;
+
+ HoodieCLI.conf = jsc.hadoopConfiguration();
+ // Create table and connect
+ new TableCommand().createTable(
+ tablePath, "test_table", HoodieTableType.COPY_ON_WRITE.name(),
+ "", TimelineLayoutVersion.VERSION_1, "org.apache.hudi.common.model.HoodieAvroPayload");
+ }
+
+ /**
+ * Test case for command 'stats wa'.
+ */
+ @Test
+ public void testWriteAmplificationStats() {
+ // generate data and metadata
+ Map<String, Integer[]> data = new LinkedHashMap();
Review comment:
-> `Map<String, Integer[]> data = new LinkedHashMap<>();`
##########
File path: hudi-cli/src/test/java/org/apache/hudi/cli/commands/TestStatsCommand.java
##########
@@ -0,0 +1,176 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hudi.cli.commands;
+
+import com.codahale.metrics.Histogram;
+import com.codahale.metrics.Snapshot;
+import com.codahale.metrics.UniformReservoir;
+import org.apache.hudi.cli.AbstractShellIntegrationTest;
+import org.apache.hudi.cli.HoodieCLI;
+import org.apache.hudi.cli.HoodiePrintHelper;
+import org.apache.hudi.cli.HoodieTableHeaderFields;
+import org.apache.hudi.cli.TableHeader;
+import org.apache.hudi.cli.common.HoodieTestCommitMetadataGenerator;
+import org.apache.hudi.common.HoodieTestDataGenerator;
+import org.apache.hudi.common.model.HoodieTableType;
+import org.apache.hudi.common.model.HoodieTestUtils;
+import org.apache.hudi.common.table.timeline.versioning.TimelineLayoutVersion;
+import org.apache.hudi.common.util.Option;
+
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
+import org.springframework.shell.core.CommandResult;
+
+import java.io.File;
+import java.io.IOException;
+import java.text.DecimalFormat;
+import java.util.ArrayList;
+import java.util.HashMap;
+import java.util.LinkedHashMap;
+import java.util.List;
+import java.util.Map;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertTrue;
+
+/**
+ * Test class of {@link org.apache.hudi.cli.commands.StatsCommand}.
+ */
+public class TestStatsCommand extends AbstractShellIntegrationTest {
+
+ private String tablePath;
+
+ @BeforeEach
+ public void init() throws IOException {
+ String tableName = "test_table";
+ tablePath = basePath + File.separator + tableName;
+
+ HoodieCLI.conf = jsc.hadoopConfiguration();
+ // Create table and connect
+ new TableCommand().createTable(
+ tablePath, "test_table", HoodieTableType.COPY_ON_WRITE.name(),
+ "", TimelineLayoutVersion.VERSION_1, "org.apache.hudi.common.model.HoodieAvroPayload");
+ }
+
+ /**
+ * Test case for command 'stats wa'.
+ */
+ @Test
+ public void testWriteAmplificationStats() {
+ // generate data and metadata
+ Map<String, Integer[]> data = new LinkedHashMap();
+ data.put("100", new Integer[] {15, 10});
+ data.put("101", new Integer[] {20, 10});
+ data.put("102", new Integer[] {15, 15});
+
+ data.forEach((key, value) -> {
+ HoodieTestCommitMetadataGenerator.createCommitFileWithMetadata(tablePath, key, jsc.hadoopConfiguration(),
+ Option.of(value[0]), Option.of(value[1]));
+ });
+
+ CommandResult cr = getShell().executeCommand("stats wa");
+ assertTrue(cr.isSuccess());
+
+ // generate expect
+ List<Comparable[]> rows = new ArrayList<>();
+ DecimalFormat df = new DecimalFormat("#.00");
+ data.forEach((key, value) -> {
+ // there are two partitions, so need to *2
+ rows.add(new Comparable[]{key, value[1] * 2, value[0] * 2, df.format((float) value[0] / value[1])});
+ });
+ int totalWrite = data.values().stream().map(integers -> integers[0] * 2).mapToInt(s -> s).sum();
+ int totalUpdate = data.values().stream().map(integers -> integers[1] * 2).mapToInt(s -> s).sum();
+ rows.add(new Comparable[]{"Total", totalUpdate, totalWrite, df.format((float) totalWrite / totalUpdate)});
+
+ TableHeader header = new TableHeader().addTableHeaderField(HoodieTableHeaderFields.HEADER_COMMIT_TIME)
+ .addTableHeaderField(HoodieTableHeaderFields.HEADER_TOTAL_UPSERTED)
+ .addTableHeaderField(HoodieTableHeaderFields.HEADER_TOTAL_WRITTEN)
+ .addTableHeaderField(HoodieTableHeaderFields.HEADER_WRITE_AMPLIFICATION_FACTOR);
+ String expected = HoodiePrintHelper.print(header, new HashMap<>(), "", false, -1, false, rows);
+
+ assertEquals(expected, cr.getResult().toString());
+ }
+
+ /**
+ * Test case for command 'stats filesizes'.
+ */
+ @Test
+ public void testFileSizeStats() throws IOException {
+ String commit1 = "100";
+ String commit2 = "101";
+ Map<String, Integer[]> data = new LinkedHashMap();
Review comment:
ditto
##########
File path: hudi-cli/src/test/java/org/apache/hudi/cli/commands/TestRepairsCommand.java
##########
@@ -64,8 +64,9 @@ public void init() throws IOException {
tablePath = basePath + File.separator + tableName;
// Create table and connect
+ System.out.println(tablePath);
Review comment:
Can we remove stdout print?
##########
File path: hudi-cli/src/main/java/org/apache/hudi/cli/commands/StatsCommand.java
##########
@@ -138,6 +141,20 @@ public String fileSizeStats(
Snapshot s = globalHistogram.getSnapshot();
rows.add(printFileSizeHistogram("ALL", s));
+ TableHeader header = new TableHeader()
+ .addTableHeaderField(HoodieTableHeaderFields.HEADER_COMMIT_TIME)
+ .addTableHeaderField(HoodieTableHeaderFields.HEADER_HISTOGRAM_MIN)
+ .addTableHeaderField(HoodieTableHeaderFields.HEADER_HISTOGRAM_10TH)
+ .addTableHeaderField(HoodieTableHeaderFields.HEADER_HISTOGRAM_50TH)
+ .addTableHeaderField(HoodieTableHeaderFields.HEADER_HISTOGRAM_AVG)
+ .addTableHeaderField(HoodieTableHeaderFields.HEADER_HISTOGRAM_95TH)
+ .addTableHeaderField(HoodieTableHeaderFields.HEADER_HISTOGRAM_MAX)
+ .addTableHeaderField(HoodieTableHeaderFields.HEADER_HISTOGRAM_NUM_FILES)
+ .addTableHeaderField(HoodieTableHeaderFields.HEADER_HISTOGRAM_STD_DEV);
+ return HoodiePrintHelper.print(header, getFieldNameToConverterMap(), sortByField, descending, limit, headerOnly, rows);
+ }
+
+ public Map getFieldNameToConverterMap() {
Review comment:
Can we return a generic type `Map<String, Function<Object, String>>`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hudi] bvaradar commented on pull request #1645: [HUDI-707]Add unit test for StatsCommand
Posted by GitBox <gi...@apache.org>.
bvaradar commented on pull request #1645:
URL: https://github.com/apache/incubator-hudi/pull/1645#issuecomment-631624593
@yanghua @leesf : Would you be interested in shepherding this PR when it is ready ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hudi] codecov-commenter edited a comment on pull request #1645: [HUDI-707]Add unit test for StatsCommand
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1645:
URL: https://github.com/apache/incubator-hudi/pull/1645#issuecomment-631841340
# [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1645?src=pr&el=h1) Report
> Merging [#1645](https://codecov.io/gh/apache/incubator-hudi/pull/1645?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-hudi/commit/74ecc27e920c70fa4598d8e5a696954203a5b127&el=desc) will **decrease** coverage by `0.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-hudi/pull/1645?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1645 +/- ##
============================================
- Coverage 18.34% 18.33% -0.02%
- Complexity 854 855 +1
============================================
Files 344 344
Lines 15172 15167 -5
Branches 1512 1512
============================================
- Hits 2784 2781 -3
+ Misses 12035 12033 -2
Partials 353 353
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-hudi/pull/1645?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ain/java/org/apache/hudi/avro/HoodieAvroUtils.java](https://codecov.io/gh/apache/incubator-hudi/pull/1645/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvYXZyby9Ib29kaWVBdnJvVXRpbHMuamF2YQ==) | `48.09% <0.00%> (-1.91%)` | `22.00% <0.00%> (ø%)` | |
| [...apache/hudi/common/fs/HoodieWrapperFileSystem.java](https://codecov.io/gh/apache/incubator-hudi/pull/1645/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0hvb2RpZVdyYXBwZXJGaWxlU3lzdGVtLmphdmE=) | `22.69% <0.00%> (+0.70%)` | `29.00% <0.00%> (+1.00%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1645?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1645?src=pr&el=footer). Last update [74ecc27...6a43c92](https://codecov.io/gh/apache/incubator-hudi/pull/1645?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hudi] codecov-commenter edited a comment on pull request #1645: [HUDI-707]Add unit test for StatsCommand
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1645:
URL: https://github.com/apache/incubator-hudi/pull/1645#issuecomment-631841340
# [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1645?src=pr&el=h1) Report
> Merging [#1645](https://codecov.io/gh/apache/incubator-hudi/pull/1645?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-hudi/commit/6a0aa9a645d11ed7b50e18aa0563dafcd9d145f7&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-hudi/pull/1645?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1645 +/- ##
=========================================
Coverage 18.33% 18.33%
Complexity 855 855
=========================================
Files 344 344
Lines 15167 15167
Branches 1512 1512
=========================================
Hits 2781 2781
Misses 12033 12033
Partials 353 353
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1645?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1645?src=pr&el=footer). Last update [6a0aa9a...5abfd69](https://codecov.io/gh/apache/incubator-hudi/pull/1645?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hudi] hddong commented on pull request #1645: [HUDI-707]Add unit test for StatsCommand
Posted by GitBox <gi...@apache.org>.
hddong commented on pull request #1645:
URL: https://github.com/apache/incubator-hudi/pull/1645#issuecomment-631917437
@yanghua : it's ready now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hudi] codecov-commenter commented on pull request #1645: [HUDI-707]Add unit test for StatsCommand
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1645:
URL: https://github.com/apache/incubator-hudi/pull/1645#issuecomment-631841340
# [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1645?src=pr&el=h1) Report
> Merging [#1645](https://codecov.io/gh/apache/incubator-hudi/pull/1645?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-hudi/commit/74ecc27e920c70fa4598d8e5a696954203a5b127&el=desc) will **decrease** coverage by `0.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-hudi/pull/1645?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1645 +/- ##
============================================
- Coverage 18.34% 18.33% -0.02%
- Complexity 854 855 +1
============================================
Files 344 344
Lines 15172 15167 -5
Branches 1512 1512
============================================
- Hits 2784 2781 -3
+ Misses 12035 12033 -2
Partials 353 353
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-hudi/pull/1645?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ain/java/org/apache/hudi/avro/HoodieAvroUtils.java](https://codecov.io/gh/apache/incubator-hudi/pull/1645/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvYXZyby9Ib29kaWVBdnJvVXRpbHMuamF2YQ==) | `48.09% <0.00%> (-1.91%)` | `22.00% <0.00%> (ø%)` | |
| [...apache/hudi/common/fs/HoodieWrapperFileSystem.java](https://codecov.io/gh/apache/incubator-hudi/pull/1645/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0hvb2RpZVdyYXBwZXJGaWxlU3lzdGVtLmphdmE=) | `22.69% <0.00%> (+0.70%)` | `29.00% <0.00%> (+1.00%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1645?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1645?src=pr&el=footer). Last update [74ecc27...6a43c92](https://codecov.io/gh/apache/incubator-hudi/pull/1645?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hudi] yanghua merged pull request #1645: [HUDI-707]Add unit test for StatsCommand
Posted by GitBox <gi...@apache.org>.
yanghua merged pull request #1645:
URL: https://github.com/apache/incubator-hudi/pull/1645
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hudi] yanghua commented on pull request #1645: [HUDI-707]Add unit test for StatsCommand
Posted by GitBox <gi...@apache.org>.
yanghua commented on pull request #1645:
URL: https://github.com/apache/incubator-hudi/pull/1645#issuecomment-631836600
> you be interested in shepherding this PR when it is
Yes, of course.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hudi] codecov-commenter edited a comment on pull request #1645: [HUDI-707]Add unit test for StatsCommand
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1645:
URL: https://github.com/apache/incubator-hudi/pull/1645#issuecomment-631841340
# [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1645?src=pr&el=h1) Report
> Merging [#1645](https://codecov.io/gh/apache/incubator-hudi/pull/1645?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-hudi/commit/74ecc27e920c70fa4598d8e5a696954203a5b127&el=desc) will **decrease** coverage by `0.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-hudi/pull/1645?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1645 +/- ##
============================================
- Coverage 18.34% 18.33% -0.02%
- Complexity 854 855 +1
============================================
Files 344 344
Lines 15172 15167 -5
Branches 1512 1512
============================================
- Hits 2784 2781 -3
+ Misses 12035 12033 -2
Partials 353 353
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-hudi/pull/1645?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ain/java/org/apache/hudi/avro/HoodieAvroUtils.java](https://codecov.io/gh/apache/incubator-hudi/pull/1645/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvYXZyby9Ib29kaWVBdnJvVXRpbHMuamF2YQ==) | `48.09% <0.00%> (-1.91%)` | `22.00% <0.00%> (ø%)` | |
| [...apache/hudi/common/fs/HoodieWrapperFileSystem.java](https://codecov.io/gh/apache/incubator-hudi/pull/1645/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0hvb2RpZVdyYXBwZXJGaWxlU3lzdGVtLmphdmE=) | `22.69% <0.00%> (+0.70%)` | `29.00% <0.00%> (+1.00%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1645?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1645?src=pr&el=footer). Last update [74ecc27...138f2f8](https://codecov.io/gh/apache/incubator-hudi/pull/1645?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hudi] hddong commented on pull request #1645: [HUDI-707]Add unit test for StatsCommand
Posted by GitBox <gi...@apache.org>.
hddong commented on pull request #1645:
URL: https://github.com/apache/incubator-hudi/pull/1645#issuecomment-631977694
@yanghua Thanks for your review, had address them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hudi] codecov-commenter edited a comment on pull request #1645: [HUDI-707]Add unit test for StatsCommand
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1645:
URL: https://github.com/apache/incubator-hudi/pull/1645#issuecomment-631841340
# [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1645?src=pr&el=h1) Report
> Merging [#1645](https://codecov.io/gh/apache/incubator-hudi/pull/1645?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-hudi/commit/6a0aa9a645d11ed7b50e18aa0563dafcd9d145f7&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-hudi/pull/1645?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1645 +/- ##
=========================================
Coverage 18.33% 18.33%
Complexity 855 855
=========================================
Files 344 344
Lines 15167 15167
Branches 1512 1512
=========================================
Hits 2781 2781
Misses 12033 12033
Partials 353 353
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1645?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1645?src=pr&el=footer). Last update [6a0aa9a...5abfd69](https://codecov.io/gh/apache/incubator-hudi/pull/1645?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org