[GitHub] [nifi] ChrisSamo632 commented on a diff in pull request #6701: NIFI-10845 - JsonQueryElasticsearch processors are not outputting an …

[GitBox <gi...@apache.org>]

ChrisSamo632 commented on code in PR #6701:
URL: https://github.com/apache/nifi/pull/6701#discussion_r1029383884


##########
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-restapi-processors/src/main/java/org/apache/nifi/processors/elasticsearch/AbstractJsonQueryElasticsearch.java:
##########
@@ -277,8 +281,8 @@ private void handleAggregations(final Map<String, Object> aggregations, final Pr
         }
     }
 
-    private FlowFile writeHitFlowFile(final int count, final String json, final ProcessSession session,
-                                      final FlowFile hitFlowFile, final Map<String, String> attributes) {
+    public FlowFile writeHitFlowFile(final int count, final String json, final ProcessSession session,

Review Comment:
   Doesn't need to be `public`, package-private should be enough (i.e. remove the access modifier)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org