[GitHub] [daffodil] mbeckerle commented on a diff in pull request #829: All InfosetOutputter functions now return Unit

[GitBox <gi...@apache.org>]

mbeckerle commented on code in PR #829:
URL: https://github.com/apache/daffodil/pull/829#discussion_r948551751


##########
daffodil-japi/src/main/scala/org/apache/daffodil/japi/infoset/Infoset.scala:
##########
@@ -123,85 +123,85 @@ abstract class InfosetOutputter extends SInfosetOutputter {
   /**
    * Called by Daffodil internals to signify the beginning of the infoset.
    *
-   * @return true on sucess, false if there was an error and Daffodil should stop all
-   *         future calls to the InfosetOutputter
+   * @throws Exception if there was an error and Daffodil should stop parsing
    */
-  def startDocument(): Boolean
+  @throws[Exception]

Review Comment:
   Very broad throw class. You are basically telling people "don't catch this". 
   
   Why not InfosetInputterException or InfosetOutputterException which encapsulate any mystery throw. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org