You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by yanghua <gi...@git.apache.org> on 2018/05/13 08:29:33 UTC
[GitHub] flink pull request #6001: [FLINK-9299] ProcessWindowFunction documentation J...
GitHub user yanghua opened a pull request:
https://github.com/apache/flink/pull/6001
[FLINK-9299] ProcessWindowFunction documentation Java examples have errors
## What is the purpose of the change
*This pull request fixed some document demo code error.*
## Brief change log
- *This pull request fixed some document demo code error.*
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / **not documented**)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/yanghua/flink FLINK-9299
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/6001.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #6001
----
commit cb0764151647b58fc2b46b8fe76c451ed076b830
Author: yanghua <ya...@...>
Date: 2018-05-13T08:27:11Z
[FLINK-9299] ProcessWindowFunction documentation Java examples have errors
----
---
[GitHub] flink pull request #6001: [FLINK-9299] ProcessWindowFunction documentation J...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/6001
---
[GitHub] flink issue #6001: [FLINK-9299] ProcessWindowFunction documentation Java exa...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/6001
Thanks for the fix @yanghua. I left a minor comment.
Otherwise +1 to merge.
---
[GitHub] flink issue #6001: [FLINK-9299] ProcessWindowFunction documentation Java exa...
Posted by yanghua <gi...@git.apache.org>.
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6001
cc @tzulitai @fhueske
---
[GitHub] flink issue #6001: [FLINK-9299] ProcessWindowFunction documentation Java exa...
Posted by sihuazhou <gi...@git.apache.org>.
Github user sihuazhou commented on the issue:
https://github.com/apache/flink/pull/6001
hi @medcv I think maybe it better to assign the issue to yourself before working on that, this could help to avoid depulicate works(cause i notice that you make the PRs without assigning to yourself), you can request the contribution permisson from the dev mail, i think PMCs will accpet your request once they saw your request, it always very quickly. With the permisson, you can assign the issue as you wish then.
Best~
---
[GitHub] flink issue #6001: [FLINK-9299] ProcessWindowFunction documentation Java exa...
Posted by medcv <gi...@git.apache.org>.
Github user medcv commented on the issue:
https://github.com/apache/flink/pull/6001
@yanghua Thanks for the fix. I will close my PR as you addressed all the issues in the ticket here.
---
[GitHub] flink pull request #6001: [FLINK-9299] ProcessWindowFunction documentation J...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/6001#discussion_r187871263
--- Diff: docs/dev/stream/operators/windows.md ---
@@ -883,7 +883,7 @@ private static class AverageAggregate
@Override
public Double getResult(Tuple2<Long, Long> accumulator) {
- return accumulator.f0 / accumulator.f1;
+ return (double) accumulator.f0 / accumulator.f1;
--- End diff --
Should probably be `((double) accumulator.f0) / accumulator.f1;`
---
[GitHub] flink issue #6001: [FLINK-9299] ProcessWindowFunction documentation Java exa...
Posted by yanghua <gi...@git.apache.org>.
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6001
@StephanEwen does this has any problem need to change? it seems @medcv try to fixed this issue before asking me.
---
[GitHub] flink issue #6001: [FLINK-9299] ProcessWindowFunction documentation Java exa...
Posted by yanghua <gi...@git.apache.org>.
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6001
@StephanEwen fixed based on your suggestion
---
[GitHub] flink issue #6001: [FLINK-9299] ProcessWindowFunction documentation Java exa...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/6001
Looks good, thanks, merging this...
---
[GitHub] flink pull request #6001: [FLINK-9299] ProcessWindowFunction documentation J...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/6001#discussion_r188529928
--- Diff: docs/dev/stream/operators/windows.md ---
@@ -797,7 +797,7 @@ DataStream<SensorReading> input = ...;
input
.keyBy(<key selector>)
- .timeWindow(<window assigner>)
+ .timeWindow(<time size>)
--- End diff --
How about using "duration" instead of "time size". I think "time size" is not a commonly used term...
---
[GitHub] flink pull request #6001: [FLINK-9299] ProcessWindowFunction documentation J...
Posted by yanghua <gi...@git.apache.org>.
Github user yanghua commented on a diff in the pull request:
https://github.com/apache/flink/pull/6001#discussion_r188530473
--- Diff: docs/dev/stream/operators/windows.md ---
@@ -797,7 +797,7 @@ DataStream<SensorReading> input = ...;
input
.keyBy(<key selector>)
- .timeWindow(<window assigner>)
+ .timeWindow(<time size>)
--- End diff --
accept, hold on...
---
[GitHub] flink issue #6001: [FLINK-9299] ProcessWindowFunction documentation Java exa...
Posted by yanghua <gi...@git.apache.org>.
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6001
cc @fhueske changed and fixed a remained error before
---
[GitHub] flink issue #6001: [FLINK-9299] ProcessWindowFunction documentation Java exa...
Posted by yanghua <gi...@git.apache.org>.
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6001
cc @zentol @tillrohrmann
---