[GitHub] [nifi] pvillard31 commented on a diff in pull request #7460: NIFI-11779 - Override endpoint in PutBigQuery

["pvillard31 (via GitHub)" <gi...@apache.org>]

pvillard31 commented on code in PR #7460:
URL: https://github.com/apache/nifi/pull/7460#discussion_r1254268053


##########
nifi-nar-bundles/nifi-gcp-bundle/nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/bigquery/PutBigQuery.java:
##########
@@ -124,6 +127,15 @@ public class PutBigQuery extends AbstractBigQueryProcessor {
         .required(true)
         .build();
 
+    public static final PropertyDescriptor BIGQUERY_API_URL = new PropertyDescriptor.Builder()
+        .name("bigquery-api-url")
+        .displayName("BigQuery API URL")
+        .description("Overrides the default BigQuery URL.")

Review Comment:
   I followed the same approach as in #7255 and #7172 to be consistent but I can definitely provide the default endpoint (at least in the description of the property).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org