You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/01/20 20:14:28 UTC

[GitHub] diederikwp edited a comment on issue #4339: [AIRFLOW-3303] Deprecate old UI in favor of FAB

diederikwp edited a comment on issue #4339: [AIRFLOW-3303] Deprecate old UI in favor of FAB
URL: https://github.com/apache/airflow/pull/4339#issuecomment-455897948
 
 
   I have a problem where the webserver keeps repeating "some workers are starting up, waiting...", and I think it might be because of these changes.
   
   It seems that the worker processes no longer get the proper prefix after initialization, because the file gunicorn_config.py was deleted. Before deletion, it contained the post_worker_init function: https://github.com/apache/airflow/blob/cb8b2a1dc64c3ea6ba445893c65c6c953dfb476a/airflow/www/gunicorn_config.py#L25-L28
   and it was part of run_args in def webserver in cly.py:
   https://github.com/apache/airflow/blob/cb8b2a1dc64c3ea6ba445893c65c6c953dfb476a/airflow/bin/cli.py#L874-L883
   
   After your changes, get_num_ready_workers still expects the prefix: https://github.com/apache/airflow/blob/c030729dcbe35a2a4869e46b57a761c8376ede8d/airflow/bin/cli.py#L691-L704
   
   @verdan Could you please confirm/refute

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services