You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "Greg Miller (Jira)" <ji...@apache.org> on 2021/04/29 16:20:00 UTC
[jira] [Commented] (LUCENE-9944) Implement alternative drill
sideways faceting with provided CollectorManager
[ https://issues.apache.org/jira/browse/LUCENE-9944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17335643#comment-17335643 ]
Greg Miller commented on LUCENE-9944:
-------------------------------------
Here is a draft version of this change. It's rough (mostly a copy/paste job) but illustrates the desired functionality. If folks think this is a good idea, I'll clean up the change, add some testing and put together a proper PR.
https://github.com/apache/lucene/compare/main...gsmiller:LUCENE-9944/draft
> Implement alternative drill sideways faceting with provided CollectorManager
> ----------------------------------------------------------------------------
>
> Key: LUCENE-9944
> URL: https://issues.apache.org/jira/browse/LUCENE-9944
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/facet
> Affects Versions: main (9.0)
> Reporter: Greg Miller
> Priority: Minor
>
> Today, if a user of {{DrillSideways}} wants to provide their own {{CollectorManager}} when invoking {{search}}, they get this alternate, "concurrent" implementation that creates N copies of the provided {{DrillDownQuery}} (where N is the number of drill-down dimensions) and runs them all concurrently. This is a very different implementation than the one a user would get if providing a {{Collector}} instead. Additionally, an {{ExecutorService}} must be provided when constructing a {{DrillSideways}} instance if the user wants to bring their own {{CollectorManager}} (otherwise, they'll get an unfriendly NPE when calling {{search}}).
> I propose adding an implementation to {{DrillSideways}} that will run the "non-concurrent" algorithm in the case that a user wants to provide their own {{CollectorManager}} but doesn't want to provide an {{ExecutorService}} (and doesn't want the concurrent algorithm).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org