[jira] [Commented] (ZOOKEEPER-2218) Close IO Streams in finally block

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15472573#comment-15472573 ] 

Hadoop QA commented on ZOOKEEPER-2218:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12742761/ZOOKEEPER-2218.patch
  against trunk revision 1759735.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    -1 patch.  The patch command could not apply the patch.

Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3399//console

This message is automatically generated.

> Close IO Streams in finally block
> ---------------------------------
>
>                 Key: ZOOKEEPER-2218
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2218
>             Project: ZooKeeper
>          Issue Type: Bug
>            Reporter: Tang Xinye
>            Assignee: Tang Xinye
>            Priority: Critical
>             Fix For: 3.5.3, 3.6.0
>
>         Attachments: ZOOKEEPER-2218.patch, ZOOKEEPER-2218.patch
>
>
> The problem here is that if an exception is thrown during the read process the method will exit without closing the stream and hence without releasing the file system resources, it may run out of resources before it does run.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)