You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2019/06/11 14:48:44 UTC
[GitHub] [servicecomb-service-center] codecov-io commented on issue #556:
[SCB-1301] Abstract control flow from serf/etcd/grpc
codecov-io commented on issue #556: [SCB-1301] Abstract control flow from serf/etcd/grpc
URL: https://github.com/apache/servicecomb-service-center/pull/556#issuecomment-500876309
# [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/556?src=pr&el=h1) Report
> Merging [#556](https://codecov.io/gh/apache/servicecomb-service-center/pull/556?src=pr&el=desc) into [master](https://codecov.io/gh/apache/servicecomb-service-center/commit/d7414f00cc31ec2048b1735658f45e07e6c73cda?src=pr&el=desc) will **decrease** coverage by `0.22%`.
> The diff coverage is `33.33%`.
[](https://codecov.io/gh/apache/servicecomb-service-center/pull/556?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #556 +/- ##
==========================================
- Coverage 58.55% 58.33% -0.23%
==========================================
Files 201 201
Lines 15257 15315 +58
==========================================
Hits 8934 8934
- Misses 5701 5758 +57
- Partials 622 623 +1
```
| [Impacted Files](https://codecov.io/gh/apache/servicecomb-service-center/pull/556?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [syncer/servicecenter/servicecenter.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/556/diff?src=pr&el=tree#diff-c3luY2VyL3NlcnZpY2VjZW50ZXIvc2VydmljZWNlbnRlci5nbw==) | `95% <100%> (+0.12%)` | :arrow_up: |
| [syncer/serf/agent.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/556/diff?src=pr&el=tree#diff-c3luY2VyL3NlcmYvYWdlbnQuZ28=) | `39.79% <26.47%> (-38.47%)` | :arrow_down: |
| [syncer/serf/config.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/556/diff?src=pr&el=tree#diff-c3luY2VyL3NlcmYvY29uZmlnLmdv) | `53.33% <40%> (-4.36%)` | :arrow_down: |
| [syncer/config/config.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/556/diff?src=pr&el=tree#diff-c3luY2VyL2NvbmZpZy9jb25maWcuZ28=) | `85.18% <80%> (-3.28%)` | :arrow_down: |
| [server/notify/listwatcher.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/556/diff?src=pr&el=tree#diff-c2VydmVyL25vdGlmeS9saXN0d2F0Y2hlci5nbw==) | `69.44% <0%> (-9.73%)` | :arrow_down: |
| [syncer/pkg/syssig/signal.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/556/diff?src=pr&el=tree#diff-c3luY2VyL3BrZy9zeXNzaWcvc2lnbmFsLmdv) | `64.51% <0%> (-3.23%)` | :arrow_down: |
| [pkg/util/tree.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/556/diff?src=pr&el=tree#diff-cGtnL3V0aWwvdHJlZS5nbw==) | `81.25% <0%> (-3.13%)` | :arrow_down: |
| [server/service/tag.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/556/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdGFnLmdv) | `67.95% <0%> (+0.55%)` | :arrow_up: |
| [server/notify/websocket.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/556/diff?src=pr&el=tree#diff-c2VydmVyL25vdGlmeS93ZWJzb2NrZXQuZ28=) | `81.14% <0%> (+0.57%)` | :arrow_up: |
| [scctl/pkg/plugin/diagnose/compare\_holder.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/556/diff?src=pr&el=tree#diff-c2NjdGwvcGtnL3BsdWdpbi9kaWFnbm9zZS9jb21wYXJlX2hvbGRlci5nbw==) | `96.15% <0%> (+1.28%)` | :arrow_up: |
| ... and [1 more](https://codecov.io/gh/apache/servicecomb-service-center/pull/556/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/556?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/556?src=pr&el=footer). Last update [d7414f0...f270ca4](https://codecov.io/gh/apache/servicecomb-service-center/pull/556?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services