You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by johnmccabe <gi...@git.apache.org> on 2016/05/24 18:11:20 UTC

[GitHub] brooklyn-client pull request: fix BROOKLYN-280, add --skipSslCheck...

GitHub user johnmccabe opened a pull request:

    https://github.com/apache/brooklyn-client/pull/21

    fix BROOKLYN-280, add --skipSslChecks flag to work with self-signed certs

    - defaults to false, ie existing behaviour
    - setting to true disables certificate chain and hostname verificiation (see `InsecureSkipVerify` in https://golang.org/pkg/crypto/tls/)
    - persisted to ~/.brooklyn_cli
    - also bumped version to `0.10.0-SNAPSHOT`
    
    ```
    bash-4.3$ br login https://10.10.10.100:8443/ admin password
    Get https://10.10.10.100:8443/v1/server/version: x509: certificate signed by unknown authority
    bash-4.3$ br app
    Get https://10.10.10.100:8443/v1/applications: x509: certificate signed by unknown authority
    
    bash-4.3$ br --skipSslChecks login https://10.10.10.100:8443/ admin password
    Connected to Brooklyn version 0.10.0-20160513.2042 at https://10.10.10.100:8443
    bash-4.3$ br app
    Id   Name   Status   Location
    ```
    *Note*: I'd no apps running on this system so the empty table is ok, catalog returns as expected.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/johnmccabe/brooklyn-client fix_BROOKLYN-280

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/brooklyn-client/pull/21.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #21
    
----
commit 7dc9b3f009d1b7dc7197622f81a84fcd191c731f
Author: John McCabe <jo...@johnmccabe.net>
Date:   2016-05-24T18:09:06Z

    fix BROOKLYN-280, add --skipSslChecks flag
    - defaults to false, ie existing behaviour
    - setting to true disables certificate chain and hostname verificiation (see `InsecureSkipVerify` in https://golang.org/pkg/crypto/tls/)
    - persisted to ~/.brooklyn_cli
    
    ```
    bash-4.3$ br login https://10.10.10.100:8443/ admin password
    Get https://10.10.10.100:8443/v1/server/version: x509: certificate signed by unknown authority
    bash-4.3$ br app
    Get https://10.10.10.100:8443/v1/applications: x509: certificate signed by unknown authority
    
    bash-4.3$ br --skipSslChecks login https://10.10.10.100:8443/ admin password
    Connected to Brooklyn version 0.10.0-20160513.2042 at https://10.10.10.100:8443
    bash-4.3$ br app
    Id   Name   Status   Location
    
    ```

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-client pull request: [BROOKLYN-280] add --skipSslChecks f...

Posted by geomacy <gi...@git.apache.org>.
Github user geomacy commented on the pull request:

    https://github.com/apache/brooklyn-client/pull/21#issuecomment-222114100
  
    I don't think this necessarily needs to change to match the "-k / --insecure" of curl, the current flag has a nicely meaningful name.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-client pull request: [BROOKLYN-280] add --skipSslChecks f...

Posted by johnmccabe <gi...@git.apache.org>.
Github user johnmccabe commented on the pull request:

    https://github.com/apache/brooklyn-client/pull/21#issuecomment-221358277
  
    fyi @geomacy @robertgmoss 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-client pull request: [BROOKLYN-280] add --skipSslChecks f...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/brooklyn-client/pull/21


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-client pull request: [BROOKLYN-280] add --skipSslChecks f...

Posted by johnmccabe <gi...@git.apache.org>.
Github user johnmccabe commented on a diff in the pull request:

    https://github.com/apache/brooklyn-client/pull/21#discussion_r64523219
  
    --- Diff: app/app.go ---
    @@ -39,7 +39,7 @@ var appConfig = configDefaults{
     	Name:     os.Args[0],
     	HelpName: os.Args[0],
     	Usage:    "A Brooklyn command line client application",
    -	Version:  "0.9.0",
    +	Version:  "0.10.0-SNAPSHOT",
    --- End diff --
    
    thanks @neykov forgot about that


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-client pull request: [BROOKLYN-280] add --skipSslChecks f...

Posted by johnmccabe <gi...@git.apache.org>.
Github user johnmccabe commented on the pull request:

    https://github.com/apache/brooklyn-client/pull/21#issuecomment-221643336
  
    I'm tempted to change the flag to match `curl`
    ```
    -k, --insecure
    ```
    wdyt?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-client pull request: [BROOKLYN-280] add --skipSslChecks f...

Posted by m4rkmckenna <gi...@git.apache.org>.
Github user m4rkmckenna commented on the pull request:

    https://github.com/apache/brooklyn-client/pull/21#issuecomment-221651007
  
    +1 to matching curl


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-client pull request: [BROOKLYN-280] add --skipSslChecks f...

Posted by geomacy <gi...@git.apache.org>.
Github user geomacy commented on the pull request:

    https://github.com/apache/brooklyn-client/pull/21#issuecomment-222113170
  
    \U0001f44d LGTM, I have pulled and tested this and it works well.   Think this is a  valuable addition to the tool.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-client pull request: [BROOKLYN-280] add --skipSslChecks f...

Posted by johnmccabe <gi...@git.apache.org>.
Github user johnmccabe commented on the pull request:

    https://github.com/apache/brooklyn-client/pull/21#issuecomment-222179631
  
    Thanks @geomacy should be good to merge now


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-client pull request: [BROOKLYN-280] add --skipSslChecks f...

Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on a diff in the pull request:

    https://github.com/apache/brooklyn-client/pull/21#discussion_r64515968
  
    --- Diff: app/app.go ---
    @@ -39,7 +39,7 @@ var appConfig = configDefaults{
     	Name:     os.Args[0],
     	HelpName: os.Args[0],
     	Usage:    "A Brooklyn command line client application",
    -	Version:  "0.9.0",
    +	Version:  "0.10.0-SNAPSHOT",
    --- End diff --
    
    Add an inline comment `BROOKLYN_VERSION`, or a comment on the line above `BROOKLYN_VERSION_BELOW` to have this changed automatically.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---