You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2019/01/03 23:12:06 UTC

[GitHub] rawlinp commented on a change in pull request #3177: Added warning SQL query for duplicated origins

rawlinp commented on a change in pull request #3177: Added warning SQL query for duplicated origins
URL: https://github.com/apache/trafficcontrol/pull/3177#discussion_r245163251
 
 

 ##########
 File path: traffic_ops/app/db/admin.pl
 ##########
 @@ -64,7 +64,7 @@
 	. "dropdb  - Execute db 'dropdb' on the database for the current environment.\n"
 
 Review comment:
   Since this script is deprecated I don't think we should be adding new functionality to it. I think the new functionality should only be added to admin.go unless there is a very good reason it also needs to be in admin.pl. If there is a very good reason for it, then admin.pl should just shell out to the admin binary so that the checks aren't duplicated.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services