You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@weex.apache.org by YorkShen <gi...@git.apache.org> on 2018/06/29 07:22:33 UTC

[GitHub] incubator-weex pull request #1303: [Weex-488] InstanceWrap unavailable on An...

GitHub user YorkShen opened a pull request:

    https://github.com/apache/incubator-weex/pull/1303

    [Weex-488] InstanceWrap unavailable on Android

    https://issues.apache.org/jira/browse/WEEX-488

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/YorkShen/incubator-weex bugfix_downgrade

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-weex/pull/1303.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1303
    
----
commit 6149d49d70409faacad25e4759a564446c290838
Author: YorkShen <sh...@...>
Date:   2018-06-29T06:46:36Z

    Revert "* [Android] Fix potential memory leak."
    
    This reverts commit 361df72 and fix memory leak by make instanceWrap not global
    
    (cherry picked from commit 07f8250)

----


---

[GitHub] incubator-weex pull request #1303: [Weex-488] InstanceWrap unavailable on An...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-weex/pull/1303


---

[GitHub] incubator-weex issue #1303: [Weex-488] InstanceWrap unavailable on Android

Posted by weex-bot <gi...@git.apache.org>.
Github user weex-bot commented on the issue:

    https://github.com/apache/incubator-weex/pull/1303
  
    
    <!--
      0 failure: 
      1 warning:  No Changelog chan...
      1 messages
      
    -->
    
    
    <table>
      <thead>
        <tr>
          <th width="50"></th>
          <th width="100%" data-danger-table="true">Warnings</th>
        </tr>
      </thead>
      <tbody><tr>
          <td>:warning:</td>
          <td>No Changelog changes!</td>
        </tr>
      </tbody>
    </table>
    
    
    <table>
      <thead>
        <tr>
          <th width="50"></th>
          <th width="100%" data-danger-table="true">Messages</th>
        </tr>
      </thead>
      <tbody><tr>
          <td>:book:</td>
          <td>danger test finished.</td>
        </tr>
      </tbody>
    </table>
    
    
    <p align="right">
      Generated by :no_entry_sign: <a href="http://github.com/danger/danger-js/">dangerJS</a>
    </p>



---