You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/12/05 17:29:06 UTC

[GitHub] [pulsar] BewareMyPower commented on pull request #7848: take seek time into account in Reader#hasMessageAvailable

BewareMyPower commented on pull request #7848:
URL: https://github.com/apache/pulsar/pull/7848#issuecomment-739324457


   The cpp tests will be passed after merging [my PR](https://github.com/aloyszhang/pulsar/pull/1).
   
   However, when I tried to add a unit test for `testHasMessageAvailableAfterSeekTime`, it failed. After looking into the issue, it's because there're some problems with C++ reader's hasMessageAvailable` implementation. Instead of involving these changes including related tests into this PR, I think it's better to open a new PR to fix it later.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org