You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Bharathkrishna Guruvayoor Murali via Review Board <no...@reviews.apache.org> on 2018/07/03 18:32:48 UTC
Review Request 67815: HIVE-19733 :
RemoteSparkJobStatus#getSparkStageProgress inefficient implementation
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67815/
-----------------------------------------------------------
Review request for hive, Peter Vary and Sahil Takiar.
Repository: hive-git
Description
-------
Adding GetSparkStagesInfoJob which gets the jobInfo and stageInfos in a single job
Diffs
-----
ql/src/java/org/apache/hadoop/hive/ql/exec/spark/status/impl/RemoteSparkJobStatus.java 832832b325d7eb0e43fb34a4306d7ffa43ceaa78
Diff: https://reviews.apache.org/r/67815/diff/1/
Testing
-------
Thanks,
Bharathkrishna Guruvayoor Murali
Re: Review Request 67815: HIVE-19733 :
RemoteSparkJobStatus#getSparkStageProgress inefficient implementation
Posted by Bharathkrishna Guruvayoor Murali via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67815/
-----------------------------------------------------------
(Updated July 19, 2018, 7:21 p.m.)
Review request for hive, Peter Vary and Sahil Takiar.
Changes
-------
I added separate exception messages for getSparkStagesInfo, I hope this would help distinguish exceptions from the getJobInfoJob call.
Repository: hive-git
Description
-------
Adding GetSparkStagesInfoJob which gets the jobInfo and stageInfos in a single job
Diffs (updated)
-----
ql/src/java/org/apache/hadoop/hive/ql/ErrorMsg.java 06d0ed3c18f80df84c7d06e695c722e20957b0eb
ql/src/java/org/apache/hadoop/hive/ql/exec/spark/status/impl/RemoteSparkJobStatus.java 832832b325d7eb0e43fb34a4306d7ffa43ceaa78
Diff: https://reviews.apache.org/r/67815/diff/3/
Changes: https://reviews.apache.org/r/67815/diff/2-3/
Testing
-------
Thanks,
Bharathkrishna Guruvayoor Murali
Re: Review Request 67815: HIVE-19733 :
RemoteSparkJobStatus#getSparkStageProgress inefficient implementation
Posted by Sahil Takiar <ta...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67815/#review205807
-----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/exec/spark/status/impl/RemoteSparkJobStatus.java
Line 194 (original), 197 (patched)
<https://reviews.apache.org/r/67815/#comment288716>
I don't think this makes sense given than the exceptions thrown in this method are specific to run a `GetJobInfoJob`.
- Sahil Takiar
On July 5, 2018, 7:34 p.m., Bharathkrishna Guruvayoor Murali wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67815/
> -----------------------------------------------------------
>
> (Updated July 5, 2018, 7:34 p.m.)
>
>
> Review request for hive, Peter Vary and Sahil Takiar.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Adding GetSparkStagesInfoJob which gets the jobInfo and stageInfos in a single job
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/exec/spark/status/impl/RemoteSparkJobStatus.java 832832b325d7eb0e43fb34a4306d7ffa43ceaa78
>
>
> Diff: https://reviews.apache.org/r/67815/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bharathkrishna Guruvayoor Murali
>
>
Re: Review Request 67815: HIVE-19733 :
RemoteSparkJobStatus#getSparkStageProgress inefficient implementation
Posted by Bharathkrishna Guruvayoor Murali via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67815/#review205811
-----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/exec/spark/status/impl/RemoteSparkJobStatus.java
Line 194 (original), 197 (patched)
<https://reviews.apache.org/r/67815/#comment288719>
So should I make the exception messages generic to both the methods that can call getSparkJobInfo() ?
- Bharathkrishna Guruvayoor Murali
On July 5, 2018, 7:34 p.m., Bharathkrishna Guruvayoor Murali wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67815/
> -----------------------------------------------------------
>
> (Updated July 5, 2018, 7:34 p.m.)
>
>
> Review request for hive, Peter Vary and Sahil Takiar.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Adding GetSparkStagesInfoJob which gets the jobInfo and stageInfos in a single job
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/exec/spark/status/impl/RemoteSparkJobStatus.java 832832b325d7eb0e43fb34a4306d7ffa43ceaa78
>
>
> Diff: https://reviews.apache.org/r/67815/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bharathkrishna Guruvayoor Murali
>
>
Re: Review Request 67815: HIVE-19733 :
RemoteSparkJobStatus#getSparkStageProgress inefficient implementation
Posted by Bharathkrishna Guruvayoor Murali via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67815/
-----------------------------------------------------------
(Updated July 5, 2018, 7:34 p.m.)
Review request for hive, Peter Vary and Sahil Takiar.
Repository: hive-git
Description
-------
Adding GetSparkStagesInfoJob which gets the jobInfo and stageInfos in a single job
Diffs (updated)
-----
ql/src/java/org/apache/hadoop/hive/ql/exec/spark/status/impl/RemoteSparkJobStatus.java 832832b325d7eb0e43fb34a4306d7ffa43ceaa78
Diff: https://reviews.apache.org/r/67815/diff/2/
Changes: https://reviews.apache.org/r/67815/diff/1-2/
Testing
-------
Thanks,
Bharathkrishna Guruvayoor Murali
Re: Review Request 67815: HIVE-19733 :
RemoteSparkJobStatus#getSparkStageProgress inefficient implementation
Posted by Sahil Takiar <ta...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67815/#review205681
-----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/exec/spark/status/impl/RemoteSparkJobStatus.java
Line 215 (original), 218 (patched)
<https://reviews.apache.org/r/67815/#comment288580>
Can this be deleted? Same with `GetStageInfoJob`
ql/src/java/org/apache/hadoop/hive/ql/exec/spark/status/impl/RemoteSparkJobStatus.java
Lines 228 (patched)
<https://reviews.apache.org/r/67815/#comment288582>
Looks very similar to `getSparkJobInfo` should be re-factored
ql/src/java/org/apache/hadoop/hive/ql/exec/spark/status/impl/RemoteSparkJobStatus.java
Lines 256 (patched)
<https://reviews.apache.org/r/67815/#comment288581>
This looks very similar to `GetJobInfoJob`, can the two be re-factored to share common code?
- Sahil Takiar
On July 3, 2018, 6:32 p.m., Bharathkrishna Guruvayoor Murali wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67815/
> -----------------------------------------------------------
>
> (Updated July 3, 2018, 6:32 p.m.)
>
>
> Review request for hive, Peter Vary and Sahil Takiar.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Adding GetSparkStagesInfoJob which gets the jobInfo and stageInfos in a single job
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/exec/spark/status/impl/RemoteSparkJobStatus.java 832832b325d7eb0e43fb34a4306d7ffa43ceaa78
>
>
> Diff: https://reviews.apache.org/r/67815/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bharathkrishna Guruvayoor Murali
>
>