You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/09/18 01:44:19 UTC
[GitHub] [pulsar] Shoothzj opened a new pull request #12080: Remove the deprecated api usage in hdfs
Shoothzj opened a new pull request #12080:
URL: https://github.com/apache/pulsar/pull/12080
### Motivation
Remove the deprecated api usage in hdfs
### Modifications
Use try with resources instead of `closeQuitely`
Remove the Long constructor
### Documentation
- [ ] no-need-doc
little internal optimization
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Shoothzj commented on pull request #12080: Remove the deprecated api usage in hdfs
Posted by GitBox <gi...@apache.org>.
Shoothzj commented on pull request #12080:
URL: https://github.com/apache/pulsar/pull/12080#issuecomment-922234132
@codelipenghui @sijie @BewareMyPower PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] hangc0276 merged pull request #12080: Remove the deprecated api usage in hdfs
Posted by GitBox <gi...@apache.org>.
hangc0276 merged pull request #12080:
URL: https://github.com/apache/pulsar/pull/12080
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Shoothzj closed pull request #12080: Remove the deprecated api usage in hdfs
Posted by GitBox <gi...@apache.org>.
Shoothzj closed pull request #12080:
URL: https://github.com/apache/pulsar/pull/12080
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Shoothzj commented on pull request #12080: Remove the deprecated api usage in hdfs
Posted by GitBox <gi...@apache.org>.
Shoothzj commented on pull request #12080:
URL: https://github.com/apache/pulsar/pull/12080#issuecomment-925828115
> LGTM, just left a comment for the code format.
Fixed, PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] BewareMyPower commented on a change in pull request #12080: Remove the deprecated api usage in hdfs
Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on a change in pull request #12080:
URL: https://github.com/apache/pulsar/pull/12080#discussion_r714751821
##########
File path: pulsar-io/hdfs2/src/main/java/org/apache/pulsar/io/hdfs2/AbstractHdfsConnector.java
##########
@@ -138,12 +137,8 @@ protected void checkHdfsUriForTimeout(Configuration config) throws IOException {
}
InetSocketAddress namenode = NetUtils.createSocketAddr(address, port);
SocketFactory socketFactory = NetUtils.getDefaultSocketFactory(config);
- Socket socket = null;
- try {
- socket = socketFactory.createSocket();
+ try(Socket socket = socketFactory.createSocket()) {
Review comment:
```suggestion
try (Socket socket = socketFactory.createSocket()) {
```
Add the space. I think currently the checkstyle plugin is not applied to pulsar-io module.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Shoothzj commented on pull request #12080: Remove the deprecated api usage in hdfs
Posted by GitBox <gi...@apache.org>.
Shoothzj commented on pull request #12080:
URL: https://github.com/apache/pulsar/pull/12080#issuecomment-922804660
@hangc0276 PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Shoothzj closed pull request #12080: Remove the deprecated api usage in hdfs
Posted by GitBox <gi...@apache.org>.
Shoothzj closed pull request #12080:
URL: https://github.com/apache/pulsar/pull/12080
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Shoothzj closed pull request #12080: Remove the deprecated api usage in hdfs
Posted by GitBox <gi...@apache.org>.
Shoothzj closed pull request #12080:
URL: https://github.com/apache/pulsar/pull/12080
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] hangc0276 commented on pull request #12080: Remove the deprecated api usage in hdfs
Posted by GitBox <gi...@apache.org>.
hangc0276 commented on pull request #12080:
URL: https://github.com/apache/pulsar/pull/12080#issuecomment-926375363
@Shoothzj You can use `/pulsarbot run-failure-checks` to rerun failed tests instead of `close and reopen` the PR, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Shoothzj closed pull request #12080: Remove the deprecated api usage in hdfs
Posted by GitBox <gi...@apache.org>.
Shoothzj closed pull request #12080:
URL: https://github.com/apache/pulsar/pull/12080
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Shoothzj closed pull request #12080: Remove the deprecated api usage in hdfs
Posted by GitBox <gi...@apache.org>.
Shoothzj closed pull request #12080:
URL: https://github.com/apache/pulsar/pull/12080
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Shoothzj closed pull request #12080: Remove the deprecated api usage in hdfs
Posted by GitBox <gi...@apache.org>.
Shoothzj closed pull request #12080:
URL: https://github.com/apache/pulsar/pull/12080
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] BewareMyPower commented on pull request #12080: Remove the deprecated api usage in hdfs
Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on pull request #12080:
URL: https://github.com/apache/pulsar/pull/12080#issuecomment-925770786
LGTM, just left a comment for the code format.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Shoothzj closed pull request #12080: Remove the deprecated api usage in hdfs
Posted by GitBox <gi...@apache.org>.
Shoothzj closed pull request #12080:
URL: https://github.com/apache/pulsar/pull/12080
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Shoothzj closed pull request #12080: Remove the deprecated api usage in hdfs
Posted by GitBox <gi...@apache.org>.
Shoothzj closed pull request #12080:
URL: https://github.com/apache/pulsar/pull/12080
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Shoothzj closed pull request #12080: Remove the deprecated api usage in hdfs
Posted by GitBox <gi...@apache.org>.
Shoothzj closed pull request #12080:
URL: https://github.com/apache/pulsar/pull/12080
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Shoothzj commented on pull request #12080: Remove the deprecated api usage in hdfs
Posted by GitBox <gi...@apache.org>.
Shoothzj commented on pull request #12080:
URL: https://github.com/apache/pulsar/pull/12080#issuecomment-927200561
@merlimat @eolivelli @hangc0276 PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Shoothzj commented on pull request #12080: Remove the deprecated api usage in hdfs
Posted by GitBox <gi...@apache.org>.
Shoothzj commented on pull request #12080:
URL: https://github.com/apache/pulsar/pull/12080#issuecomment-925474984
@merlimat @eolivelli PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Shoothzj commented on pull request #12080: Remove the deprecated api usage in hdfs
Posted by GitBox <gi...@apache.org>.
Shoothzj commented on pull request #12080:
URL: https://github.com/apache/pulsar/pull/12080#issuecomment-926400459
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org