[jira] [Commented] (LUCENE-7384) Remove ScoringWrapperSpans

["David Smiley (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LUCENE-7384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15381604#comment-15381604 ] 

David Smiley commented on LUCENE-7384:
--------------------------------------

[~jpountz] any opinions; you committed LUCENE-6919?  [~romseygeek]? (you added this class originally)

> Remove ScoringWrapperSpans
> --------------------------
>
>                 Key: LUCENE-7384
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7384
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: core/search
>            Reporter: David Smiley
>
> In LUCENE-6919 (Lucene 5.5), ScoringWrapperSpans was modified in such a way that made the existence of this class pointless, and possibly broke anyone who was using it as it's SimScorer argument isn't used anymore.  We should now delete it.  SpanWeight has getSimScorer() so people can customize the SimScorer that way.
> Another small change I observe to improve is have SpanWeight.buildSimWeight's last line use the existing Similarity that has already been populated on the field?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org