[GitHub] [flink] tillrohrmann commented on a change in pull request #10866: Enable TTL compaction filter by default and deprecate/remove some other TTL API

[GitBox <gi...@apache.org>]

tillrohrmann commented on a change in pull request #10866: Enable TTL compaction filter by default and deprecate/remove some other TTL API
URL: https://github.com/apache/flink/pull/10866#discussion_r366983135
 
 

 ##########
 File path: flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBOptions.java
 ##########
 @@ -59,10 +59,15 @@
 		.defaultValue(1)
 		.withDescription("The number of threads (per stateful operator) used to transfer (download and upload) files in RocksDBStateBackend.");
 
-	/** This determines if compaction filter to cleanup state with TTL is enabled. */
+	/**
+	 * This determines if compaction filter to cleanup state with TTL is enabled.
+	 *
+	 * @deprecated the option will be removed in future and have no effect.
+	 */
+	@Deprecated
 	public static final ConfigOption<Boolean> TTL_COMPACT_FILTER_ENABLED = ConfigOptions
 		.key("state.backend.rocksdb.ttl.compaction.filter.enabled")
-		.defaultValue(false)
+		.defaultValue(true)
 		.withDescription("This determines if compaction filter to cleanup state with TTL is enabled for backend." +
 
 Review comment:
   Whitespace is missing after `.`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services