You are viewing a plain text version of this content. The canonical link for it is here.
Posted to yarn-issues@hadoop.apache.org by "Peter Bacsko (JIRA)" <ji...@apache.org> on 2019/08/09 11:02:00 UTC
[jira] [Commented] (YARN-9133) Make tests more easy to comprehend
in TestGpuResourceHandler
[ https://issues.apache.org/jira/browse/YARN-9133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16903805#comment-16903805 ]
Peter Bacsko commented on YARN-9133:
------------------------------------
[~snemeth] similarly to YARN-9140, conflict resolution might not be trivial, also this file has been renamed in the meantime and it wasn't treated as a simple rename (see commits [https://github.com/apache/hadoop/commit/b8bf09ba3d2514ccfa3c6beb4a7530cd2f3555c7] and [https://github.com/apache/hadoop/commit/7c2042a44d1cd7e60b911cb40642cdd9c443b076]). Not sure if this is worth it.
> Make tests more easy to comprehend in TestGpuResourceHandler
> ------------------------------------------------------------
>
> Key: YARN-9133
> URL: https://issues.apache.org/jira/browse/YARN-9133
> Project: Hadoop YARN
> Issue Type: Improvement
> Reporter: Szilard Nemeth
> Assignee: Peter Bacsko
> Priority: Major
> Attachments: YARN-9133.001.patch, YARN-9133.001.patch, YARN-9133.002.patch, YARN-9133.003.patch, YARN-9133.004.patch, YARN-9133.005.patch, YARN-9133.006.patch, YARN-9133.006.patch
>
>
> Tests are not quite easy to read:
> - Some more helper methods would improve readability.
> - Eliminating the boolean flag that controls if docker is used would also improve readability and clarity.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org