You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "harikrishna-patnala (via GitHub)" <gi...@apache.org> on 2023/06/30 03:19:40 UTC

[GitHub] [cloudstack] harikrishna-patnala commented on a diff in pull request #7378: Public IP quarantine feature

harikrishna-patnala commented on code in PR #7378:
URL: https://github.com/apache/cloudstack/pull/7378#discussion_r1247370113


##########
server/src/main/java/com/cloud/network/IpAddressManagerImpl.java:
##########
@@ -318,6 +325,9 @@ public class IpAddressManagerImpl extends ManagerBase implements IpAddressManage
             Boolean.class, "system.vm.public.ip.reservation.mode.strictness", "false",
             "If enabled, the use of System VMs public IP reservation is strict, preferred if not.", true, ConfigKey.Scope.Global);
 
+    public static final ConfigKey<Integer> PUBLIC_IP_ADDRESS_QUARANTINE_DURATION = new ConfigKey<>("Network", Integer.class, "public.ip.address.quarantine.duration",

Review Comment:
   can we change the scope to either network/domain level, to give more flexibility in configuration? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org