You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by "sarutak (via GitHub)" <gi...@apache.org> on 2023/10/09 00:22:11 UTC
[PR] AVRO-3880: [Java][Build] Upgrade maven-antrun-plugin to 3.1.0 [avro]
sarutak opened a new pull request, #2542:
URL: https://github.com/apache/avro/pull/2542
AVRO-3880
## What is the purpose of the change
This PR aims to upgrade `maven-antrun-plugin` to `3.1.0` and replace an deprecated tag `<tasks>` with `<target>`.
In the current main branch, if we try to generate .class files from .proto files for test, we will get an error like as follows.
```
$ mvn -P protobuf-generate generate-test-sources
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-antrun-plugin:3.1.0:run (default) on project avro-protobuf: You are using 'tasks' which has been removed from the maven-antrun-plugin. Please use 'target' and refer to the >>Major Version Upgrade to version 3.0.0<< on the plugin site. -> [Help 1]
```
This is because `maven-antrun-plugin` `3.1.0` is automatically downloaded but `<tasks>` tag is not supported by the version.
Another option to fix this issue would be explicitly specifying the version of the plugin, say `1.8`, which supports `<tasks>` tag, but it's too old.
This PR also includes change for some `.java` files, which is regenerated by the upgraded version of the plugin.
## Verifying this change
Done by CI.
## Documentation
- Does this pull request introduce a new feature? (no)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] AVRO-3880: [Java][Build] Upgrade maven-antrun-plugin to 3.1.0 [avro]
Posted by "martin-g (via GitHub)" <gi...@apache.org>.
martin-g commented on PR #2542:
URL: https://github.com/apache/avro/pull/2542#issuecomment-1899894387
Thank you, @sarutak !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] AVRO-3880: [Java][Build] Upgrade maven-antrun-plugin to 3.1.0 [avro]
Posted by "sarutak (via GitHub)" <gi...@apache.org>.
sarutak commented on PR #2542:
URL: https://github.com/apache/avro/pull/2542#issuecomment-1784165475
@Fokko
Thank you for the review.
Should I ping others for some more review?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] AVRO-3880: [Java][Build] Upgrade maven-antrun-plugin to 3.1.0 [avro]
Posted by "martin-g (via GitHub)" <gi...@apache.org>.
martin-g merged PR #2542:
URL: https://github.com/apache/avro/pull/2542
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org