You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "lhotari (via GitHub)" <gi...@apache.org> on 2023/04/05 05:54:49 UTC

[GitHub] [pulsar] lhotari opened a new pull request, #20014: [fix][proxy] Fix connection read timeout handling in Pulsar Proxy

lhotari opened a new pull request, #20014:
URL: https://github.com/apache/pulsar/pull/20014

   ### Motivation
   
   - The behavior of the custom ProxyReadTimeoutHandler is not defined in any way and based on the code will result in bad behavior and proxy connections being closed
   
   ### Modifications
   
   - Remove ProxyReadTimeoutHandler that was added as part of Zero copy support (#15678)
     - replace with a solution where readTimeoutHandler is remove from the pipeline
   
   ### Documentation
   
   <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
   
   - [ ] `doc` <!-- Your PR contains doc changes. -->
   - [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
   - [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
   - [ ] `doc-complete` <!-- Docs have been already added -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] nodece merged pull request #20014: [fix][proxy] Fix connection read timeout handling in Pulsar Proxy

Posted by "nodece (via GitHub)" <gi...@apache.org>.
nodece merged PR #20014:
URL: https://github.com/apache/pulsar/pull/20014


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] lhotari commented on pull request #20014: [fix][proxy] Fix connection read timeout handling in Pulsar Proxy

Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on PR #20014:
URL: https://github.com/apache/pulsar/pull/20014#issuecomment-1496956946

   /pulsarbot rerun-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] lhotari commented on pull request #20014: [fix][proxy] Fix connection read timeout handling in Pulsar Proxy

Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on PR #20014:
URL: https://github.com/apache/pulsar/pull/20014#issuecomment-1498471953

   > Test failure looks potentially related to the PR:
   > 
   > ```
   >   Error:  Tests run: 17, Failures: 1, Errors: 0, Skipped: 5, Time elapsed: 124.408 s <<< FAILURE! - in org.apache.pulsar.broker.service.TopicTerminationTest
   
   @michaeljmarshall It's most likely yet another flaky one since this PR contains only proxy changes. Broker tests don't use the proxy.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] michaeljmarshall commented on pull request #20014: [fix][proxy] Fix connection read timeout handling in Pulsar Proxy

Posted by "michaeljmarshall (via GitHub)" <gi...@apache.org>.
michaeljmarshall commented on PR #20014:
URL: https://github.com/apache/pulsar/pull/20014#issuecomment-1498455540

   Test failure looks potentially related to the PR:
   
   ```
     Error:  Tests run: 17, Failures: 1, Errors: 0, Skipped: 5, Time elapsed: 124.408 s <<< FAILURE! - in org.apache.pulsar.broker.service.TopicTerminationTest
     Error:  testTerminateWhilePublishing(org.apache.pulsar.broker.service.TopicTerminationTest)  Time elapsed: 20.039 s  <<< FAILURE!
     org.testng.internal.thread.ThreadTimeoutException: Method org.apache.pulsar.broker.service.TopicTerminationTest.testTerminateWhilePublishing() didn't finish within the time-out 20000
     	at java.base@17.0.6/jdk.internal.misc.Unsafe.park(Native Method)
     	at java.base@17.0.6/java.util.concurrent.locks.LockSupport.park(LockSupport.java:211)
     	at java.base@17.0.6/java.util.concurrent.CompletableFuture$Signaller.block(CompletableFuture.java:1864)
     	at java.base@17.0.6/java.util.concurrent.ForkJoinPool.unmanagedBlock(ForkJoinPool.java:3463)
     	at java.base@17.0.6/java.util.concurrent.ForkJoinPool.managedBlock(ForkJoinPool.java:3434)
     	at java.base@17.0.6/java.util.concurrent.CompletableFuture.waitingGet(CompletableFuture.java:1898)
     	at java.base@17.0.6/java.util.concurrent.CompletableFuture.get(CompletableFuture.java:2072)
     	at app//org.apache.pulsar.broker.service.TopicTerminationTest.testTerminateWhilePublishing(TopicTerminationTest.java:172)
     	at java.base@17.0.6/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
     	at java.base@17.0.6/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
     	at java.base@17.0.6/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
     	at java.base@17.0.6/java.lang.reflect.Method.invoke(Method.java:568)
     	at app//org.testng.internal.invokers.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:139)
     	at app//org.testng.internal.invokers.InvokeMethodRunnable.runOne(InvokeMethodRunnable.java:47)
     	at app//org.testng.internal.invokers.InvokeMethodRunnable.call(InvokeMethodRunnable.java:76)
     	at app//org.testng.internal.invokers.InvokeMethodRunnable.call(InvokeMethodRunnable.java:11)
     	at java.base@17.0.6/java.util.concurrent.FutureTask.run(FutureTask.java:264)
     	at java.base@17.0.6/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
     	at java.base@17.0.6/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
     	at java.base@17.0.6/java.lang.Thread.run(Thread.java:833)
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org