You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Martin Grigorov (JIRA)" <ji...@apache.org> on 2012/09/18 10:02:07 UTC

[jira] [Reopened] (WICKET-4758) Fix created in WICKET-3916 is not effective

     [ https://issues.apache.org/jira/browse/WICKET-4758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martin Grigorov reopened WICKET-4758:
-------------------------------------

      Assignee:     (was: Jeremy Thomerson)
    
> Fix created in WICKET-3916 is not effective
> -------------------------------------------
>
>                 Key: WICKET-4758
>                 URL: https://issues.apache.org/jira/browse/WICKET-4758
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket-extensions
>    Affects Versions: 1.5.0, 6.0.0
>            Reporter: Wolfgang Kritzinger
>             Fix For: 6.0.1, 1.5.9
>
>         Attachments: filter-columns2.tar.gz, WICKET-4758.patch
>
>
> The fix in WICKET-3916 is not effective: https://fisheye6.atlassian.com/changelog/wicket?cs=1148229
> https://github.com/apache/wicket/blob/master/wicket-core/src/main/java/org/apache/wicket/Component.java#L2506
> As one can see in Component.internalRenderComponent(), the method Component.onComponentTag(), where the markup id is written to the tag, is called before the behavior had a chance to call setOutputMarkupId(true). (The Behavior.onComponentTag() is called in Component.renderComponentTag() a few lines down. The behavior has to call setOutputMarkupId() earlier, like in onConfigure()

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira