You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by "Tim Sell (JIRA)" <ji...@apache.org> on 2009/03/24 20:18:51 UTC
[jira] Created: (HBASE-1285) Forcing compactions should be
available via thrift.
Forcing compactions should be available via thrift.
---------------------------------------------------
Key: HBASE-1285
URL: https://issues.apache.org/jira/browse/HBASE-1285
Project: Hadoop HBase
Issue Type: New Feature
Reporter: Tim Sell
Assignee: Tim Sell
Priority: Minor
Fix For: 0.20.0
It would be useful to be able to trigger compactions via thrift just as we can with the ruby shell.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-1285) Forcing compactions should be
available via thrift.
Posted by "ryan rawson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12688830#action_12688830 ]
ryan rawson commented on HBASE-1285:
------------------------------------
I'd prefer we did not require users and devs who are uninterested in thrift required to _have_ thrift installed.
The reason is thrift is a fairly heavyweight requirement - you are required to have boost installed to install the compiler. Boost isn't always easy to install (for example on OS X). And all to just generate a few files that are a < .1% by LOC of the code-base.
> Forcing compactions should be available via thrift.
> ---------------------------------------------------
>
> Key: HBASE-1285
> URL: https://issues.apache.org/jira/browse/HBASE-1285
> Project: Hadoop HBase
> Issue Type: New Feature
> Reporter: Tim Sell
> Assignee: Tim Sell
> Priority: Minor
> Fix For: 0.20.0
>
> Attachments: HBase-1285v1.patch
>
>
> It would be useful to be able to trigger compactions via thrift just as we can with the ruby shell.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-1285) Forcing compactions should be
available via thrift.
Posted by "Tim Sell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12688912#action_12688912 ]
Tim Sell commented on HBASE-1285:
---------------------------------
@Jonathan: yeah that's why I was thinking it will need an overhaul soon :)
@Ryan: I agree it would be horrible to require thrift installed for non thrift users. They would obviously only need it if recompiling things though. I guess that's quite common for HBase users though. Maybe it's a not suitable for trunk, it would just be useful for me when tweaking things in the thrift api. So I'll probably patch it for my own use.
> Forcing compactions should be available via thrift.
> ---------------------------------------------------
>
> Key: HBASE-1285
> URL: https://issues.apache.org/jira/browse/HBASE-1285
> Project: Hadoop HBase
> Issue Type: New Feature
> Reporter: Tim Sell
> Assignee: Tim Sell
> Priority: Minor
> Fix For: 0.20.0
>
> Attachments: HBase-1285v1.patch
>
>
> It would be useful to be able to trigger compactions via thrift just as we can with the ruby shell.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HBASE-1285) Forcing compactions should be
available via thrift.
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack resolved HBASE-1285.
--------------------------
Resolution: Fixed
Thanks for the patch Tim. Resolving (FYI, in future, better not to add the CHANGES.txt edit. Patch application breaks if CHANGES.txt has been edited since your change). Good stuff.
> Forcing compactions should be available via thrift.
> ---------------------------------------------------
>
> Key: HBASE-1285
> URL: https://issues.apache.org/jira/browse/HBASE-1285
> Project: Hadoop HBase
> Issue Type: New Feature
> Reporter: Tim Sell
> Assignee: Tim Sell
> Priority: Minor
> Fix For: 0.20.0
>
> Attachments: HBase-1285v1.patch, HBase-1285v2.patch, HBase-1285v3.patch
>
>
> It would be useful to be able to trigger compactions via thrift just as we can with the ruby shell.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-1285) Forcing compactions should be
available via thrift.
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12689290#action_12689290 ]
stack commented on HBASE-1285:
------------------------------
And here is a comment I put in wrong issue "You didn't break the thrift test Tim. Thanks for the patch (Test would be too hard - don't worry about it). "
> Forcing compactions should be available via thrift.
> ---------------------------------------------------
>
> Key: HBASE-1285
> URL: https://issues.apache.org/jira/browse/HBASE-1285
> Project: Hadoop HBase
> Issue Type: New Feature
> Reporter: Tim Sell
> Assignee: Tim Sell
> Priority: Minor
> Fix For: 0.20.0
>
> Attachments: HBase-1285v1.patch, HBase-1285v2.patch, HBase-1285v3.patch
>
>
> It would be useful to be able to trigger compactions via thrift just as we can with the ruby shell.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-1285) Forcing compactions should be
available via thrift.
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12689276#action_12689276 ]
stack commented on HBASE-1285:
------------------------------
Tim: Can you help Alex over in HBASE-1286 with how to get the thrift we're using? Maybe you know?
> Forcing compactions should be available via thrift.
> ---------------------------------------------------
>
> Key: HBASE-1285
> URL: https://issues.apache.org/jira/browse/HBASE-1285
> Project: Hadoop HBase
> Issue Type: New Feature
> Reporter: Tim Sell
> Assignee: Tim Sell
> Priority: Minor
> Fix For: 0.20.0
>
> Attachments: HBase-1285v1.patch, HBase-1285v2.patch, HBase-1285v3.patch
>
>
> It would be useful to be able to trigger compactions via thrift just as we can with the ruby shell.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-1285) Forcing compactions should be
available via thrift.
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12689034#action_12689034 ]
stack commented on HBASE-1285:
------------------------------
Tim, upload patch with generated changes and I'll commit it.
I'm with Ryan that yeah, lets not inline generation of thrift files with main build but a thrift target in ant build that user manually invokes would indeed be useful.
Thanks Tim.
> Forcing compactions should be available via thrift.
> ---------------------------------------------------
>
> Key: HBASE-1285
> URL: https://issues.apache.org/jira/browse/HBASE-1285
> Project: Hadoop HBase
> Issue Type: New Feature
> Reporter: Tim Sell
> Assignee: Tim Sell
> Priority: Minor
> Fix For: 0.20.0
>
> Attachments: HBase-1285v1.patch
>
>
> It would be useful to be able to trigger compactions via thrift just as we can with the ruby shell.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-1285) Forcing compactions should be
available via thrift.
Posted by "Jonathan Gray (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12688828#action_12688828 ]
Jonathan Gray commented on HBASE-1285:
--------------------------------------
Tim, definitely hold off an the overhaul. Likely the client API will change dramatically in 0.20
> Forcing compactions should be available via thrift.
> ---------------------------------------------------
>
> Key: HBASE-1285
> URL: https://issues.apache.org/jira/browse/HBASE-1285
> Project: Hadoop HBase
> Issue Type: New Feature
> Reporter: Tim Sell
> Assignee: Tim Sell
> Priority: Minor
> Fix For: 0.20.0
>
> Attachments: HBase-1285v1.patch
>
>
> It would be useful to be able to trigger compactions via thrift just as we can with the ruby shell.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-1285) Forcing compactions should be
available via thrift.
Posted by "Tim Sell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tim Sell updated HBASE-1285:
----------------------------
Attachment: HBase-1285v3.patch
sorry, forgot to change CHANGES.txt, new patch
> Forcing compactions should be available via thrift.
> ---------------------------------------------------
>
> Key: HBASE-1285
> URL: https://issues.apache.org/jira/browse/HBASE-1285
> Project: Hadoop HBase
> Issue Type: New Feature
> Reporter: Tim Sell
> Assignee: Tim Sell
> Priority: Minor
> Fix For: 0.20.0
>
> Attachments: HBase-1285v1.patch, HBase-1285v2.patch, HBase-1285v3.patch
>
>
> It would be useful to be able to trigger compactions via thrift just as we can with the ruby shell.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-1285) Forcing compactions should be
available via thrift.
Posted by "Tim Sell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12689280#action_12689280 ]
Tim Sell commented on HBASE-1285:
---------------------------------
aha, np :)
> Forcing compactions should be available via thrift.
> ---------------------------------------------------
>
> Key: HBASE-1285
> URL: https://issues.apache.org/jira/browse/HBASE-1285
> Project: Hadoop HBase
> Issue Type: New Feature
> Reporter: Tim Sell
> Assignee: Tim Sell
> Priority: Minor
> Fix For: 0.20.0
>
> Attachments: HBase-1285v1.patch, HBase-1285v2.patch, HBase-1285v3.patch
>
>
> It would be useful to be able to trigger compactions via thrift just as we can with the ruby shell.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-1285) Forcing compactions should be
available via thrift.
Posted by "Tim Sell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tim Sell updated HBASE-1285:
----------------------------
Attachment: HBase-1285v2.patch
Attached patch that includes changes to generated files, of which it only touches Hbase.java
I haven't included a test. Not sure if it needs one or the best way to test this? It seems silly to run an actual compaction on a minidfs instance. Maybe it would make sense to just mock HBaseAdmin and HTable and check the right functions are called with the right arguments etc? The actual client operations aren't the thrift servers responsibility.
I did run the tests and TestThriftServer fails. I tried it without my changes and it still failed. I'm not sure why.
> Forcing compactions should be available via thrift.
> ---------------------------------------------------
>
> Key: HBASE-1285
> URL: https://issues.apache.org/jira/browse/HBASE-1285
> Project: Hadoop HBase
> Issue Type: New Feature
> Reporter: Tim Sell
> Assignee: Tim Sell
> Priority: Minor
> Fix For: 0.20.0
>
> Attachments: HBase-1285v1.patch, HBase-1285v2.patch
>
>
> It would be useful to be able to trigger compactions via thrift just as we can with the ruby shell.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-1285) Forcing compactions should be
available via thrift.
Posted by "Tim Sell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tim Sell updated HBASE-1285:
----------------------------
Attachment: HBase-1285v1.patch
This patch adds the compact and majorCompact functions to the thrift api.
I think the thrift api will need of another overhaul soon. but for now this works.
I didn't patch the generated files. I'll make a new patch tomorrow.
In a related issue I think we should generate the thrift src files in an ant target and not include them in the source code. But this would require that users recompiling hbase have thrift installed. Apparently thrift is gearing up for an apache release soon, which might make this more reasonable. I might make an issue/patch for that anyway as it would be useful for when using a different version of thrift.
> Forcing compactions should be available via thrift.
> ---------------------------------------------------
>
> Key: HBASE-1285
> URL: https://issues.apache.org/jira/browse/HBASE-1285
> Project: Hadoop HBase
> Issue Type: New Feature
> Reporter: Tim Sell
> Assignee: Tim Sell
> Priority: Minor
> Fix For: 0.20.0
>
> Attachments: HBase-1285v1.patch
>
>
> It would be useful to be able to trigger compactions via thrift just as we can with the ruby shell.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.