You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@struts.apache.org by Steven Benitez <st...@gmail.com> on 2011/06/04 01:53:34 UTC
Struts2 Code Generification
I'd like to volunteer to help generify the Struts2 codebase. From an
administrative perspective, what would be the easier way to proceed? Create
a single JIRA ticket to attach patches to?
Would it be easier to create several smaller patches or a few larger ones?
Re: Struts2 Code Generification
Posted by Lukasz Lenart <lu...@googlemail.com>.
2011/6/5 Steven Benitez <st...@gmail.com>:
> Tickets are here:
> https://issues.apache.org/jira/browse/WW-3641
> https://issues.apache.org/jira/browse/XW-393
> The first WW patch is a bit of a larger one, since I started it before your
> response, Lukasz. The first XW patch is smaller.
> I updated the ApplicationMap and RequestMap in struts2-core to extend
> AbstractMap<String, Object> instead of just AbstractMap. However, the
> SessionMap was previously generified as SessionMap<K, V>, which I don't
> think is correct. The current patch doesn't address this, but I'd like to
> change from:
> SessionMap<K, V> extends AbstractMap<K, V> to
> SessionMap extends AbstractMap<String, Object>
> <String, Object> is what we use for the session throughout Struts2 and its
> what the HttpSession uses too.
> Any objections to this change?
Nop, go for it :-)
Regards
--
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
Warszawa JUG conference - Confitura http://confitura.pl/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Struts2 Code Generification
Posted by Steven Benitez <st...@gmail.com>.
Tickets are here:
https://issues.apache.org/jira/browse/WW-3641
https://issues.apache.org/jira/browse/XW-393
The first WW patch is a bit of a larger one, since I started it before your
response, Lukasz. The first XW patch is smaller.
I updated the ApplicationMap and RequestMap in struts2-core to extend
AbstractMap<String, Object> instead of just AbstractMap. However, the
SessionMap was previously generified as SessionMap<K, V>, which I don't
think is correct. The current patch doesn't address this, but I'd like to
change from:
SessionMap<K, V> extends AbstractMap<K, V> to
SessionMap extends AbstractMap<String, Object>
<String, Object> is what we use for the session throughout Struts2 and its
what the HttpSession uses too.
Any objections to this change?
On Sun, Jun 5, 2011 at 4:49 AM, Lukasz Lenart
<lu...@googlemail.com>wrote:
> 2011/6/4 Steven Benitez <st...@gmail.com>:
> > I'd like to volunteer to help generify the Struts2 codebase. From an
> > administrative perspective, what would be the easier way to proceed?
> Create
> > a single JIRA ticket to attach patches to?
> >
> > Would it be easier to create several smaller patches or a few larger
> ones?
>
> Prepare a patch for small subset of changes, then create a JIRA ticket
> and attach the patch to it. It would be better to do it with small
> steps as we can make a release in middle of your work ;-)
>
> Many thanks for your help!
>
>
> Kind regards
> --
> Łukasz
> + 48 606 323 122 http://www.lenart.org.pl/
> Warszawa JUG conference - Confitura http://confitura.pl/
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
Re: Struts2 Code Generification
Posted by Lukasz Lenart <lu...@googlemail.com>.
2011/6/4 Steven Benitez <st...@gmail.com>:
> I'd like to volunteer to help generify the Struts2 codebase. From an
> administrative perspective, what would be the easier way to proceed? Create
> a single JIRA ticket to attach patches to?
>
> Would it be easier to create several smaller patches or a few larger ones?
Prepare a patch for small subset of changes, then create a JIRA ticket
and attach the patch to it. It would be better to do it with small
steps as we can make a release in middle of your work ;-)
Many thanks for your help!
Kind regards
--
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
Warszawa JUG conference - Confitura http://confitura.pl/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org