You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "cvictory (via GitHub)" <gi...@apache.org> on 2025/09/21 13:59:53 UTC
[PR] Fix/update metadata bug in v2 config [rocketmq]
cvictory opened a new pull request, #9724:
URL: https://github.com/apache/rocketmq/pull/9724
<!-- Please make sure the target branch is right. In most case, the target branch should be `develop`. -->
### Which Issue(s) This PR Fixes
Fixes #9723
### Brief Description
Firstly update SubscriptionGroup, then write to rocksdb.
### How Did You Test This Change?
No need tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix/update metadata bug in v2 config [rocketmq]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins commented on PR #9724:
URL: https://github.com/apache/rocketmq/pull/9724#issuecomment-3316533366
Note: The update method has side effects.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix/update metadata bug in v2 config [rocketmq]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins merged PR #9724:
URL: https://github.com/apache/rocketmq/pull/9724
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix/update metadata bug in v2 config [rocketmq]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #9724:
URL: https://github.com/apache/rocketmq/pull/9724#issuecomment-3316031685
## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/9724?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 48.21%. Comparing base ([`fbe9f73`](https://app.codecov.io/gh/apache/rocketmq/commit/fbe9f733b96b3c28d789bf1b81108cb490e7d83d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4952138`](https://app.codecov.io/gh/apache/rocketmq/commit/4952138deadaaf6de238c4e6c6cbc6b3807f27d9?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## develop #9724 +/- ##
=============================================
- Coverage 48.26% 48.21% -0.05%
+ Complexity 12171 12161 -10
=============================================
Files 1313 1313
Lines 93236 93236
Branches 11945 11945
=============================================
- Hits 45002 44956 -46
- Misses 42660 42701 +41
- Partials 5574 5579 +5
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/rocketmq/pull/9724?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org