You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/08/05 02:35:53 UTC
[GitHub] [flink] KarmaGYZ opened a new pull request #13063: [FLINK-15448] Add Node information to the ResourceId of TaskExecutor …
KarmaGYZ opened a new pull request #13063:
URL: https://github.com/apache/flink/pull/13063
…in Yarn
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
Add Node information to the ResourceId of TaskExecutor in Yarn
## Brief change log
Add Node information to the ResourceId of TaskExecutor in Yarn
## Verifying this change
This change is already covered by existing tests, such as `YarnResourceManagerTest` and `YARNITCase`.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
- The S3 file system connector: no
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13063: [FLINK-15448] Add Node information to the ResourceId of TaskExecutor …
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13063:
URL: https://github.com/apache/flink/pull/13063#issuecomment-668948742
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c0c3cc811dba6b3ef30730c79ea1e12cd7c8c0a9",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c0c3cc811dba6b3ef30730c79ea1e12cd7c8c0a9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c0c3cc811dba6b3ef30730c79ea1e12cd7c8c0a9 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13063: [FLINK-15448] Add Node information to the ResourceId of TaskExecutor …
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13063:
URL: https://github.com/apache/flink/pull/13063#issuecomment-668948742
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c0c3cc811dba6b3ef30730c79ea1e12cd7c8c0a9",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5183",
"triggerID" : "c0c3cc811dba6b3ef30730c79ea1e12cd7c8c0a9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c0c3cc811dba6b3ef30730c79ea1e12cd7c8c0a9 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5183)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13063: [FLINK-15448] Add Node information to the ResourceId of TaskExecutor …
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13063:
URL: https://github.com/apache/flink/pull/13063#issuecomment-668948742
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c0c3cc811dba6b3ef30730c79ea1e12cd7c8c0a9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5183",
"triggerID" : "c0c3cc811dba6b3ef30730c79ea1e12cd7c8c0a9",
"triggerType" : "PUSH"
}, {
"hash" : "465d0515e5c66080ab1caae56d5f45a0a8b1f1bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5187",
"triggerID" : "465d0515e5c66080ab1caae56d5f45a0a8b1f1bf",
"triggerType" : "PUSH"
}, {
"hash" : "404e2e4a71aa8aaf4ff053f3a149243e8767b979",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5229",
"triggerID" : "404e2e4a71aa8aaf4ff053f3a149243e8767b979",
"triggerType" : "PUSH"
}, {
"hash" : "84ec3dd659a043853dcbce62a666924eaeffe2bb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5585",
"triggerID" : "84ec3dd659a043853dcbce62a666924eaeffe2bb",
"triggerType" : "PUSH"
}, {
"hash" : "edc382ac0f729db3adf67e17564cfc40e627753d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5607",
"triggerID" : "edc382ac0f729db3adf67e17564cfc40e627753d",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "CANCELED",
"url" : "TBD",
"triggerID" : "675350868",
"triggerType" : "MANUAL"
}, {
"hash" : "f8cbaf4d4b327151ce1e7ff203d02ef386006865",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5667",
"triggerID" : "675350868",
"triggerType" : "MANUAL"
}, {
"hash" : "f8cbaf4d4b327151ce1e7ff203d02ef386006865",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5667",
"triggerID" : "f8cbaf4d4b327151ce1e7ff203d02ef386006865",
"triggerType" : "PUSH"
}, {
"hash" : "b5846b825b766f68e81d0587bf933a61a3805776",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "b5846b825b766f68e81d0587bf933a61a3805776",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* Unknown: [CANCELED](TBD)
* f8cbaf4d4b327151ce1e7ff203d02ef386006865 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5667)
* b5846b825b766f68e81d0587bf933a61a3805776 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] xintongsong commented on a change in pull request #13063: [FLINK-15448] Add Node information to the ResourceId of TaskExecutor …
Posted by GitBox <gi...@apache.org>.
xintongsong commented on a change in pull request #13063:
URL: https://github.com/apache/flink/pull/13063#discussion_r469036537
##########
File path: flink-yarn/src/main/java/org/apache/flink/yarn/YarnResourceManager.java
##########
@@ -91,9 +91,12 @@
private static final Priority RM_REQUEST_PRIORITY = Priority.newInstance(1);
- /** YARN container map. Package private for unit test purposes. */
+ /** YARN container map. */
private final ConcurrentMap<ResourceID, YarnWorkerNode> workerNodeMap;
+ /** Mapping the Container id to ResourceID. */
+ private final ConcurrentMap<ContainerId, ResourceID> containerIdToResourceIdMap;
Review comment:
Why do we need to maintain this map? It seems to me that `ResourceId` can be deterministically generated from `ContainerId`.
##########
File path: flink-yarn/src/main/java/org/apache/flink/yarn/YarnResourceManager.java
##########
@@ -91,9 +91,12 @@
private static final Priority RM_REQUEST_PRIORITY = Priority.newInstance(1);
- /** YARN container map. Package private for unit test purposes. */
+ /** YARN container map. */
Review comment:
Unrelated change. Let's keep it in a separate hotfix commit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13063: [FLINK-15448] Add Node information to the ResourceId of TaskExecutor …
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13063:
URL: https://github.com/apache/flink/pull/13063#issuecomment-668948742
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c0c3cc811dba6b3ef30730c79ea1e12cd7c8c0a9",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5183",
"triggerID" : "c0c3cc811dba6b3ef30730c79ea1e12cd7c8c0a9",
"triggerType" : "PUSH"
}, {
"hash" : "465d0515e5c66080ab1caae56d5f45a0a8b1f1bf",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "465d0515e5c66080ab1caae56d5f45a0a8b1f1bf",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c0c3cc811dba6b3ef30730c79ea1e12cd7c8c0a9 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5183)
* 465d0515e5c66080ab1caae56d5f45a0a8b1f1bf UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13063: [FLINK-15448] Add Node information to the ResourceId of TaskExecutor …
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13063:
URL: https://github.com/apache/flink/pull/13063#issuecomment-668948742
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c0c3cc811dba6b3ef30730c79ea1e12cd7c8c0a9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5183",
"triggerID" : "c0c3cc811dba6b3ef30730c79ea1e12cd7c8c0a9",
"triggerType" : "PUSH"
}, {
"hash" : "465d0515e5c66080ab1caae56d5f45a0a8b1f1bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5187",
"triggerID" : "465d0515e5c66080ab1caae56d5f45a0a8b1f1bf",
"triggerType" : "PUSH"
}, {
"hash" : "404e2e4a71aa8aaf4ff053f3a149243e8767b979",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5229",
"triggerID" : "404e2e4a71aa8aaf4ff053f3a149243e8767b979",
"triggerType" : "PUSH"
}, {
"hash" : "84ec3dd659a043853dcbce62a666924eaeffe2bb",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5585",
"triggerID" : "84ec3dd659a043853dcbce62a666924eaeffe2bb",
"triggerType" : "PUSH"
}, {
"hash" : "edc382ac0f729db3adf67e17564cfc40e627753d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5607",
"triggerID" : "edc382ac0f729db3adf67e17564cfc40e627753d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 84ec3dd659a043853dcbce62a666924eaeffe2bb Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5585)
* edc382ac0f729db3adf67e17564cfc40e627753d Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5607)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13063: [FLINK-15448] Add Node information to the ResourceId of TaskExecutor …
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13063:
URL: https://github.com/apache/flink/pull/13063#issuecomment-668948742
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c0c3cc811dba6b3ef30730c79ea1e12cd7c8c0a9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5183",
"triggerID" : "c0c3cc811dba6b3ef30730c79ea1e12cd7c8c0a9",
"triggerType" : "PUSH"
}, {
"hash" : "465d0515e5c66080ab1caae56d5f45a0a8b1f1bf",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5187",
"triggerID" : "465d0515e5c66080ab1caae56d5f45a0a8b1f1bf",
"triggerType" : "PUSH"
}, {
"hash" : "404e2e4a71aa8aaf4ff053f3a149243e8767b979",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5229",
"triggerID" : "404e2e4a71aa8aaf4ff053f3a149243e8767b979",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 465d0515e5c66080ab1caae56d5f45a0a8b1f1bf Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5187)
* 404e2e4a71aa8aaf4ff053f3a149243e8767b979 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5229)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13063: [FLINK-15448] Add Node information to the ResourceId of TaskExecutor …
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13063:
URL: https://github.com/apache/flink/pull/13063#issuecomment-668948742
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c0c3cc811dba6b3ef30730c79ea1e12cd7c8c0a9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5183",
"triggerID" : "c0c3cc811dba6b3ef30730c79ea1e12cd7c8c0a9",
"triggerType" : "PUSH"
}, {
"hash" : "465d0515e5c66080ab1caae56d5f45a0a8b1f1bf",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5187",
"triggerID" : "465d0515e5c66080ab1caae56d5f45a0a8b1f1bf",
"triggerType" : "PUSH"
}, {
"hash" : "404e2e4a71aa8aaf4ff053f3a149243e8767b979",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "404e2e4a71aa8aaf4ff053f3a149243e8767b979",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 465d0515e5c66080ab1caae56d5f45a0a8b1f1bf Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5187)
* 404e2e4a71aa8aaf4ff053f3a149243e8767b979 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13063: [FLINK-15448] Add Node information to the ResourceId of TaskExecutor …
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13063:
URL: https://github.com/apache/flink/pull/13063#issuecomment-668948742
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c0c3cc811dba6b3ef30730c79ea1e12cd7c8c0a9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5183",
"triggerID" : "c0c3cc811dba6b3ef30730c79ea1e12cd7c8c0a9",
"triggerType" : "PUSH"
}, {
"hash" : "465d0515e5c66080ab1caae56d5f45a0a8b1f1bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5187",
"triggerID" : "465d0515e5c66080ab1caae56d5f45a0a8b1f1bf",
"triggerType" : "PUSH"
}, {
"hash" : "404e2e4a71aa8aaf4ff053f3a149243e8767b979",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5229",
"triggerID" : "404e2e4a71aa8aaf4ff053f3a149243e8767b979",
"triggerType" : "PUSH"
}, {
"hash" : "84ec3dd659a043853dcbce62a666924eaeffe2bb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5585",
"triggerID" : "84ec3dd659a043853dcbce62a666924eaeffe2bb",
"triggerType" : "PUSH"
}, {
"hash" : "edc382ac0f729db3adf67e17564cfc40e627753d",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5607",
"triggerID" : "edc382ac0f729db3adf67e17564cfc40e627753d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* edc382ac0f729db3adf67e17564cfc40e627753d Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5607)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] xintongsong commented on pull request #13063: [FLINK-15448] Add Node information to the ResourceId of TaskExecutor …
Posted by GitBox <gi...@apache.org>.
xintongsong commented on pull request #13063:
URL: https://github.com/apache/flink/pull/13063#issuecomment-675350868
@flinkbot run azure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13063: [FLINK-15448] Add Node information to the ResourceId of TaskExecutor …
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13063:
URL: https://github.com/apache/flink/pull/13063#issuecomment-668948742
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c0c3cc811dba6b3ef30730c79ea1e12cd7c8c0a9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5183",
"triggerID" : "c0c3cc811dba6b3ef30730c79ea1e12cd7c8c0a9",
"triggerType" : "PUSH"
}, {
"hash" : "465d0515e5c66080ab1caae56d5f45a0a8b1f1bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5187",
"triggerID" : "465d0515e5c66080ab1caae56d5f45a0a8b1f1bf",
"triggerType" : "PUSH"
}, {
"hash" : "404e2e4a71aa8aaf4ff053f3a149243e8767b979",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5229",
"triggerID" : "404e2e4a71aa8aaf4ff053f3a149243e8767b979",
"triggerType" : "PUSH"
}, {
"hash" : "84ec3dd659a043853dcbce62a666924eaeffe2bb",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5585",
"triggerID" : "84ec3dd659a043853dcbce62a666924eaeffe2bb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 84ec3dd659a043853dcbce62a666924eaeffe2bb Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5585)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] xintongsong commented on a change in pull request #13063: [FLINK-15448] Add Node information to the ResourceId of TaskExecutor …
Posted by GitBox <gi...@apache.org>.
xintongsong commented on a change in pull request #13063:
URL: https://github.com/apache/flink/pull/13063#discussion_r471960164
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/types/ResourceID.java
##########
@@ -32,9 +33,17 @@
private final String resourceId;
+ private final String metadata;
+
public ResourceID(String resourceId) {
+ this(resourceId, "");
+ }
+
+ public ResourceID(String resourceId, String metadata) {
Preconditions.checkNotNull(resourceId, "ResourceID must not be null");
+ Preconditions.checkNotNull(metadata, "ResourceID must not be null");
Review comment:
Unclear error messages.
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/types/ResourceID.java
##########
@@ -46,6 +55,10 @@ public final String getResourceIdString() {
return resourceId;
}
+ public final String getLogStringWithMetadata() {
+ return StringUtils.isNullOrWhitespaceOnly(metadata) ? resourceId : String.format("[%s, %s]", resourceId, metadata);
Review comment:
Minor: not sure about the format `[%s, $s]`. `[]` are usually used for arrays. I would suggest something like `%s(%s)`.
For the Flink Yarn deployment, the outputs would look like:
```
[container_xxxxxx_000001, foo.bar.hostname]
container_xxxxxx_000001(foo.bar.hostname)
```
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/types/ResourceID.java
##########
@@ -46,6 +55,10 @@ public final String getResourceIdString() {
return resourceId;
}
+ public final String getLogStringWithMetadata() {
Review comment:
I would suggest `toStringWithMetadata` or `getStringWithMetadata`.
It would be better that the method name describes what the methods does but not assume how it is used.
##########
File path: flink-core/src/main/java/org/apache/flink/configuration/TaskManagerOptionsInternal.java
##########
@@ -0,0 +1,36 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.configuration;
+
+import org.apache.flink.annotation.Internal;
+
+import static org.apache.flink.configuration.ConfigOptions.key;
+
+/**
+ * TaskManager options that are not meant to be used by the user.
+ */
+@Internal
+public class TaskManagerOptionsInternal {
+
+ public static final ConfigOption<String> TASK_MANAGER_RESOURCE_ID_METADATA =
+ key("internal.taskmanager.resource-id.metadata")
Review comment:
minor: usually we prepend a `$` to the internal config keys, to further protect it. See `YarnConfigOptionsInternal` as an example.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13063: [FLINK-15448] Add Node information to the ResourceId of TaskExecutor …
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13063:
URL: https://github.com/apache/flink/pull/13063#issuecomment-668948742
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c0c3cc811dba6b3ef30730c79ea1e12cd7c8c0a9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5183",
"triggerID" : "c0c3cc811dba6b3ef30730c79ea1e12cd7c8c0a9",
"triggerType" : "PUSH"
}, {
"hash" : "465d0515e5c66080ab1caae56d5f45a0a8b1f1bf",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5187",
"triggerID" : "465d0515e5c66080ab1caae56d5f45a0a8b1f1bf",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 465d0515e5c66080ab1caae56d5f45a0a8b1f1bf Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5187)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13063: [FLINK-15448] Add Node information to the ResourceId of TaskExecutor …
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13063:
URL: https://github.com/apache/flink/pull/13063#issuecomment-668948742
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c0c3cc811dba6b3ef30730c79ea1e12cd7c8c0a9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5183",
"triggerID" : "c0c3cc811dba6b3ef30730c79ea1e12cd7c8c0a9",
"triggerType" : "PUSH"
}, {
"hash" : "465d0515e5c66080ab1caae56d5f45a0a8b1f1bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5187",
"triggerID" : "465d0515e5c66080ab1caae56d5f45a0a8b1f1bf",
"triggerType" : "PUSH"
}, {
"hash" : "404e2e4a71aa8aaf4ff053f3a149243e8767b979",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5229",
"triggerID" : "404e2e4a71aa8aaf4ff053f3a149243e8767b979",
"triggerType" : "PUSH"
}, {
"hash" : "84ec3dd659a043853dcbce62a666924eaeffe2bb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5585",
"triggerID" : "84ec3dd659a043853dcbce62a666924eaeffe2bb",
"triggerType" : "PUSH"
}, {
"hash" : "edc382ac0f729db3adf67e17564cfc40e627753d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5607",
"triggerID" : "edc382ac0f729db3adf67e17564cfc40e627753d",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "CANCELED",
"url" : "TBD",
"triggerID" : "675350868",
"triggerType" : "MANUAL"
}, {
"hash" : "f8cbaf4d4b327151ce1e7ff203d02ef386006865",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5667",
"triggerID" : "675350868",
"triggerType" : "MANUAL"
}, {
"hash" : "f8cbaf4d4b327151ce1e7ff203d02ef386006865",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5667",
"triggerID" : "f8cbaf4d4b327151ce1e7ff203d02ef386006865",
"triggerType" : "PUSH"
}, {
"hash" : "b5846b825b766f68e81d0587bf933a61a3805776",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5677",
"triggerID" : "b5846b825b766f68e81d0587bf933a61a3805776",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* Unknown: [CANCELED](TBD)
* f8cbaf4d4b327151ce1e7ff203d02ef386006865 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5667)
* b5846b825b766f68e81d0587bf933a61a3805776 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5677)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13063: [FLINK-15448] Add Node information to the ResourceId of TaskExecutor …
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13063:
URL: https://github.com/apache/flink/pull/13063#issuecomment-668948742
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c0c3cc811dba6b3ef30730c79ea1e12cd7c8c0a9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5183",
"triggerID" : "c0c3cc811dba6b3ef30730c79ea1e12cd7c8c0a9",
"triggerType" : "PUSH"
}, {
"hash" : "465d0515e5c66080ab1caae56d5f45a0a8b1f1bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5187",
"triggerID" : "465d0515e5c66080ab1caae56d5f45a0a8b1f1bf",
"triggerType" : "PUSH"
}, {
"hash" : "404e2e4a71aa8aaf4ff053f3a149243e8767b979",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5229",
"triggerID" : "404e2e4a71aa8aaf4ff053f3a149243e8767b979",
"triggerType" : "PUSH"
}, {
"hash" : "84ec3dd659a043853dcbce62a666924eaeffe2bb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5585",
"triggerID" : "84ec3dd659a043853dcbce62a666924eaeffe2bb",
"triggerType" : "PUSH"
}, {
"hash" : "edc382ac0f729db3adf67e17564cfc40e627753d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5607",
"triggerID" : "edc382ac0f729db3adf67e17564cfc40e627753d",
"triggerType" : "PUSH"
}, {
"hash" : "f8cbaf4d4b327151ce1e7ff203d02ef386006865",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5667",
"triggerID" : "675350868",
"triggerType" : "MANUAL"
}, {
"hash" : "f8cbaf4d4b327151ce1e7ff203d02ef386006865",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5667",
"triggerID" : "f8cbaf4d4b327151ce1e7ff203d02ef386006865",
"triggerType" : "PUSH"
}, {
"hash" : "b5846b825b766f68e81d0587bf933a61a3805776",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5677",
"triggerID" : "b5846b825b766f68e81d0587bf933a61a3805776",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "675350868",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* f8cbaf4d4b327151ce1e7ff203d02ef386006865 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5667)
* b5846b825b766f68e81d0587bf933a61a3805776 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5677)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13063: [FLINK-15448] Add Node information to the ResourceId of TaskExecutor …
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13063:
URL: https://github.com/apache/flink/pull/13063#issuecomment-668942816
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit c0c3cc811dba6b3ef30730c79ea1e12cd7c8c0a9 (Wed Aug 05 02:38:22 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] xintongsong closed pull request #13063: [FLINK-15448] Add Node information to the ResourceId of TaskExecutor …
Posted by GitBox <gi...@apache.org>.
xintongsong closed pull request #13063:
URL: https://github.com/apache/flink/pull/13063
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13063: [FLINK-15448] Add Node information to the ResourceId of TaskExecutor …
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13063:
URL: https://github.com/apache/flink/pull/13063#issuecomment-668948742
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c0c3cc811dba6b3ef30730c79ea1e12cd7c8c0a9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5183",
"triggerID" : "c0c3cc811dba6b3ef30730c79ea1e12cd7c8c0a9",
"triggerType" : "PUSH"
}, {
"hash" : "465d0515e5c66080ab1caae56d5f45a0a8b1f1bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5187",
"triggerID" : "465d0515e5c66080ab1caae56d5f45a0a8b1f1bf",
"triggerType" : "PUSH"
}, {
"hash" : "404e2e4a71aa8aaf4ff053f3a149243e8767b979",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5229",
"triggerID" : "404e2e4a71aa8aaf4ff053f3a149243e8767b979",
"triggerType" : "PUSH"
}, {
"hash" : "84ec3dd659a043853dcbce62a666924eaeffe2bb",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5585",
"triggerID" : "84ec3dd659a043853dcbce62a666924eaeffe2bb",
"triggerType" : "PUSH"
}, {
"hash" : "edc382ac0f729db3adf67e17564cfc40e627753d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "edc382ac0f729db3adf67e17564cfc40e627753d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 84ec3dd659a043853dcbce62a666924eaeffe2bb Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5585)
* edc382ac0f729db3adf67e17564cfc40e627753d UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13063: [FLINK-15448] Add Node information to the ResourceId of TaskExecutor …
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13063:
URL: https://github.com/apache/flink/pull/13063#issuecomment-668948742
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c0c3cc811dba6b3ef30730c79ea1e12cd7c8c0a9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5183",
"triggerID" : "c0c3cc811dba6b3ef30730c79ea1e12cd7c8c0a9",
"triggerType" : "PUSH"
}, {
"hash" : "465d0515e5c66080ab1caae56d5f45a0a8b1f1bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5187",
"triggerID" : "465d0515e5c66080ab1caae56d5f45a0a8b1f1bf",
"triggerType" : "PUSH"
}, {
"hash" : "404e2e4a71aa8aaf4ff053f3a149243e8767b979",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5229",
"triggerID" : "404e2e4a71aa8aaf4ff053f3a149243e8767b979",
"triggerType" : "PUSH"
}, {
"hash" : "84ec3dd659a043853dcbce62a666924eaeffe2bb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5585",
"triggerID" : "84ec3dd659a043853dcbce62a666924eaeffe2bb",
"triggerType" : "PUSH"
}, {
"hash" : "edc382ac0f729db3adf67e17564cfc40e627753d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5607",
"triggerID" : "edc382ac0f729db3adf67e17564cfc40e627753d",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "CANCELED",
"url" : "TBD",
"triggerID" : "675350868",
"triggerType" : "MANUAL"
}, {
"hash" : "f8cbaf4d4b327151ce1e7ff203d02ef386006865",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5667",
"triggerID" : "675350868",
"triggerType" : "MANUAL"
}, {
"hash" : "f8cbaf4d4b327151ce1e7ff203d02ef386006865",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5667",
"triggerID" : "f8cbaf4d4b327151ce1e7ff203d02ef386006865",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* Unknown: [CANCELED](TBD)
* f8cbaf4d4b327151ce1e7ff203d02ef386006865 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5667)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] KarmaGYZ commented on a change in pull request #13063: [FLINK-15448] Add Node information to the ResourceId of TaskExecutor …
Posted by GitBox <gi...@apache.org>.
KarmaGYZ commented on a change in pull request #13063:
URL: https://github.com/apache/flink/pull/13063#discussion_r472012017
##########
File path: flink-core/src/main/java/org/apache/flink/configuration/TaskManagerOptionsInternal.java
##########
@@ -0,0 +1,36 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.configuration;
+
+import org.apache.flink.annotation.Internal;
+
+import static org.apache.flink.configuration.ConfigOptions.key;
+
+/**
+ * TaskManager options that are not meant to be used by the user.
+ */
+@Internal
+public class TaskManagerOptionsInternal {
+
+ public static final ConfigOption<String> TASK_MANAGER_RESOURCE_ID_METADATA =
+ key("internal.taskmanager.resource-id.metadata")
Review comment:
I would avoid using "$" since the "$internal" would be treated as an environment variable by yarn.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13063: [FLINK-15448] Add Node information to the ResourceId of TaskExecutor …
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13063:
URL: https://github.com/apache/flink/pull/13063#issuecomment-668948742
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c0c3cc811dba6b3ef30730c79ea1e12cd7c8c0a9",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5183",
"triggerID" : "c0c3cc811dba6b3ef30730c79ea1e12cd7c8c0a9",
"triggerType" : "PUSH"
}, {
"hash" : "465d0515e5c66080ab1caae56d5f45a0a8b1f1bf",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5187",
"triggerID" : "465d0515e5c66080ab1caae56d5f45a0a8b1f1bf",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c0c3cc811dba6b3ef30730c79ea1e12cd7c8c0a9 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5183)
* 465d0515e5c66080ab1caae56d5f45a0a8b1f1bf Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5187)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13063: [FLINK-15448] Add Node information to the ResourceId of TaskExecutor …
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13063:
URL: https://github.com/apache/flink/pull/13063#issuecomment-668948742
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c0c3cc811dba6b3ef30730c79ea1e12cd7c8c0a9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5183",
"triggerID" : "c0c3cc811dba6b3ef30730c79ea1e12cd7c8c0a9",
"triggerType" : "PUSH"
}, {
"hash" : "465d0515e5c66080ab1caae56d5f45a0a8b1f1bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5187",
"triggerID" : "465d0515e5c66080ab1caae56d5f45a0a8b1f1bf",
"triggerType" : "PUSH"
}, {
"hash" : "404e2e4a71aa8aaf4ff053f3a149243e8767b979",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5229",
"triggerID" : "404e2e4a71aa8aaf4ff053f3a149243e8767b979",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 404e2e4a71aa8aaf4ff053f3a149243e8767b979 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5229)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13063: [FLINK-15448] Add Node information to the ResourceId of TaskExecutor …
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13063:
URL: https://github.com/apache/flink/pull/13063#issuecomment-668948742
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c0c3cc811dba6b3ef30730c79ea1e12cd7c8c0a9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5183",
"triggerID" : "c0c3cc811dba6b3ef30730c79ea1e12cd7c8c0a9",
"triggerType" : "PUSH"
}, {
"hash" : "465d0515e5c66080ab1caae56d5f45a0a8b1f1bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5187",
"triggerID" : "465d0515e5c66080ab1caae56d5f45a0a8b1f1bf",
"triggerType" : "PUSH"
}, {
"hash" : "404e2e4a71aa8aaf4ff053f3a149243e8767b979",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5229",
"triggerID" : "404e2e4a71aa8aaf4ff053f3a149243e8767b979",
"triggerType" : "PUSH"
}, {
"hash" : "84ec3dd659a043853dcbce62a666924eaeffe2bb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5585",
"triggerID" : "84ec3dd659a043853dcbce62a666924eaeffe2bb",
"triggerType" : "PUSH"
}, {
"hash" : "edc382ac0f729db3adf67e17564cfc40e627753d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5607",
"triggerID" : "edc382ac0f729db3adf67e17564cfc40e627753d",
"triggerType" : "PUSH"
}, {
"hash" : "f8cbaf4d4b327151ce1e7ff203d02ef386006865",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5667",
"triggerID" : "675350868",
"triggerType" : "MANUAL"
}, {
"hash" : "f8cbaf4d4b327151ce1e7ff203d02ef386006865",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5667",
"triggerID" : "f8cbaf4d4b327151ce1e7ff203d02ef386006865",
"triggerType" : "PUSH"
}, {
"hash" : "b5846b825b766f68e81d0587bf933a61a3805776",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5677",
"triggerID" : "b5846b825b766f68e81d0587bf933a61a3805776",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "675350868",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* b5846b825b766f68e81d0587bf933a61a3805776 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5677)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13063: [FLINK-15448] Add Node information to the ResourceId of TaskExecutor …
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13063:
URL: https://github.com/apache/flink/pull/13063#issuecomment-668948742
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c0c3cc811dba6b3ef30730c79ea1e12cd7c8c0a9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5183",
"triggerID" : "c0c3cc811dba6b3ef30730c79ea1e12cd7c8c0a9",
"triggerType" : "PUSH"
}, {
"hash" : "465d0515e5c66080ab1caae56d5f45a0a8b1f1bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5187",
"triggerID" : "465d0515e5c66080ab1caae56d5f45a0a8b1f1bf",
"triggerType" : "PUSH"
}, {
"hash" : "404e2e4a71aa8aaf4ff053f3a149243e8767b979",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5229",
"triggerID" : "404e2e4a71aa8aaf4ff053f3a149243e8767b979",
"triggerType" : "PUSH"
}, {
"hash" : "84ec3dd659a043853dcbce62a666924eaeffe2bb",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5585",
"triggerID" : "84ec3dd659a043853dcbce62a666924eaeffe2bb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 404e2e4a71aa8aaf4ff053f3a149243e8767b979 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5229)
* 84ec3dd659a043853dcbce62a666924eaeffe2bb Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5585)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] xintongsong commented on a change in pull request #13063: [FLINK-15448] Add Node information to the ResourceId of TaskExecutor …
Posted by GitBox <gi...@apache.org>.
xintongsong commented on a change in pull request #13063:
URL: https://github.com/apache/flink/pull/13063#discussion_r472019373
##########
File path: flink-core/src/main/java/org/apache/flink/configuration/TaskManagerOptionsInternal.java
##########
@@ -0,0 +1,36 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.configuration;
+
+import org.apache.flink.annotation.Internal;
+
+import static org.apache.flink.configuration.ConfigOptions.key;
+
+/**
+ * TaskManager options that are not meant to be used by the user.
+ */
+@Internal
+public class TaskManagerOptionsInternal {
+
+ public static final ConfigOption<String> TASK_MANAGER_RESOURCE_ID_METADATA =
+ key("internal.taskmanager.resource-id.metadata")
Review comment:
Ok, make sense.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13063: [FLINK-15448] Add Node information to the ResourceId of TaskExecutor …
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13063:
URL: https://github.com/apache/flink/pull/13063#issuecomment-668948742
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c0c3cc811dba6b3ef30730c79ea1e12cd7c8c0a9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5183",
"triggerID" : "c0c3cc811dba6b3ef30730c79ea1e12cd7c8c0a9",
"triggerType" : "PUSH"
}, {
"hash" : "465d0515e5c66080ab1caae56d5f45a0a8b1f1bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5187",
"triggerID" : "465d0515e5c66080ab1caae56d5f45a0a8b1f1bf",
"triggerType" : "PUSH"
}, {
"hash" : "404e2e4a71aa8aaf4ff053f3a149243e8767b979",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5229",
"triggerID" : "404e2e4a71aa8aaf4ff053f3a149243e8767b979",
"triggerType" : "PUSH"
}, {
"hash" : "84ec3dd659a043853dcbce62a666924eaeffe2bb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5585",
"triggerID" : "84ec3dd659a043853dcbce62a666924eaeffe2bb",
"triggerType" : "PUSH"
}, {
"hash" : "edc382ac0f729db3adf67e17564cfc40e627753d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5607",
"triggerID" : "edc382ac0f729db3adf67e17564cfc40e627753d",
"triggerType" : "PUSH"
}, {
"hash" : "f8cbaf4d4b327151ce1e7ff203d02ef386006865",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "675350868",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "CANCELED",
"url" : "TBD",
"triggerID" : "675350868",
"triggerType" : "MANUAL"
}, {
"hash" : "f8cbaf4d4b327151ce1e7ff203d02ef386006865",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f8cbaf4d4b327151ce1e7ff203d02ef386006865",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* Unknown: [CANCELED](TBD)
* f8cbaf4d4b327151ce1e7ff203d02ef386006865 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13063: [FLINK-15448] Add Node information to the ResourceId of TaskExecutor …
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13063:
URL: https://github.com/apache/flink/pull/13063#issuecomment-668948742
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c0c3cc811dba6b3ef30730c79ea1e12cd7c8c0a9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5183",
"triggerID" : "c0c3cc811dba6b3ef30730c79ea1e12cd7c8c0a9",
"triggerType" : "PUSH"
}, {
"hash" : "465d0515e5c66080ab1caae56d5f45a0a8b1f1bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5187",
"triggerID" : "465d0515e5c66080ab1caae56d5f45a0a8b1f1bf",
"triggerType" : "PUSH"
}, {
"hash" : "404e2e4a71aa8aaf4ff053f3a149243e8767b979",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5229",
"triggerID" : "404e2e4a71aa8aaf4ff053f3a149243e8767b979",
"triggerType" : "PUSH"
}, {
"hash" : "84ec3dd659a043853dcbce62a666924eaeffe2bb",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "84ec3dd659a043853dcbce62a666924eaeffe2bb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 404e2e4a71aa8aaf4ff053f3a149243e8767b979 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5229)
* 84ec3dd659a043853dcbce62a666924eaeffe2bb UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org