You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2019/07/31 17:46:20 UTC
[GitHub] [incubator-iceberg] vgankidi commented on issue #334: Fix
truncateStringMax in UnicodeUtil.
vgankidi commented on issue #334: Fix truncateStringMax in UnicodeUtil.
URL: https://github.com/apache/incubator-iceberg/pull/334#issuecomment-516951217
Also with the fix in #329, output of `truncateStringMax(Literal.of(test7), 2)` equals `test7_1_expected` instead of `test7_2_expected`.`codePointAt` gives the expected result if the index points to a high surrogate and the following character is a low surrogate. It computes the code point for the surrogate pair. Otherwise it returns the codepoint of the character in the given index as is.
@ikosyanenko Can you test your long input in #328 with this fix as well? Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org