You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@metron.apache.org by danieljue <gi...@git.apache.org> on 2016/09/26 16:07:41 UTC
[GitHub] incubator-metron pull request #275: Fixed package error.
GitHub user danieljue opened a pull request:
https://github.com/apache/incubator-metron/pull/275
Fixed package error.
Class had the wrong package, causing compilation error.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Cognami/incubator-metron master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-metron/pull/275.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #275
----
commit 6d54f7b09427a1859d073303e22ace64e42e21b3
Author: Daniel Jue <dj...@cognami.com>
Date: 2016-09-26T16:06:39Z
Fixed package error.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-metron issue #275: METRON-459 Bad file location for org.apache.met...
Posted by danieljue <gi...@git.apache.org>.
Github user danieljue commented on the issue:
https://github.com/apache/incubator-metron/pull/275
Sorry, while fixing 451 I neglected to put 451's change in it's own branch. Reverted the 451 fix from this PR and then cherry picked 451's fix into it's own branch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-metron pull request #275: METRON-459 Bad file location for org.apa...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-metron/pull/275
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-metron issue #275: Fixed package error.
Posted by nickwallen <gi...@git.apache.org>.
Github user nickwallen commented on the issue:
https://github.com/apache/incubator-metron/pull/275
Hi @danieljue - Can you send in the compile error that you are seeing? I just want to make sure I can replicate it. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-metron issue #275: Fixed package error.
Posted by cestella <gi...@git.apache.org>.
Github user cestella commented on the issue:
https://github.com/apache/incubator-metron/pull/275
maven also builds it..that was the baffling thing to me.
On Mon, Sep 26, 2016 at 4:18 PM, Nick Allen <no...@github.com>
wrote:
> For me, master builds and all integration tests pass. Also, I don't see
> any failures in Travis CI. But when I specifically open up the file in
> Intellij, it does show an error indicating that the source file location
> does not match the package name.
>
> Would be just super, if CI broke when our code is broke. :)
>
> \u2014
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/incubator-metron/pull/275#issuecomment-249684997>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AAg-x0qvAuqU7oo63Ms2AMT6DsLKvaQwks5quCiegaJpZM4KGtN2>
> .
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-metron issue #275: Fixed package error.
Posted by cestella <gi...@git.apache.org>.
Github user cestella commented on the issue:
https://github.com/apache/incubator-metron/pull/275
I'm +1 on the change; good catch. Could you please make a JIRA for this and rename this PR to ${JIRA}: ${JIRA DESCRIPTION}. For instance, if the JIRA is METRON-411 adn the description is "Fixed package error", could you call the title "METRON-411: Fixed package error"?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-metron issue #275: METRON-459 Bad file location for org.apache.met...
Posted by nickwallen <gi...@git.apache.org>.
Github user nickwallen commented on the issue:
https://github.com/apache/incubator-metron/pull/275
This one is good to go. Thank you for the contribution! \U0001f44d
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-metron issue #275: Fixed package error.
Posted by nickwallen <gi...@git.apache.org>.
Github user nickwallen commented on the issue:
https://github.com/apache/incubator-metron/pull/275
For me, master builds and all integration tests pass. Also, I don't see any failures in Travis CI. But when I specifically open up the file in Intellij, it does show an error indicating that the source file location does not match the package name.
Would be just super, if CI broke when our code is broke. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-metron issue #275: METRON-459 Bad file location for org.apache.met...
Posted by danieljue <gi...@git.apache.org>.
Github user danieljue commented on the issue:
https://github.com/apache/incubator-metron/pull/275
So basically went from metron.pcap to metron.spout.pcap
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-metron issue #275: METRON-459 Bad file location for org.apache.met...
Posted by danieljue <gi...@git.apache.org>.
Github user danieljue commented on the issue:
https://github.com/apache/incubator-metron/pull/275
https://issues.apache.org/jira/browse/METRON-459
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-metron issue #275: METRON-459 Bad file location for org.apache.met...
Posted by dlyle65535 <gi...@git.apache.org>.
Github user dlyle65535 commented on the issue:
https://github.com/apache/incubator-metron/pull/275
+1 - Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-metron issue #275: Fixed package error.
Posted by nickwallen <gi...@git.apache.org>.
Github user nickwallen commented on the issue:
https://github.com/apache/incubator-metron/pull/275
Seeing [unsubstantiated](http://stackoverflow.com/questions/9416017/package-structure-should-be-same-as-directory-structure-in-java-always) [references](http://stackoverflow.com/questions/8395916/package-name-is-different-than-the-folder-structure-but-still-java-code-compiles) on the interwebs that enforcement of source code location to package name is optional. Fun fact of the day.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-metron issue #275: METRON-459 Bad file location for org.apache.met...
Posted by nickwallen <gi...@git.apache.org>.
Github user nickwallen commented on the issue:
https://github.com/apache/incubator-metron/pull/275
+1 Hoping that if we add more strict checking of our source code via checkstyle or something similar, we might catch this type of issue in the future. But that can be left for another day.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---