You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Jinmei Liao <ji...@pivotal.io> on 2016/04/06 21:43:09 UTC

Review Request 45831: GEODE-17: ensure gfsh-over-http tests are enabled

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45831/
-----------------------------------------------------------

Review request for geode.


Repository: geode


Description
-------

GEODE-17: ensure gfsh-over-http tests are enabled


Diffs
-----

  geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/CliCommandTestBase.java 55f55561b41f967b0e63066a6067335317036749 
  geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/CommandOverHttpTests.java PRE-CREATION 

Diff: https://reviews.apache.org/r/45831/diff/


Testing
-------


Thanks,

Jinmei Liao


Re: Review Request 45831: GEODE-17: ensure gfsh-over-http tests are enabled

Posted by Jens Deppe <jd...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45831/#review127462
-----------------------------------------------------------


Ship it!




Ship It!

- Jens Deppe


On April 6, 2016, 7:44 p.m., Jinmei Liao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45831/
> -----------------------------------------------------------
> 
> (Updated April 6, 2016, 7:44 p.m.)
> 
> 
> Review request for geode, Jens Deppe and Kirk Lund.
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> GEODE-17: ensure gfsh-over-http tests are enabled
> 
> This change is on top of the feature/GEODE-1162 branch where Kirk converted all cli command tests into Junit4.
> 
> 
> Diffs
> -----
> 
>   geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/CliCommandTestBase.java 55f55561b41f967b0e63066a6067335317036749 
>   geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/CommandOverHttpTests.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/45831/diff/
> 
> 
> Testing
> -------
> 
> The newly created suite.
> 
> 
> Thanks,
> 
> Jinmei Liao
> 
>


Re: Review Request 45831: GEODE-17: ensure gfsh-over-http tests are enabled

Posted by Jinmei Liao <ji...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45831/
-----------------------------------------------------------

(Updated April 6, 2016, 7:44 p.m.)


Review request for geode, Jens Deppe and Kirk Lund.


Repository: geode


Description (updated)
-------

GEODE-17: ensure gfsh-over-http tests are enabled

This change is on top of the feature/GEODE-1162 branch where Kirk converted all cli command tests into Junit4.


Diffs
-----

  geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/CliCommandTestBase.java 55f55561b41f967b0e63066a6067335317036749 
  geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/CommandOverHttpTests.java PRE-CREATION 

Diff: https://reviews.apache.org/r/45831/diff/


Testing (updated)
-------

The newly created suite.


Thanks,

Jinmei Liao