You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/06/17 05:52:19 UTC
[GitHub] [shardingsphere] menghaoranss opened a new pull request #6086: Support heart beat for sharding jdbc with spring namespace
menghaoranss opened a new pull request #6086:
URL: https://github.com/apache/shardingsphere/pull/6086
For #5885 .
Changes proposed in this pull request:
- Support heart beat for sharding jdbc with spring namespace
- Fixes namespace tag name
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] kimmking merged pull request #6086: Support heart beat for sharding jdbc with spring namespace
Posted by GitBox <gi...@apache.org>.
kimmking merged pull request #6086:
URL: https://github.com/apache/shardingsphere/pull/6086
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] menghaoranss commented on a change in pull request #6086: Support heart beat for sharding jdbc with spring namespace
Posted by GitBox <gi...@apache.org>.
menghaoranss commented on a change in pull request #6086:
URL: https://github.com/apache/shardingsphere/pull/6086#discussion_r441327560
##########
File path: shardingsphere-jdbc/shardingsphere-jdbc-spring/shardingsphere-jdbc-orchestration-spring/shardingsphere-jdbc-orchestration-spring-namespace/src/main/java/org/apache/shardingsphere/spring/namespace/orchestration/handler/ClusterNamespaceHandler.java
##########
@@ -0,0 +1,32 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.spring.namespace.orchestration.handler;
+
+import org.apache.shardingsphere.spring.namespace.orchestration.constants.ClusterBeanDefinitionTag;
+import org.apache.shardingsphere.spring.namespace.orchestration.parser.ClusterBeanDefinitionParser;
+import org.springframework.beans.factory.xml.NamespaceHandlerSupport;
+
+/**
+ * Cluster spring namespace handler.
+ */
+public final class ClusterNamespaceHandler extends NamespaceHandlerSupport {
+ @Override
Review comment:
I will fix it , thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] dongzl commented on a change in pull request #6086: Support heart beat for sharding jdbc with spring namespace
Posted by GitBox <gi...@apache.org>.
dongzl commented on a change in pull request #6086:
URL: https://github.com/apache/shardingsphere/pull/6086#discussion_r441299153
##########
File path: shardingsphere-jdbc/shardingsphere-jdbc-spring/shardingsphere-jdbc-orchestration-spring/shardingsphere-jdbc-orchestration-spring-namespace/src/main/java/org/apache/shardingsphere/spring/namespace/orchestration/handler/ClusterNamespaceHandler.java
##########
@@ -0,0 +1,32 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.spring.namespace.orchestration.handler;
+
+import org.apache.shardingsphere.spring.namespace.orchestration.constants.ClusterBeanDefinitionTag;
+import org.apache.shardingsphere.spring.namespace.orchestration.parser.ClusterBeanDefinitionParser;
+import org.springframework.beans.factory.xml.NamespaceHandlerSupport;
+
+/**
+ * Cluster spring namespace handler.
+ */
+public final class ClusterNamespaceHandler extends NamespaceHandlerSupport {
+ @Override
Review comment:
There should be a blank line.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org