You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Harikrishna Patnala <ha...@citrix.com> on 2013/04/25 09:54:12 UTC
Review Request: CLOUDSTACK-2180: restoreVirtualMachine returns no password
if the template is password enabled
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10772/
-----------------------------------------------------------
Review request for cloudstack, Abhinandan Prateek and Koushik Das.
Description
-------
CLOUDSTACK-2180: restoreVirtualMachine returns no password
if the template is password enabled
New password is generated as part of restore vm(passwd enabled template) and send new password on VR
This addresses bug CLOUDSTACK-2180.
Diffs
-----
api/src/com/cloud/vm/UserVmService.java 7e89cd3
server/src/com/cloud/vm/UserVmManagerImpl.java ebc5757
server/test/com/cloud/vm/MockUserVmManagerImpl.java d886fd8
server/test/com/cloud/vm/UserVmManagerTest.java e5e2ff2
Diff: https://reviews.apache.org/r/10772/diff/
Testing
-------
Thanks,
Harikrishna Patnala
Re: Review Request: CLOUDSTACK-2180: restoreVirtualMachine returns no
password if the template is password enabled
Posted by Abhinandan Prateek <ap...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10772/#review19996
-----------------------------------------------------------
Ship it!
Ship It!
- Abhinandan Prateek
On April 25, 2013, 9:05 a.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10772/
> -----------------------------------------------------------
>
> (Updated April 25, 2013, 9:05 a.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek, Koushik Das, and Wei Zhou.
>
>
> Description
> -------
>
> CLOUDSTACK-2180: restoreVirtualMachine returns no password
> if the template is password enabled
>
> New password is generated as part of restore vm(passwd enabled template) and send new password on VR
>
>
> This addresses bug CLOUDSTACK-2180.
>
>
> Diffs
> -----
>
> api/src/com/cloud/vm/UserVmService.java 7e89cd3
> server/src/com/cloud/vm/UserVmManagerImpl.java ebc5757
> server/test/com/cloud/vm/MockUserVmManagerImpl.java d886fd8
> server/test/com/cloud/vm/UserVmManagerTest.java e5e2ff2
>
> Diff: https://reviews.apache.org/r/10772/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Harikrishna Patnala
>
>
Re: Review Request: CLOUDSTACK-2180: restoreVirtualMachine returns no
password if the template is password enabled
Posted by Harikrishna Patnala <ha...@citrix.com>.
> On April 25, 2013, 9:34 a.m., Prasanna Santhanam wrote:
> > Added additional reviewer
Both patches are same except the unit tests that we added on master.
- Harikrishna
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10772/#review19697
-----------------------------------------------------------
On April 25, 2013, 9:05 a.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10772/
> -----------------------------------------------------------
>
> (Updated April 25, 2013, 9:05 a.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek, Koushik Das, and Wei Zhou.
>
>
> Description
> -------
>
> CLOUDSTACK-2180: restoreVirtualMachine returns no password
> if the template is password enabled
>
> New password is generated as part of restore vm(passwd enabled template) and send new password on VR
>
>
> This addresses bug CLOUDSTACK-2180.
>
>
> Diffs
> -----
>
> api/src/com/cloud/vm/UserVmService.java 7e89cd3
> server/src/com/cloud/vm/UserVmManagerImpl.java ebc5757
> server/test/com/cloud/vm/MockUserVmManagerImpl.java d886fd8
> server/test/com/cloud/vm/UserVmManagerTest.java e5e2ff2
>
> Diff: https://reviews.apache.org/r/10772/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Harikrishna Patnala
>
>
Re: Review Request: CLOUDSTACK-2180: restoreVirtualMachine returns no
password if the template is password enabled
Posted by Prasanna Santhanam <ts...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10772/#review19697
-----------------------------------------------------------
Added additional reviewer
- Prasanna Santhanam
On April 25, 2013, 9:05 a.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10772/
> -----------------------------------------------------------
>
> (Updated April 25, 2013, 9:05 a.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek, Koushik Das, and Wei Zhou.
>
>
> Description
> -------
>
> CLOUDSTACK-2180: restoreVirtualMachine returns no password
> if the template is password enabled
>
> New password is generated as part of restore vm(passwd enabled template) and send new password on VR
>
>
> This addresses bug CLOUDSTACK-2180.
>
>
> Diffs
> -----
>
> api/src/com/cloud/vm/UserVmService.java 7e89cd3
> server/src/com/cloud/vm/UserVmManagerImpl.java ebc5757
> server/test/com/cloud/vm/MockUserVmManagerImpl.java d886fd8
> server/test/com/cloud/vm/UserVmManagerTest.java e5e2ff2
>
> Diff: https://reviews.apache.org/r/10772/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Harikrishna Patnala
>
>
Re: Review Request: CLOUDSTACK-2180: restoreVirtualMachine returns no
password if the template is password enabled
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10772/#review19997
-----------------------------------------------------------
Commit 1cb9bd531f4eaaef3a99608ab77cba1851b37e42 in branch refs/heads/master from Abhinandan Prateek <ap...@apache.org>
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=1cb9bd5 ]
CLOUDSTACK-2180: restoreVirtualMachine returns no password if the template is password enabled
New password is generated as part of restore vm(passwd enabled template) and send new password on VR
Signed-off-by: Abhinandan Prateek <ap...@apache.org>
- ASF Subversion and Git Services
On April 25, 2013, 9:05 a.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10772/
> -----------------------------------------------------------
>
> (Updated April 25, 2013, 9:05 a.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek, Koushik Das, and Wei Zhou.
>
>
> Description
> -------
>
> CLOUDSTACK-2180: restoreVirtualMachine returns no password
> if the template is password enabled
>
> New password is generated as part of restore vm(passwd enabled template) and send new password on VR
>
>
> This addresses bug CLOUDSTACK-2180.
>
>
> Diffs
> -----
>
> api/src/com/cloud/vm/UserVmService.java 7e89cd3
> server/src/com/cloud/vm/UserVmManagerImpl.java ebc5757
> server/test/com/cloud/vm/MockUserVmManagerImpl.java d886fd8
> server/test/com/cloud/vm/UserVmManagerTest.java e5e2ff2
>
> Diff: https://reviews.apache.org/r/10772/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Harikrishna Patnala
>
>
Re: Review Request: CLOUDSTACK-2180: restoreVirtualMachine returns no
password if the template is password enabled
Posted by Prasanna Santhanam <ts...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10772/
-----------------------------------------------------------
(Updated April 25, 2013, 9:05 a.m.)
Review request for cloudstack, Abhinandan Prateek, Koushik Das, and Wei Zhou.
Changes
-------
This has some more detail than the similar: https://reviews.apache.org/r/9539/. Can you explain the additional detail? Thanks
Description
-------
CLOUDSTACK-2180: restoreVirtualMachine returns no password
if the template is password enabled
New password is generated as part of restore vm(passwd enabled template) and send new password on VR
This addresses bug CLOUDSTACK-2180.
Diffs
-----
api/src/com/cloud/vm/UserVmService.java 7e89cd3
server/src/com/cloud/vm/UserVmManagerImpl.java ebc5757
server/test/com/cloud/vm/MockUserVmManagerImpl.java d886fd8
server/test/com/cloud/vm/UserVmManagerTest.java e5e2ff2
Diff: https://reviews.apache.org/r/10772/diff/
Testing
-------
Thanks,
Harikrishna Patnala
Re: Review Request: CLOUDSTACK-2180: restoreVirtualMachine returns no
password if the template is password enabled
Posted by Harikrishna Patnala <ha...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10772/
-----------------------------------------------------------
(Updated April 25, 2013, 8:54 a.m.)
Review request for cloudstack, Abhinandan Prateek and Koushik Das.
Description
-------
CLOUDSTACK-2180: restoreVirtualMachine returns no password
if the template is password enabled
New password is generated as part of restore vm(passwd enabled template) and send new password on VR
This addresses bug CLOUDSTACK-2180.
Diffs
-----
api/src/com/cloud/vm/UserVmService.java 7e89cd3
server/src/com/cloud/vm/UserVmManagerImpl.java ebc5757
server/test/com/cloud/vm/MockUserVmManagerImpl.java d886fd8
server/test/com/cloud/vm/UserVmManagerTest.java e5e2ff2
Diff: https://reviews.apache.org/r/10772/diff/
Testing
-------
Thanks,
Harikrishna Patnala
Re: Review Request: CLOUDSTACK-2180: restoreVirtualMachine returns no
password if the template is password enabled
Posted by Harikrishna Patnala <ha...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10772/
-----------------------------------------------------------
(Updated April 25, 2013, 8:54 a.m.)
Review request for cloudstack, Abhinandan Prateek and Koushik Das.
Description
-------
CLOUDSTACK-2180: restoreVirtualMachine returns no password
if the template is password enabled
New password is generated as part of restore vm(passwd enabled template) and send new password on VR
This addresses bug CLOUDSTACK-2180.
Diffs
-----
api/src/com/cloud/vm/UserVmService.java 7e89cd3
server/src/com/cloud/vm/UserVmManagerImpl.java ebc5757
server/test/com/cloud/vm/MockUserVmManagerImpl.java d886fd8
server/test/com/cloud/vm/UserVmManagerTest.java e5e2ff2
Diff: https://reviews.apache.org/r/10772/diff/
Testing
-------
Thanks,
Harikrishna Patnala