You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "xitep (via GitHub)" <gi...@apache.org> on 2025/11/17 19:55:00 UTC
[I] Track span of DISTINCT [datafusion-sqlparser-rs]
xitep opened a new issue, #2099:
URL: https://github.com/apache/datafusion-sqlparser-rs/issues/2099
Adding span information to the AST node of a `DISTINCT` will require changing its structure. As per #1548 I'm opening a ticket for this.
### Motivation
As described in #1995, or in [oracle's docs](https://docs.oracle.com/en/database/oracle/oracle-database/19/tgsql/influencing-the-optimizer.html#GUID-B198573A-C64B-4071-9CD8-738355A20DD7) optimiser hints can be placed right after the `SELECT` (and before a possible `DISTINCT`.) (Today, parsing the comment out of the original SQL source can be done manually by consuming the characters right after the SELECT since its AST node has already a `select_token` telling the keywords ends. Ideally we'd also have the next token's start.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Track span of DISTINCT [datafusion-sqlparser-rs]
Posted by "xitep (via GitHub)" <gi...@apache.org>.
xitep commented on issue #2099:
URL: https://github.com/apache/datafusion-sqlparser-rs/issues/2099#issuecomment-3742497295
i think a more convenient approach would be to expose hints in the AST as first class citizens (just as requested in #1995). i'm closing this issue, as it seems rather non-systematic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Track span of DISTINCT [datafusion-sqlparser-rs]
Posted by "xitep (via GitHub)" <gi...@apache.org>.
xitep closed issue #2099: Track span of DISTINCT
URL: https://github.com/apache/datafusion-sqlparser-rs/issues/2099
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org