You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/04/15 15:44:51 UTC
[GitHub] [spark] cloud-fan opened a new pull request #32192: [SPARK-34720][SQL] MERGE ... UPDATE/INSERT * should do by-name resolution
cloud-fan opened a new pull request #32192:
URL: https://github.com/apache/spark/pull/32192
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
In Spark, we have an extension in the MERGE syntax: INSERT/UPDATE *. This is not from ANSI standard or any other mainstream databases, so we need to define the behaviors by our own.
The behavior today is very weird: assume the source table has `n1` columns, target table has `n2` columns. We generate the assignments by taking the first `min(n1, n2)` columns from source & target tables and pairing them by ordinal.
This PR proposes a more reasonable behavior: take all the columns from target table as keys, and find the corresponding columns from source table by name as values.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
Fix the MEREG INSERT/UPDATE * to be more user-friendly and easy to do schema evolution.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
Yes, but MERGE is only supported by very few data sources.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
new tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32192: [SPARK-34720][SQL] MERGE ... UPDATE/INSERT * should do by-name resolution
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32192:
URL: https://github.com/apache/spark/pull/32192#issuecomment-820572097
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32192: [SPARK-34720][SQL] MERGE ... UPDATE/INSERT * should do by-name resolution
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32192:
URL: https://github.com/apache/spark/pull/32192#issuecomment-820704607
**[Test build #137424 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137424/testReport)** for PR 32192 at commit [`ed828c3`](https://github.com/apache/spark/commit/ed828c3cfbd6727135c0bb4afce94d5945192d70).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32192: [SPARK-34720][SQL] MERGE ... UPDATE/INSERT * should do by-name resolution
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32192:
URL: https://github.com/apache/spark/pull/32192#issuecomment-834700848
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138256/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32192: [SPARK-34720][SQL] MERGE ... UPDATE/INSERT * should do by-name resolution
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32192:
URL: https://github.com/apache/spark/pull/32192#issuecomment-820533590
**[Test build #137424 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137424/testReport)** for PR 32192 at commit [`ed828c3`](https://github.com/apache/spark/commit/ed828c3cfbd6727135c0bb4afce94d5945192d70).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32192: [SPARK-34720][SQL] MERGE ... UPDATE/INSERT * should do by-name resolution
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32192:
URL: https://github.com/apache/spark/pull/32192#issuecomment-834697832
**[Test build #138256 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138256/testReport)** for PR 32192 at commit [`19d77ea`](https://github.com/apache/spark/commit/19d77eadfb176a77c110d654b6ca9aa78ee4d6a9).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #32192: [SPARK-34720][SQL] MERGE ... UPDATE/INSERT * should do by-name resolution
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #32192:
URL: https://github.com/apache/spark/pull/32192#issuecomment-820564608
cc @aokolnychyi and @RussellSpitzer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #32192: [SPARK-34720][SQL] MERGE ... UPDATE/INSERT * should do by-name resolution
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #32192:
URL: https://github.com/apache/spark/pull/32192#issuecomment-836301884
Got it for the further explanation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #32192: [SPARK-34720][SQL] MERGE ... UPDATE/INSERT * should do by-name resolution
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #32192:
URL: https://github.com/apache/spark/pull/32192#discussion_r614189392
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
##########
@@ -1490,14 +1490,18 @@ class Analyzer(override val catalogManager: CatalogManager)
case UpdateAction(updateCondition, assignments) =>
val resolvedUpdateCondition = updateCondition.map(
resolveExpressionByPlanChildren(_, m))
- // The update value can access columns from both target and source tables.
UpdateAction(
resolvedUpdateCondition,
- resolveAssignments(Some(assignments), m, resolveValuesWithSourceOnly = false))
+ // The update value can access columns from both target and source tables.
+ resolveAssignments(assignments, m, resolveValuesWithSourceOnly = false))
case UpdateStarAction(updateCondition) =>
+ val assignments = targetTable.output.map { attr =>
+ Assignment(attr, UnresolvedAttribute(Seq(attr.name)))
+ }
UpdateAction(
updateCondition.map(resolveExpressionByPlanChildren(_, m)),
- resolveAssignments(assignments = None, m, resolveValuesWithSourceOnly = false))
+ // For UPDATE *, the value must from source table.
+ resolveAssignments(assignments, m, resolveValuesWithSourceOnly = true))
Review comment:
To avoid resolving `UpdateAction` again with `resolveValuesWithSourceOnly = false` in the next analysis round, I added `resolveMergeExprOrFail` to fail earlier if an attribute can't be resolved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32192: [SPARK-34720][SQL] MERGE ... UPDATE/INSERT * should do by-name resolution
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32192:
URL: https://github.com/apache/spark/pull/32192#issuecomment-820572600
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42002/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] commented on pull request #32192: [SPARK-34720][SQL] MERGE ... UPDATE/INSERT * should do by-name resolution
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #32192:
URL: https://github.com/apache/spark/pull/32192#issuecomment-820533452
**[Test build #752552040](https://github.com/cloud-fan/spark/actions/runs/752552040)** for PR 32192 at commit [`ed828c3`](https://github.com/cloud-fan/spark/commit/ed828c3cfbd6727135c0bb4afce94d5945192d70).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32192: [SPARK-34720][SQL] MERGE ... UPDATE/INSERT * should do by-name resolution
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32192:
URL: https://github.com/apache/spark/pull/32192#issuecomment-834431746
**[Test build #138256 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138256/testReport)** for PR 32192 at commit [`19d77ea`](https://github.com/apache/spark/commit/19d77eadfb176a77c110d654b6ca9aa78ee4d6a9).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #32192: [SPARK-34720][SQL] MERGE ... UPDATE/INSERT * should do by-name resolution
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #32192:
URL: https://github.com/apache/spark/pull/32192#issuecomment-840537646
thanks for the review, merging to master!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #32192: [SPARK-34720][SQL] MERGE ... UPDATE/INSERT * should do by-name resolution
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #32192:
URL: https://github.com/apache/spark/pull/32192
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32192: [SPARK-34720][SQL] MERGE ... UPDATE/INSERT * should do by-name resolution
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32192:
URL: https://github.com/apache/spark/pull/32192#issuecomment-834491087
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42778/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32192: [SPARK-34720][SQL] MERGE ... UPDATE/INSERT * should do by-name resolution
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32192:
URL: https://github.com/apache/spark/pull/32192#issuecomment-834700848
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138256/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32192: [SPARK-34720][SQL] MERGE ... UPDATE/INSERT * should do by-name resolution
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32192:
URL: https://github.com/apache/spark/pull/32192#issuecomment-820533590
**[Test build #137424 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137424/testReport)** for PR 32192 at commit [`ed828c3`](https://github.com/apache/spark/commit/ed828c3cfbd6727135c0bb4afce94d5945192d70).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] RussellSpitzer commented on pull request #32192: [SPARK-34720][SQL] MERGE ... UPDATE/INSERT * should do by-name resolution
Posted by GitBox <gi...@apache.org>.
RussellSpitzer commented on pull request #32192:
URL: https://github.com/apache/spark/pull/32192#issuecomment-820568702
I think this is a great idea, I see folks hitting this extremely frequently. It does feel like it would be a rather large change to the current behavior though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32192: [SPARK-34720][SQL] MERGE ... UPDATE/INSERT * should do by-name resolution
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32192:
URL: https://github.com/apache/spark/pull/32192#issuecomment-820717524
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137424/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32192: [SPARK-34720][SQL] MERGE ... UPDATE/INSERT * should do by-name resolution
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32192:
URL: https://github.com/apache/spark/pull/32192#issuecomment-820717524
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137424/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32192: [SPARK-34720][SQL] MERGE ... UPDATE/INSERT * should do by-name resolution
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32192:
URL: https://github.com/apache/spark/pull/32192#issuecomment-820572600
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42002/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #32192: [SPARK-34720][SQL] MERGE ... UPDATE/INSERT * should do by-name resolution
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #32192:
URL: https://github.com/apache/spark/pull/32192#issuecomment-835537246
Also, cc @sunchao and @viirya
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32192: [SPARK-34720][SQL] MERGE ... UPDATE/INSERT * should do by-name resolution
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32192:
URL: https://github.com/apache/spark/pull/32192#issuecomment-834431746
**[Test build #138256 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138256/testReport)** for PR 32192 at commit [`19d77ea`](https://github.com/apache/spark/commit/19d77eadfb176a77c110d654b6ca9aa78ee4d6a9).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #32192: [SPARK-34720][SQL] MERGE ... UPDATE/INSERT * should do by-name resolution
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #32192:
URL: https://github.com/apache/spark/pull/32192#issuecomment-836295271
I've made it clear at the beginning of the PR description: INSERT/UPDATE * is an extension and I can't find it in other mainstream databases. If you open the docs you posted, none of them (except for Delta lake) supports INSERT/UPDATE *.
Actually the original Spark PR to add MERGE SQL syntax was following https://docs.databricks.com/spark/latest/spark-sql/language-manual/delta-merge-into.html . It's a mistake that the INSERT/UPDATE * behavior is different and the current behavior is super confusing that we'd better fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #32192: [SPARK-34720][SQL] MERGE ... UPDATE/INSERT * should do by-name resolution
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #32192:
URL: https://github.com/apache/spark/pull/32192#issuecomment-820534715
cc @tdas @dongjoon-hyun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32192: [SPARK-34720][SQL] MERGE ... UPDATE/INSERT * should do by-name resolution
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32192:
URL: https://github.com/apache/spark/pull/32192#issuecomment-834478622
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42778/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32192: [SPARK-34720][SQL] MERGE ... UPDATE/INSERT * should do by-name resolution
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32192:
URL: https://github.com/apache/spark/pull/32192#issuecomment-834483630
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42778/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32192: [SPARK-34720][SQL] MERGE ... UPDATE/INSERT * should do by-name resolution
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32192:
URL: https://github.com/apache/spark/pull/32192#issuecomment-834491087
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42778/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org