Re: Review Request 57990: RANGER-1480 : Druid plugin. Only 'unsecure' mode is tested, authentication should be provided independently (by the kerberos extension)

[Colm O hEigeartaigh <co...@apache.org>]

> On March 29, 2017, 4:06 p.m., Colm O hEigeartaigh wrote:
> > Pretty cool to see new plugins being submitted! What is the scenario for supporting "unsecure" mode (should be "insecure" IMO btw)? Some documentation would be nice as to how to use/deploy the plugin....could you contribute something to the wiki? Is it your intentation to also support configuring the plugin in the UI?

*bump* in case you missed my comments.


- Colm


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57990/#review170415
-----------------------------------------------------------


On May 9, 2017, 12:13 p.m., Zsombor Gegesy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57990/
> -----------------------------------------------------------
> 
> (Updated May 9, 2017, 12:13 p.m.)
> 
> 
> Review request for ranger.
> 
> 
> Bugs: RANGER-1480
>     https://issues.apache.org/jira/browse/RANGER-1480
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Druid plugin - which should be deployed as a druid extension, and the druid-service which should be running inside the ranger admin.
> To make it more simple, the plugin is built into one jar - which is still huge ~25MB, but the deployment is more straightforward.
> As ranger haven't had 3 level module system, minor fixes needed by the maven build.
> 
> 
> Diffs
> -----
> 
>   agents-common/src/main/resources/service-defs/ranger-servicedef-druid.json PRE-CREATION 
>   druid/README.txt PRE-CREATION 
>   druid/druid-service/pom.xml PRE-CREATION 
>   druid/druid-service/src/main/java/org/apache/ranger/service/druid/RangerDruidService.java PRE-CREATION 
>   druid/plugin-druid/conf/ranger-druid-audit.xml PRE-CREATION 
>   druid/plugin-druid/conf/ranger-druid-security.xml PRE-CREATION 
>   druid/plugin-druid/pom.xml PRE-CREATION 
>   druid/plugin-druid/src/main/java/org/apache/ranger/druid/DruidResource.java PRE-CREATION 
>   druid/plugin-druid/src/main/java/org/apache/ranger/druid/PluginConfig.java PRE-CREATION 
>   druid/plugin-druid/src/main/java/org/apache/ranger/druid/RangerAuthorizationInfo.java PRE-CREATION 
>   druid/plugin-druid/src/main/java/org/apache/ranger/druid/RangerFilter.java PRE-CREATION 
>   druid/plugin-druid/src/main/java/org/apache/ranger/druid/RangerFilterHolder.java PRE-CREATION 
>   druid/plugin-druid/src/main/java/org/apache/ranger/druid/RangerPlugin.java PRE-CREATION 
>   druid/plugin-druid/src/main/java/org/apache/ranger/druid/ReadonlyAuthorizationInfo.java PRE-CREATION 
>   druid/plugin-druid/src/main/resources/META-INF/services/io.druid.initialization.DruidModule PRE-CREATION 
>   druid/plugin-druid/src/test/java/org/apache/ranger/druid/RangerAuthorizationInfoTest.java PRE-CREATION 
>   druid/plugin-druid/src/test/java/org/apache/ranger/druid/RangerFilterTest.java PRE-CREATION 
>   druid/plugin-druid/src/test/java/org/apache/ranger/druid/ReadonlyAuthorizationInfoTest.java PRE-CREATION 
>   druid/pom.xml PRE-CREATION 
>   pom.xml 70ab89e 
> 
> 
> Diff: https://reviews.apache.org/r/57990/diff/2/
> 
> 
> Testing
> -------
> 
> Running a local druid cluster, creating policy, using autocomplete field for finding datasources, etc
> 
> 
> Thanks,
> 
> Zsombor Gegesy
> 
>